· /firmware/App/Modes/ModeTreatment.c	(-9, +11)	| History	| Source	| Diff
· /firmware/App/Modes/ModeTreatment.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/OperationModes.c	(-32, +12)	| History	| Source	| Diff
· /firmware/App/Modes/OperationModes.h	(-1, +0)	| History	| Source	| Diff
· /firmware/App/Modes/StateTxBloodPrime.c	(-0, +7)	| History	| Source	| Diff
· /firmware/App/Modes/StateTxPaused.c	(-16, +6)	| History	| Source	| Diff
· /firmware/App/Modes/StateTxRecirc.c	(-36, +36)	| History	| Source	| Diff
· /firmware/App/Modes/StateTxRinseback.c	(-93, +91)	| History	| Source	| Diff
· /firmware/App/Monitors/Pressures.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-1, +0)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtTD.c	(-376, +361)	| History	| Source	| Diff
· /firmware/App/Services/StateServices/FluidBolus.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommTD.c	(-140, +140)	| History	| Source	| Diff

]]> Wed, 15 Jul 2026 09:15:19 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4028-2 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4028-2 Vendor - TEL - Arpita Srivastava finished reviewing LEAHI-TD-FIRMWARE-LDT-4028-2 LEAHI-TD-FIRMWARE-LDT-4028_Pre-Treatment - FW Implementation - 3/6: ]]> Tue, 14 Jul 2026 23:15:34 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4029-1/#c30500 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4029-1/#c30500 Sean Nash replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-4029-1

I don't see any change here. How does this function get called? I don't see the function being used anywhere - nobody is calling it. I think it should be called by Messaging.c when a UI confirmation msg is received.

I thought we'd removed the first 3 states. Isn't install state the first state? Maybe Praneeth did that and it will show up when you merge staging into your branch.

171

Update all function headers in this file to Leahi style (e.g. \b before inputs/outputs).

Add extra line (should be 2 lines) after test support banner.

Remove extra blank line.

Update function header format from Denali to Leahi style (e.g. \b for inputs/outputs) throughout this file.

currentInstallState is an input.

Do we need doxygen comments for static function declarations?
We will have a header in the definition.

AirPump.h should be above AirTrap.h

Who is calling this function? Should be coming from UI, right? So should be a message handler (returns BOOL, takes a message as param, function is in table at top of Messaging.c).

Need to set state to preload state I think. Otherwise you will go to interrupted state.

Why did you remote call to init function here? Is it initialized somewhere else?

Use ternary operation to assign TRUE or FALSE explicitly.

This is at end of enum list above. So it should be at end of table here.

it will be adjusted when I merge latest staging

not required anymore, forgot to remove

I think a comment here is needed. Keep it and maybe mention rinseback alarm responses too.

Maybe this should be handled in OperationModes exec since it applies to all confirmations (not just alarm related ones).

There will be confirmations that are not handled here (e.g. power off). So we shouldn't fault in default - we should do nothing.

Shutdown would be handled somewhere else (buttons.c probably). It's not related to alarms.

Is this still possible since we're not returning to TxPaused from rinseback anymore?

Is rinseback completed an indication that we've done a blood prime following a temporary break?
If so, I guess this makes sense, but we have to do more than increase the UF volume. We have to adjust the UF rate so that we will reach the new (larger) UF volume when the treatment completes.
We also need to add RB volume to UF volume in pre-tx when treatment parameters are given/validated (for the final rinseback which we will always have so we should just plan for it before treatment starts).

What if multiple confirmations pending? Which ID will this function return?

Align comments.
Should substitution pump data be moved down to 0xBA instead of commented out?

What alarm is this? It doesn't look like you've added a new alarm. This is one of the reserved (unused) alarms that UI s/w might use.

Do we really need these setup functions for each state? They all look very simple - just 1 or 2 lines of code.