Fisheye on td-firmware/firmware/App/Drivers/RotaryValve.h

LEAHI-TD-FIRMWARE-LDT-4049-1: comment by Sean Nash "Is this too early to tell DD to start? Ask Vin..."

Sean Nash — Tue, 14 Jul 2026 17:02:37 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4049-1

Is this too early to tell DD to start? Ask Vinay.

LEAHI-TD-FIRMWARE-LDT-4049-1: comment by Sean Nash "Initialize post treatment too."

Sean Nash — Tue, 14 Jul 2026 17:01:53 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4049-1

Initialize post treatment too.

LEAHI-TD-FIRMWARE-LDT-4049-1: comment by Sean Nash "Delete this. No treatment params mode in Leahi..."

Sean Nash — Tue, 14 Jul 2026 17:01:10 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4049-1

Delete this. No treatment params mode in Leahi.

LEAHI-TD-FIRMWARE-LDT-4049-1: comment by Sean Nash "Add blank line between declarations and code."

Sean Nash — Tue, 14 Jul 2026 17:00:11 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4049-1

Add blank line between declarations and code.

LEAHI-TD-FIRMWARE-LDT-4049-1: comment by Sean Nash "I would keep this stuff commented out until dis..."

Sean Nash — Tue, 14 Jul 2026 16:58:24 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4049-1

I would keep this stuff commented out until disinfection is implemented.

LEAHI-TD-FIRMWARE-LDT-4049-1: comment by Sean Nash "Door already not required. Remove."

Sean Nash — Tue, 14 Jul 2026 16:55:36 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4049-1

Door already not required. Remove.

LEAHI-TD-FIRMWARE-LDT-4049-1: comment by Sean Nash "break into 2 lines."

Sean Nash — Tue, 14 Jul 2026 16:54:59 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4049-1

break into 2 lines.

LEAHI-TD-FIRMWARE-LDT-4049-1: comment by Sean Nash "Let's comment remaining states for now."

Sean Nash — Tue, 14 Jul 2026 16:52:46 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4049-1

Let's comment remaining states for now.

LEAHI-TD-FIRMWARE-LDT-4049-1: comment by Sean Nash "Remove this line. There is no syringe detectio..."

Sean Nash — Tue, 14 Jul 2026 16:52:19 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4049-1

Remove this line. There is no syringe detection.

LEAHI-TD-FIRMWARE-LDT-4049-1: comment by Sean Nash "Door is probably not required to be closed in s..."

Sean Nash — Tue, 14 Jul 2026 16:51:40 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4049-1

Door is probably not required to be closed in standby. Change to FALSE.

LEAHI-TD-FIRMWARE-LDT-4049-1: comment by Sean Nash "Let's remove this for now."

Sean Nash — Tue, 14 Jul 2026 16:51:03 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4049-1

Let's remove this for now.

LEAHI-TD-FIRMWARE-LDT-4049-1: comment by Sean Nash "Service record not yet available. Comment out ..."

Sean Nash — Tue, 14 Jul 2026 16:43:23 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4049-1

Service record not yet available. Comment out with TODO

LEAHI-TD-FIRMWARE-LDT-4049-1: comment by Sean Nash "INVALID_REQUEST_FORMAT"

Sean Nash — Tue, 14 Jul 2026 16:35:10 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4049-1

INVALID_REQUEST_FORMAT

LEAHI-TD-FIRMWARE-LDT-4049-1: comment by Sean Nash "I think we can do this check now, right?"

Sean Nash — Tue, 14 Jul 2026 16:33:03 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4049-1

I think we can do this check now, right?

LEAHI-TD-FIRMWARE-LDT-4049-1: comment by Sean Nash "Change reject reason to DD_BUSY."

Sean Nash — Tue, 14 Jul 2026 16:27:12 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4049-1

Change reject reason to DD_BUSY.

LEAHI-TD-FIRMWARE-LDT-4049-1: comment by Sean Nash "Change reason to FP_BUSY"

Sean Nash — Tue, 14 Jul 2026 16:31:32 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4049-1

Change reason to FP_BUSY

LEAHI-TD-FIRMWARE-LDT-4049-1: comment by Sean Nash "Fix reject reason name (not filter temperature?..."

Sean Nash — Tue, 14 Jul 2026 16:30:42 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4049-1

Fix reject reason name (not filter temperature?)

LEAHI-TD-FIRMWARE-LDT-4049-1: comment by Sean Nash "Add a TODO"

Sean Nash — Tue, 14 Jul 2026 16:29:42 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4049-1

Add a TODO

LEAHI-TD-FIRMWARE-LDT-4049-1: comment by Sean Nash "Use structure instead of U32."

Sean Nash — Tue, 14 Jul 2026 16:16:31 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4049-1

Use structure instead of U32.

LEAHI-TD-FIRMWARE-LDT-4049-1: comment by Sean Nash "Make a structure for initiate treatment request..."

Sean Nash — Tue, 14 Jul 2026 16:14:59 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4049-1

Make a structure for initiate treatment request payload (with 1 U32 in it) and use structure instead of U32.

td-firmware (LDT-4049-standby---fw-implementation---2): LDT-4049- standby implementation

suresh — Tue, 14 Jul 2026 16:08:32 -0700

suresh committed 7a211da on branch LDT-4049-standby---fw-implementation---2 in td-firmware

LDT-4049- standby implementation

· /firmware/App/Controllers/Valves.h	(-0, +3)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/RotaryValve.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-3, +16)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeInitPOST.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-121, +515)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.h	(-0, +12)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.h	(-0, +8)	\| History	\| Source	\| Diff

LEAHI-TD-FIRMWARE-LDT-4049-1: started by Dara Navaei

Dara Navaei — Mon, 29 Jun 2026 10:16:49 -0700

Dara Navaei started review LEAHI-TD-FIRMWARE-LDT-4049-1

td-firmware (LDT-2240-disposable-tube-set-self-test): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 19 Jan 2026 17:08:21 -0800

Dara Navaei committed 395522d on branch LDT-1394-blood-flow-rate-h4-rotor-count, LDT-1415-pressures-monitoring-td and 65 more in td-firmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmAudio.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmAudio.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Ejector.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Ejector.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/BubbleDetector.c

(-1, +1)

| History

| Source

| Diff

… 82 more files in changeset.

LEAHI-TD-FIRMWARE-LDT-1886-1: closed by Dara Navaei

Dara Navaei — Fri, 19 Dec 2025 13:57:43 -0800

Dara Navaei Closed LEAHI-TD-FIRMWARE-LDT-1886-1

td-firmware (LDT-2240-disposable-tube-set-self-test): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 19 Dec 2025 13:51:56 -0800

Dara Navaei committed 65a7fc8 on branch LDT-1394-blood-flow-rate-h4-rotor-count, LDT-1415-pressures-monitoring-td and 65 more in td-firmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/AirTrap.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Ejector.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Ejector.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/EjectorMotor.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/EjectorMotor.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/PressureSensor.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/RotaryValve.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/RotaryValve.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaTD.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaTD.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/TDCommon.h	(-1, +1)	\| History	\| Source	\| Diff

td-firmware (LDT-2240-disposable-tube-set-self-test): Merge branch 'staging' into LDT-1886-blood-set-auto-load-and-auto-eject-implement-ejector-sensor

Dara Navaei — Fri, 19 Dec 2025 13:48:01 -0800

Dara Navaei committed 1537847 on branch LDT-1394-blood-flow-rate-h4-rotor-count, LDT-1415-pressures-monitoring-td and 66 more in td-firmware

Merge branch 'staging' into LDT-1886-blood-set-auto-load-and-auto-eject-implement-ejector-sensor

· /firmware/App/Controllers/AirPump.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/AirTrap.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Ejector.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Ejector.h	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.h	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/EjectorMotor.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/EjectorMotor.h	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/PressureSensor.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/RotaryValve.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/RotaryValve.h	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaTD.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaTD.h	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/TDCommon.h	(-9, +9)	\| History	\| Source	\| Diff

LEAHI-TD-FIRMWARE-LDT-1886-1: reviewers finished

Fri, 19 Dec 2025 12:16:13 -0800

Vendor - TEL - Sameer Poyil and Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-1886-1

LEAHI-TD-FIRMWARE-LDT-1886_Blood Set Auto-Load and Auto-Eject - TD

LEAHI-TD-FIRMWARE-LDT-1886-1: comment by Dara Navaei "We tend to initialize the local variables as a ..."

Dara Navaei — Thu, 18 Dec 2025 15:08:24 -0800

Dara Navaei replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1886-1

We tend to initialize the local variables as a standard practice.

LEAHI-TD-FIRMWARE-LDT-1886-1: comment by Sean Nash "These don't need to be initialized to zero."

Sean Nash — Thu, 18 Dec 2025 14:54:33 -0800

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1886-1

These don't need to be initialized to zero.

LEAHI-TD-FIRMWARE-LDT-1886-1: comment by Dara Navaei "Done"

Dara Navaei — Wed, 17 Dec 2025 11:07:58 -0800

Dara Navaei replied to Vendor - TEL - Sameer Poyil in LEAHI-TD-FIRMWARE-LDT-1886-1

Done