· /firmware/App/Modes/ModePreTreat.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreTreat.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/StatePreTxRecirculate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/StatePreTxRecirculate.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	| History	| Source	| Diff

]]> Fri, 12 Jun 2026 23:07:22 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4027-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4027-1 Sean Nash and Vendor - TEL - Arpita Srivastava finished reviewing LEAHI-TD-FIRMWARE-LDT-4027-1 LEAHI-TD-FIRMWARE-LDT-4027_Pre-Treatment - FW Implementation - 2/6: ]]> Fri, 12 Jun 2026 14:03:04 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4027-1/#c29873 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4027-1/#c29873 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-4027-1

align the comment part

This is right, but we don't have a patient connection state implemented yet so we will get stuck here if we do this now.
For now, comment out this line with a TODO to restore when patient connection state is implemented and add a temporary line of code to request treatment mode here.

· /firmware/App/Modes/ModePreTreat.c	(-12, +29)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreTreat.h	(-0, +1)	| History	| Source	| Diff
· /firmware/App/Modes/StatePreTxRecirculate.c	(-3, +3)	| History	| Source	| Diff

]]> Thu, 11 Jun 2026 15:10:06 -0700 Vendor - TEL - Vijay Pamula https://devapps.diality.us/changelog/td-firmware?cs=2df4b8aede603cf05cd54a319d85b4fb60611487 https://devapps.diality.us/changelog/td-firmware?cs=2df4b8aede603cf05cd54a319d85b4fb60611487 Vendor - TEL - Vijay Pamula committed 2df4b8a on branch LDT-2240-disposable-tube-set-self-test, LDT-3215-measured-venous-pressure-decreases and 17 more in td-firmware LDT-4027: Addressed Code review comments for Pre-Treatment Recirculate State

· /firmware/App/Modes/StatePreTxRecirculate.c

(-9, +6)

| History

| Source

| Diff

]]> Tue, 09 Jun 2026 14:38:20 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4027-1/#c29694 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4027-1/#c29694 Sean Nash replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-4027-1

You only addressed the first part of my comment above.

This medium alarm is ID 196 (from enum above). So I would expect it to be at the bottom of this table. Why are you placing it here?

Remove from input: preTxRecircStartTime, recircMediumAlarmGiven and recircResumeRequested
Remove from output: recircMediumAlarmGiven and recircResumeRequested

Output should be none.

Just curious, at what condition we leave this state?
It looks like, once we enter this state, we stay.

· /firmware/App/Modes/ModePreTreat.c	(-6, +6)	| History	| Source	| Diff
· /firmware/App/Modes/StatePreTxRecirculate.c	(-22, +15)	| History	| Source	| Diff

]]> Fri, 05 Jun 2026 13:09:40 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4027-1/#c29628 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4027-1/#c29628 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-4027-1

Please add Alarm
ALARM_ID_TD_PRIME_COMPLETED_HIGH and ALARM_ID_TD_SOFTWARE_FAULT

Add alarm ALARM_ID_TD_PRIME_COMPLETED_MEDIUM

Please add currentPreTreatmentState to inputs.

currentPreTxRecircState looks like an input.

Put recirc state after Rx state (both here in switch statement and also in enumeration).

Put in alphabetical order (before Timers.h).

Dialysate rate should be set to the Qd user setting (from Tx params).

Add /// doxygen comment for this enumeration and ///< doxygen comments to right of each enum in the list.

· /firmware/App/Modes/ModePreTreat.c	(-5, +12)	| History	| Source	| Diff
· /firmware/App/Modes/StatePreTxRecirculate.c	(-0, +277)	| History	| Source
· /firmware/App/Modes/StatePreTxRecirculate.h	(-0, +48)	| History	| Source
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-0, +1)	| History	| Source	| Diff

]]> Wed, 03 Jun 2026 14:01:51 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4027-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4027-1 Dara Navaei started review LEAHI-TD-FIRMWARE-LDT-4027-1 ]]>