Should use GENERIC_CONFIRMATION_REQUEST_T which already exists in OperationModes.h. This should be removed.

Put this back.

Need to put if condition back.

This check was correct before.

This doesn't look like a command - it looks like a status.

I don't see any change here. How does this function get called? I don't see the function being used anywhere - nobody is calling it. I think it should be called by Messaging.c when a UI confirmation msg is received.

I thought we'd removed the first 3 states. Isn't install state the first state? Maybe Praneeth did that and it will show up when you merge staging into your branch.

171

Update all function headers in this file to Leahi style (e.g. \b before inputs/outputs).

Add extra line (should be 2 lines) after test support banner.

Remove extra blank line.

Update function header format from Denali to Leahi style (e.g. \b for inputs/outputs) throughout this file.

currentInstallState is an input.

Do we need doxygen comments for static function declarations?
We will have a header in the definition.

AirPump.h should be above AirTrap.h

Who is calling this function? Should be coming from UI, right? So should be a message handler (returns BOOL, takes a message as param, function is in table at top of Messaging.c).

Need to set state to preload state I think. Otherwise you will go to interrupted state.

Why did you remote call to init function here? Is it initialized somewhere else?

Use ternary operation to assign TRUE or FALSE explicitly.

This is at end of enum list above. So it should be at end of table here.

it will be adjusted when I merge latest staging

not required anymore, forgot to remove

I think a comment here is needed. Keep it and maybe mention rinseback alarm responses too.

Maybe this should be handled in OperationModes exec since it applies to all confirmations (not just alarm related ones).

There will be confirmations that are not handled here (e.g. power off). So we shouldn't fault in default - we should do nothing.