· /firmware/App/Drivers/BatteryDriver.c	(-0, +1)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-0, +2)	| History	| Source	| Diff

]]> Sat, 27 Jun 2026 09:10:18 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4072-2/#c30192 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4072-2/#c30192 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4072-2

Where is testBatteryI2cStatusOverride (from BatteryDriver)?

Add blank line before return statement.

· /firmware/App/Drivers/BatteryDriver.c	(-36, +36)	| History	| Source	| Diff
· /firmware/App/Drivers/BatteryDriver.h	(-6, +5)	| History	| Source	| Diff
· /firmware/App/Monitors/Battery.c	(-154, +164)	| History	| Source	| Diff
· /firmware/App/Monitors/Battery.h	(-15, +13)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-3, +1)	| History	| Source	| Diff

]]> Mon, 22 Jun 2026 16:35:52 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4072-2/#c30056 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4072-2/#c30056 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4072-2

Merge these 3 override functions (and message IDs) into one "array style" override function.

( void )

Change 0xFFFFFFFF to HEX_32_BIT_FULL_SCALE

Swap the order of these two.

· /firmware/App/Drivers/BatteryDriver.c	(-7, +5)	| History	| Source	| Diff
· /firmware/App/Drivers/BatteryDriver.h	(-2, +4)	| History	| Source	| Diff
· /firmware/App/Monitors/Battery.c	(-27, +31)	| History	| Source	| Diff
· /firmware/App/Monitors/Battery.h	(-0, +1)	| History	| Source	| Diff

]]> Fri, 05 Jun 2026 16:14:56 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4072-2/#c29636 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4072-2/#c29636 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4072-2

Just use 0x0 and 0xFFFFFFFF

NUM_OF_BATTERY_REGISTERS - 1

Put 2 items at end of the list here:
BATTERY_END_OF_LIST_TIME_TO_PUBLISH
NUM_OF_BATTERY_REGISTERS

Put this one back to NUM_OF_BATTERY_DEVICES.

Don't need min/max for this. Just use 0x0 and 0xFFFFFFFF where needed.

I don't think we need these min/max #defines. Just use 0x0 for minimums and 0xFFFFFFFF for maximums.

· /firmware/App/Drivers/BatteryDriver.c	(-9, +16)	| History	| Source	| Diff
· /firmware/App/Drivers/BatteryDriver.h	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Monitors/Battery.c	(-9, +22)	| History	| Source	| Diff

]]> Wed, 27 May 2026 17:13:07 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4072-2/#c29477 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4072-2/#c29477 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4072-2

Not a float.

Not a float.

Not a float anymore. Use u32Override function and no need to cast the pointer.

Should we publish all registers read?

Remove this comment since we have a comment to right.

Remove comment.

Set them individually instead of with memset.

Add blank line before a /// comment.

device and register is fine. Or deviceSel and registerSel.

· /firmware/App/Drivers/BatteryDriver.c	(-20, +34)	| History	| Source	| Diff
· /firmware/App/Drivers/BatteryDriver.h	(-1, +27)	| History	| Source	| Diff
· /firmware/App/Monitors/Battery.c	(-38, +26)	| History	| Source	| Diff
· /firmware/App/Monitors/Battery.h	(-25, +0)	| History	| Source	| Diff

]]> Wed, 20 May 2026 10:03:45 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4072-2/#c29219 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4072-2/#c29219 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4072-2

slaveAddr should be an enum now and so just "device".

· /firmware/App/Drivers/BatteryDriver.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Battery.c	(-65, +45)	| History	| Source	| Diff
· /firmware/App/Monitors/Battery.h	(-18, +13)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskBG.c	(-2, +1)	| History	| Source	| Diff

]]> Wed, 20 May 2026 09:07:52 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4072-2/#c29217 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4072-2/#c29217 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4072-2

Add a banner before Dialin test support functions (see other units for example).

Initialize .override to OVERRIDE_RESET