· /firmware/App/Controllers/Valves.c	(-3, +0)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.h	(-12, +0)	| History	| Source	| Diff
· /firmware/App/Drivers/PinchValve.c	(-56, +48)	| History	| Source	| Diff
· /firmware/App/Drivers/PinchValve.h	(-0, +10)	| History	| Source	| Diff

]]> Thu, 23 Jul 2026 09:53:19 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/changelog/td-firmware?cs=e0060cd79d971c0ed94b8aed6949d2754480fe92 https://devapps.diality.us/changelog/td-firmware?cs=e0060cd79d971c0ed94b8aed6949d2754480fe92 Vendor - TEL - Varshini Nagabooshanam committed e0060cd on branch LDT-4149-pinch-valves-fw-implementation in td-firmware Changes

· /firmware/App/Controllers/Valves.c	(-20, +20)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Drivers/PinchValve.c	(-46, +116)	| History	| Source	| Diff
· /firmware/App/Drivers/PinchValve.h	(-1, +10)	| History	| Source	| Diff
· /firmware/App/Drivers/RotaryValve.c	(-501, +0)	| History	| Source	| Diff
· /firmware/App/Drivers/RotaryValve.h	(-70, +0)	| History	| Source	| Diff
· /firmware/App/Modes/ModeFault.c	(-1, +0)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-0, +1)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtTD.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-4, +3)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommTD.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/TDCommon.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-1, +1)	| History	| Source	| Diff

]]> Thu, 23 Jul 2026 09:07:02 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4063-1/#c30621 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4063-1/#c30621 Sean Nash replied to Vendor - TEL - Suresh Dharnala in LEAHI-TD-FIRMWARE-LDT-4063-1

So then no need to initialize it here too. Remove " = FALSE".

I agree but it is already in the init function.

Swap order of == for these 2 if statements - put constant on left side.

Why?

Why is UF volume being added here? If we add it, we need to change DD f/w too. But it is not clear to me why DD f/w needs to know the UF volume.

Use ternary operator to explicitly set to TRUE or FALSE.

Our TODO comments are all CAPs.

I think these if statements should be looking for valve state == VALVE_STATE_IDLE, not <

Fix implementation to return a BOOL (TRUE if SW_COMPATIBILITY_REV == ddVersion.compatibilityRev.

Should return T/F. Change comment to "TRUE if DD f/w is compatible with TD f/w, FALSE if not.".

Should return a BOOL (that is what ModeStandby is expecting).

Fix isDDCompatible() function so that it returns a T/F instead of a compatibility revision.

Align comment.

Why are these added? And why commented out. H13 and H20 are not rotary valves - they are 3 way valves. They do not belong here.

I think ( setTxDur - preStop ) should be changed to ( preStop ).
Also, I think preStop should be renamed to hepDurMin.

Change INPROGRESS to OPEN (because you're going to remove INPROGRESS).

You can do this sendMessage just once after else.

Should this be the "Load Syringe" alarm that you just added?
Also, does this alarm show the user how much heparin to load into the syringe? I wasn't expecting this to be an alarm.

Can we remote this TODO comment?

Remove blank line.

We should go to dry self test state. Why did this change to Rx state?

Comment - should be "install" not "instll".

add a space before and after 0

add a blank line above

add a blank line above

minor spell issue : change responceStatus to responseStatus

add offRequestAwaitingUserConfirmation and offRequestPendingTimer to outputs

should we move the initialization in the init function?