· /firmware/App/Drivers/PinchValve.c

(-29, +35)

| History

| Source

| Diff

]]> Thu, 23 Jul 2026 15:45:06 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/changelog/td-firmware?cs=04bcfefa2d7a3878f75a3bff329e1c4dc4e03de0 https://devapps.diality.us/changelog/td-firmware?cs=04bcfefa2d7a3878f75a3bff329e1c4dc4e03de0 Vendor - TEL - Varshini Nagabooshanam committed 04bcfef on branch LDT-4149-pinch-valves-fw-implementation in td-firmware Merge branch 'LDT-4149-pinch-valves-fw-implementation' of bitbucket.org:diality-cloud/td-firmware into LDT-4149-pinch-valves-fw-implementation

· /firmware/App/Drivers/PinchValve.c

(-0, +6)

| History

| Source

| Diff

]]> Thu, 23 Jul 2026 15:34:08 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/changelog/td-firmware?cs=0706d11d2e404fa864f1c0f5308a8b59694f8494 https://devapps.diality.us/changelog/td-firmware?cs=0706d11d2e404fa864f1c0f5308a8b59694f8494 Vendor - TEL - Varshini Nagabooshanam committed 0706d11 on branch LDT-4149-pinch-valves-fw-implementation in td-firmware New Add ons

· /firmware/App/Drivers/PinchValve.c	(-140, +266)	| History	| Source	| Diff
· /firmware/App/Drivers/PinchValve.h	(-0, +3)	| History	| Source	| Diff

]]> Thu, 23 Jul 2026 12:56:16 -0700 Sean Nash https://devapps.diality.us/changelog/td-firmware?cs=71e6f494ca47fd6f4a6791bf6aa8b90e4d2eeb3c https://devapps.diality.us/changelog/td-firmware?cs=71e6f494ca47fd6f4a6791bf6aa8b90e4d2eeb3c Sean Nash committed 71e6f49 on branch LDT-4149-pinch-valves-fw-implementation in td-firmware LDT-4149: Initialized ABC valve positions array.

· /firmware/App/Drivers/PinchValve.c

(-0, +6)

| History

| Source

| Diff

]]> Thu, 23 Jul 2026 11:27:55 -0700 Sean Nash https://devapps.diality.us/changelog/td-firmware?cs=5b6e0bbf5048ea88c978afed93b03b29d6ce98f1 https://devapps.diality.us/changelog/td-firmware?cs=5b6e0bbf5048ea88c978afed93b03b29d6ce98f1 Sean Nash committed 5b6e0bb on branch LDT-4149-pinch-valves-fw-implementation in td-firmware LDT-4149: more changes.

· /firmware/App/Drivers/PinchValve.c

(-1, +24)

| History

| Source

| Diff

]]> Thu, 23 Jul 2026 10:39:07 -0700 Sean Nash https://devapps.diality.us/changelog/td-firmware?cs=8c14bdff486bb7299381f19672bb9761b91c332b https://devapps.diality.us/changelog/td-firmware?cs=8c14bdff486bb7299381f19672bb9761b91c332b Sean Nash committed 8c14bdf on branch LDT-4149-pinch-valves-fw-implementation in td-firmware LDT-4149: More changes.

· /firmware/App/Controllers/Valves.c	(-3, +0)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.h	(-12, +0)	| History	| Source	| Diff
· /firmware/App/Drivers/PinchValve.c	(-56, +48)	| History	| Source	| Diff
· /firmware/App/Drivers/PinchValve.h	(-0, +10)	| History	| Source	| Diff

]]> Thu, 23 Jul 2026 09:53:19 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/changelog/td-firmware?cs=e0060cd79d971c0ed94b8aed6949d2754480fe92 https://devapps.diality.us/changelog/td-firmware?cs=e0060cd79d971c0ed94b8aed6949d2754480fe92 Vendor - TEL - Varshini Nagabooshanam committed e0060cd on branch LDT-4149-pinch-valves-fw-implementation in td-firmware Changes

· /firmware/App/Controllers/Valves.c	(-20, +20)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Drivers/PinchValve.c	(-46, +116)	| History	| Source	| Diff
· /firmware/App/Drivers/PinchValve.h	(-1, +10)	| History	| Source	| Diff
· /firmware/App/Drivers/RotaryValve.c	(-501, +0)	| History	| Source	| Diff
· /firmware/App/Drivers/RotaryValve.h	(-70, +0)	| History	| Source	| Diff
· /firmware/App/Modes/ModeFault.c	(-1, +0)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-0, +1)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtTD.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-4, +3)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommTD.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/TDCommon.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-1, +1)	| History	| Source	| Diff

]]> Thu, 23 Jul 2026 09:06:07 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4072-2 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4072-2 Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-4072-2 LEAHI-TD-FIRMWARE-LDT-4072_Power Loss - FW Implementation - 2/3: ]]> Wed, 22 Jul 2026 11:32:17 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4049-1/#c30613 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4049-1/#c30613 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4049-1

Swap order of == for these 2 if statements - put constant on left side.

Why?

Why is UF volume being added here? If we add it, we need to change DD f/w too. But it is not clear to me why DD f/w needs to know the UF volume.

Use ternary operator to explicitly set to TRUE or FALSE.

Our TODO comments are all CAPs.

I think these if statements should be looking for valve state == VALVE_STATE_IDLE, not <

Fix implementation to return a BOOL (TRUE if SW_COMPATIBILITY_REV == ddVersion.compatibilityRev.

Should return T/F. Change comment to "TRUE if DD f/w is compatible with TD f/w, FALSE if not.".

Should return a BOOL (that is what ModeStandby is expecting).

Fix isDDCompatible() function so that it returns a T/F instead of a compatibility revision.

Align comment.

Why are these added? And why commented out. H13 and H20 are not rotary valves - they are 3 way valves. They do not belong here.

Add comments to right.

2 blank lines before and after.

Move declarations into this if scope.

Remove blank line.

Remove (void)

Library includes should come first and they should be in <>. Also add comment listing math functions you're using in this unit.

Do we need this?

Change this to work for any state (passed as parameter).

Fixed

Remove