· /firmware/App/Services/FpgaTD.c	(-7, +160)	| History	| Source	| Diff
· /firmware/App/Services/FpgaTD.h	(-0, +12)	| History	| Source	| Diff

]]> Mon, 08 Jun 2026 15:30:25 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4329-1/#c29646 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4329-1/#c29646 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4329-1

60 should be coming from somewhere. Is there not a treatment parameter for vitals measurement interval? I think we do (TREATMENT_PARAM_BP_MEAS_INTERVAL).

Make a local BOOL variable and assign it TRUE or FALSE with a ternary operator and then return that local BOOl variable.

These should be moved down to an "else" in the if statement below (payload length check).

It doesn't look like these memsets are necessary. Consider removing them.

Remove blank line.

Can you move this down with the other vitals functions?

Just use 0x0 and 0xFFFFFFFF

NUM_OF_BATTERY_REGISTERS - 1

Put 2 items at end of the list here:
BATTERY_END_OF_LIST_TIME_TO_PUBLISH
NUM_OF_BATTERY_REGISTERS

Put this one back to NUM_OF_BATTERY_DEVICES.

Don't need min/max for this. Just use 0x0 and 0xFFFFFFFF where needed.

I don't think we need these min/max #defines. Just use 0x0 for minimums and 0xFFFFFFFF for maximums.

Please add Alarm
ALARM_ID_TD_PRIME_COMPLETED_HIGH and ALARM_ID_TD_SOFTWARE_FAULT

Add alarm ALARM_ID_TD_PRIME_COMPLETED_MEDIUM

Please add currentPreTreatmentState to inputs.

currentPreTxRecircState looks like an input.

· /firmware/App/TDCommon.h

(-1, +1)

| History

| Source

| Diff

]]> Fri, 05 Jun 2026 10:29:11 -0700 Dara Navaei https://devapps.diality.us/changelog/td-firmware?cs=9c833ef5623ce842267e284d958820ac0dc3a7fc https://devapps.diality.us/changelog/td-firmware?cs=9c833ef5623ce842267e284d958820ac0dc3a7fc Dara Navaei committed 9c833ef on branch LDT-4149-pinch-valves-fw-implementation, LDT-4329-edit-treatment-parameters-during-treatment, staging in td-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodFlow.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreTreat.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeTreatment.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeTreatment.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/StateTxBloodPrime.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/StateTxBloodPrime.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/StateTxDialysis.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/StateTxDialysis.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/StateTxPaused.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/StateTxPaused.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Pressures.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtTD.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/DDInterface.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/DDInterface.h	(-2, +2)	| History	| Source	| Diff
… 7 more files in changeset.

]]> Fri, 05 Jun 2026 10:08:02 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1 Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-4013-1 LEAHI-TD-FIRMWARE-LDT-4013_Fluid Bolus - FW Implementation - 2/4: ]]> Fri, 05 Jun 2026 09:46:58 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4505-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4505-1 Dara Navaei started review LEAHI-TD-FIRMWARE-LDT-4505-1 ]]> Thu, 04 Jun 2026 13:44:12 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4027-1/#c29624 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4027-1/#c29624 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4027-1

Put recirc state after Rx state (both here in switch statement and also in enumeration).

Put in alphabetical order (before Timers.h).

Where do we trigger high priority prime completed alarm?

Dialysate rate should be set to the Qd user setting (from Tx params).

Add /// doxygen comment for this enumeration and ///< doxygen comments to right of each enum in the list.