· /firmware/App/Drivers/PinchValve.c

(-29, +35)

| History

| Source

| Diff

]]> Thu, 23 Jul 2026 15:45:06 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/changelog/td-firmware?cs=04bcfefa2d7a3878f75a3bff329e1c4dc4e03de0 https://devapps.diality.us/changelog/td-firmware?cs=04bcfefa2d7a3878f75a3bff329e1c4dc4e03de0 Vendor - TEL - Varshini Nagabooshanam committed 04bcfef on branch LDT-4149-pinch-valves-fw-implementation in td-firmware Merge branch 'LDT-4149-pinch-valves-fw-implementation' of bitbucket.org:diality-cloud/td-firmware into LDT-4149-pinch-valves-fw-implementation

· /firmware/App/Drivers/PinchValve.c

(-0, +6)

| History

| Source

| Diff

]]> Thu, 23 Jul 2026 15:34:08 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/changelog/td-firmware?cs=0706d11d2e404fa864f1c0f5308a8b59694f8494 https://devapps.diality.us/changelog/td-firmware?cs=0706d11d2e404fa864f1c0f5308a8b59694f8494 Vendor - TEL - Varshini Nagabooshanam committed 0706d11 on branch LDT-4149-pinch-valves-fw-implementation in td-firmware New Add ons

· /firmware/App/Drivers/PinchValve.c	(-140, +266)	| History	| Source	| Diff
· /firmware/App/Drivers/PinchValve.h	(-0, +3)	| History	| Source	| Diff

]]> Thu, 23 Jul 2026 12:56:16 -0700 Sean Nash https://devapps.diality.us/changelog/td-firmware?cs=71e6f494ca47fd6f4a6791bf6aa8b90e4d2eeb3c https://devapps.diality.us/changelog/td-firmware?cs=71e6f494ca47fd6f4a6791bf6aa8b90e4d2eeb3c Sean Nash committed 71e6f49 on branch LDT-4149-pinch-valves-fw-implementation in td-firmware LDT-4149: Initialized ABC valve positions array.

· /firmware/App/Drivers/PinchValve.c

(-0, +6)

| History

| Source

| Diff

]]> Thu, 23 Jul 2026 11:48:30 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4040-1/#c30676 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4040-1/#c30676 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-4040-1

break this line

recircPublishTimerCtr is an output

Add @message MSG_ID_TD_RECIRCULATE_RESPONSE

break this line

Initialization missing for the following variables in the init function.

startRecircRequested
reconnectRequested
backToTreatmentRequested
resumeRecircRequested

All signal flags are initialized in resetSignalFlags() which we are calling below

· /firmware/App/Drivers/PinchValve.c

(-1, +24)

| History

| Source

| Diff

]]> Thu, 23 Jul 2026 11:23:19 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4040-1/#c30670 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4040-1/#c30670 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-4040-1

please update the alarm id reservation sheet.

Why is MSG_ID_DD_SUBSTITUTION_PUMP_DATA commented out?
Line 214 and 215 are using tabs instead of whitespace characters because of which the alignment is off.

break this line : one variable per line will be easy to read.

StateTxRecirc should be above StateTxRinseback

Add @Alarm ALARM_ID_TD_SALINE_BAG_VOLUME_LOW_ALARM

break this line

break this line

Add rinsebackPublishTimerCtr to outputs

add rinsebackPublishTimerCtr to outputs

break this line

add rinsebackPublishTimerCtr to outputs

break this line

break this into two or more lines

break the comment in two lines

Do we need the alarm?

Add fluidType to inputs

Update spelling of cummulativeRinsebackVolume_mL

break into two lines

break into two lines