· /firmware/App/Services/SystemCommTD.h

(-2, +1)

| History

| Source

| Diff

]]> Fri, 20 Feb 2026 13:50:50 -0800 Raghu Kallala https://devapps.diality.us/changelog/td-firmware?cs=316cb40192e5d6be69682d5c9df01d890e2c213f https://devapps.diality.us/changelog/td-firmware?cs=316cb40192e5d6be69682d5c9df01d890e2c213f Raghu Kallala committed 316cb40 on branch LDT-473-treatment-parameters-create-rx-beta in td-firmware LDT-473 addressed review comments

· /firmware/App/Modes/ModeTreatment.c	(-1, +30)	| History	| Source	| Diff
· /firmware/App/Modes/ModeTreatment.h	(-2, +4)	| History	| Source	| Diff
· /firmware/App/Services/DDInterface.c	(-2, +4)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommTD.c	(-29, +1)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommTD.h	(-4, +1)	| History	| Source	| Diff

]]> Fri, 20 Feb 2026 13:42:09 -0800 Raghu Kallala https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-2/#c27518 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-2/#c27518 Raghu Kallala replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-473-2

Updated

Updated

I think this function should be in ModeTreatment or Messaging.

update params in header.

you are right, I missed it here.
Fixed.

Move pop to be right after last structure to be packed.

I thought acid fields were F32?

removed both enums

· /firmware/App/Modes/ModeStandby.c	(-5, +6)	| History	| Source	| Diff
· /firmware/App/Modes/ModeTreatment.c	(-7, +11)	| History	| Source	| Diff
· /firmware/App/Modes/ModeTreatment.h	(-0, +11)	| History	| Source	| Diff
· /firmware/App/Modes/StateTxDialysis.c	(-4, +6)	| History	| Source	| Diff
· /firmware/App/Services/DDInterface.c	(-5, +9)	| History	| Source	| Diff
· /firmware/App/Services/DDInterface.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommTD.c	(-0, +28)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommTD.h	(-1, +5)	| History	| Source	| Diff
· /firmware/App/Services/TxParams.c	(-9, +14)	| History	| Source	| Diff
· /firmware/App/Services/TxParams.h	(-0, +1)	| History	| Source	| Diff

]]> Fri, 20 Feb 2026 11:26:31 -0800 Raghu Kallala https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-2/#c27492 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-2/#c27492 Raghu Kallala replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-473-2

Updated

Updated

Had that question. Thanks
Changed to else block

Updated

This will be gone once we have institutional records, do you still want me to move it to a separate func?

Fixed

Can we uncomment these and send msg?

Can we uncomment this and send the limits to the UI?

Should we cast these to (S32)?

These 2 last values have already been used above. Change to 154 and 155.

Can this stuff down here be done in a separate function that is called here? This function is too big.

Should this just be an "else" to above condition?

When do you plan on removing this?

fixed

reworded

Updated

replace with else block