Shouldn't this be in ModePostTreatment?

void cmdStartDDDisinfection( DD_COMMAND_T disCmdType )

Update this to work for all standby states w/ switch statement on given "new" state.

Why zeroes? Why not send TD version constants?

Add parameter (disinfection cmd enum from DDDefs.h). Then only need one signal function for all disinfection types.

change enum name too. need 1 alarm for each disinfection type.

Just do one dd disinfect request msg with a command ID payload (from enum in DDDefs.h).

Missing some disinfects.

Move up after HCOL

· /firmware/App/Controllers/SyringePump.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/OperationModes.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/OperationModes.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Buttons.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Buttons.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/CpldInterface.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommTD.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommTD.h	(-2, +2)	| History	| Source	| Diff

]]> Wed, 05 Aug 2026 16:54:48 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4063-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4063-1 Vendor - TEL - Arpita Srivastava and Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-4063-1 LEAHI-TD-FIRMWARE-LDT-4063_Power Control and POST - FW Implementation - 1/6: ]]> Wed, 05 Aug 2026 15:57:44 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4063-1/#c31052 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4063-1/#c31052 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-4063-1

These new functions should be above the test functions.

Please align with the Messaging.c file.
It looks correct in the Messaging.c file.

Move this above the test functions.

What is the use case of this header include?

align comment

When we send any message to UI, usually add the message id in the doxygen header like this.

@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE

Please refer to the function sendTreatmentParamsResponse()

When we send any message to UI, usually add the message id in the doxygen header like this.

• @details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE

Please refer to the function sendTreatmentParamsResponse()

When we send any message to UI, usually add the message id in the doxygen header like this.

• @details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE

Please refer to the function sendTreatmentParamsResponse()

It looks like the rows may be misaligned with the alarm ID declarations.
For example, ALARM_ID_TD_SAFETY_SHUTDOWN_POST_TEST_FAILED is declared as 207.

Should Instructions part be this?

A problem was detected with the hemodialysis device.

Please confirm if the source is DD?

· /firmware/App/Modes/ModeInitPOST.c

(-1, +1)

| History

| Source

| Diff

]]> Mon, 03 Aug 2026 14:31:00 -0700 suresh https://devapps.diality.us/changelog/td-firmware?cs=8b97a7e50a19f1c243559ad77c69b6a9e6ad067a https://devapps.diality.us/changelog/td-firmware?cs=8b97a7e50a19f1c243559ad77c69b6a9e6ad067a suresh committed 8b97a7e on branch LDT-2240-disposable-tube-set-self-test, LDT-3992-disposable-tube-set-auto-priming and 14 more in td-firmware LDT-4063: Addressed review comments

· /firmware/App/Modes/ModeInitPOST.c	(-78, +61)	| History	| Source	| Diff
· /firmware/App/Modes/OperationModes.c	(-9, +18)	| History	| Source	| Diff
· /firmware/App/Monitors/Buttons.c	(-3, +2)	| History	| Source	| Diff
· /firmware/App/Services/CpldInterface.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommTD.c	(-1, +0)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommTD.h	(-1, +0)	| History	| Source	| Diff

]]> Fri, 31 Jul 2026 09:33:35 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4063-1/#c30937 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4063-1/#c30937 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-4063-1

What is the use case of including this header?

What is the use case of including this header?

Should we move this up before the test functions?

Add @messages MSG_ID_TD_POST_FINAL_TEST_RESULT

Add @messages MSG_ID_TD_POST_SINGLE_TEST_RESULT

is the function description correct?
change DG -> DD