Fisheye on leahi-dialin/leahi_dialin/dd/dialysate_delivery.py

LEAHI-DIALIN-LDT-5205-2: comment by Zoltan Miskolci "fixed"

Zoltan Miskolci — Thu, 13 Aug 2026 10:37:46 -0700

Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-5205-2

fixed

LEAHI-DIALIN-LDT-5205-2: comment by Raghu Kallala "Fix typo"

Raghu Kallala — Thu, 13 Aug 2026 09:57:08 -0700

Raghu Kallala commented on LEAHI-DIALIN-LDT-5205-2

Fix typo

LEAHI-DIALIN-LDT-5205-2: started by Dara Navaei

Dara Navaei — Tue, 11 Aug 2026 14:59:55 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-5205-2

LEAHI-DIALIN-LDT-5152-1: closed by Zoltan Miskolci

Zoltan Miskolci — Tue, 11 Aug 2026 09:34:58 -0700

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-5152-1

LEAHI-DIALIN-LDT-5152-1: comment by Zoltan Miskolci "I think that's what is usually shown, the first..."

Zoltan Miskolci — Mon, 10 Aug 2026 15:35:30 -0700

Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-5152-1

I think that's what is usually shown, the first 7 char, but in this case it might have been a typo

LEAHI-DIALIN-LDT-5152-1: reviewers finished

Mon, 10 Aug 2026 15:07:00 -0700

Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-5152-1

LEAHI-DIALIN-LDT-5152_[Dialin] Handler architecture refactor

LEAHI-DIALIN-LDT-5152-1: comment by Raghu Kallala "Was it a regulatory requirement before to have ..."

Raghu Kallala — Mon, 10 Aug 2026 14:29:02 -0700

Raghu Kallala commented on LEAHI-DIALIN-LDT-5152-1

Was it a regulatory requirement before to have 7 characters from commit ID or something we implemented?

LEAHI-DIALIN-LDT-5152-1: comment by Zoltan Miskolci "No need, in a different CR I have a module that..."

Zoltan Miskolci — Fri, 07 Aug 2026 15:48:20 -0700

Zoltan Miskolci replied to Michael Garthwaite in LEAHI-DIALIN-LDT-5152-1

No need, in a different CR I have a module that pulls the Alarm ID, Reject Reason and Msg Ids directly from the FW. After that's merged, this file won't be needed any more manual update.

For more information check LDT-5205 CR, file: utils\ enum_updater.py

LEAHI-DIALIN-LDT-5152-1: reviewers finished

Thu, 06 Aug 2026 22:21:37 -0700

Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-5152-1

LEAHI-DIALIN-LDT-5152_[Dialin] Handler architecture refactor

LEAHI-DIALIN-LDT-5152-1: comment by Michael Garthwaite "In FW we pre-populated Alarm IDs up to 300 to h..."

Michael Garthwaite — Thu, 06 Aug 2026 22:08:47 -0700

Michael Garthwaite commented on LEAHI-DIALIN-LDT-5152-1

In FW we pre-populated Alarm IDs up to 300 to help with the reservation process. Would this also benefit dialin if we reserve up to 300?

LEAHI-DIALIN-LDT-4484-1: closed by Zoltan Miskolci

Zoltan Miskolci — Wed, 05 Aug 2026 15:02:58 -0700

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-4484-1

LEAHI-DIALIN-LDT-4484-1: reviewers finished

Wed, 05 Aug 2026 08:34:10 -0700

Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-4484-1

LEAHI-DIALIN-LDT-4484_[Dialin] Create Dry Self Test module in dialin

LEAHI-DIALIN-LDT-4484-1: reviewers finished

Wed, 29 Jul 2026 15:20:31 -0700

Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-4484-1

LEAHI-DIALIN-LDT-4484_[Dialin] Create Dry Self Test module in dialin

leahi-dialin (LDT-5205-dd_nvm_update): - refactored DD modules

Zoltan Miskolci — Wed, 29 Jul 2026 12:26:45 -0700

Zoltan Miskolci committed eca9e15 on branch LDT-5152-handler_refactor, LDT-5205-dd_nvm_update and 4 more in leahi-dialin

- refactored DD modules

· /leahi_dialin/common/dd_defs.py

(-2, +2)

| History

| Source

| Diff

· /leahi_dialin/common/dd_defs_proxy.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/dialysate_delivery.py

(-2, +2)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dialysate_pump.py

(-27, +41)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/drybicart.py

(-31, +191)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/gen_dialysate.py

(-10, +69)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/heaters.py

(-33, +65)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/levels.py

(-16, +39)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/mixing_cntrl.py

(-46, +242)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/post_gen_dialysate.py

(-4, +25)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/pre_gen_dialysate.py

(-18, +98)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/pressure_sensors.py

(-12, +26)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/rinse_pump.py

(-8, +49)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/spent_chamber_fill.py

(-8, +49)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/substitution_pump.py

(-14, +27)

| History

| Source

| Diff

… 4 more files in changeset.

leahi-dialin (LDT-5205-dd_nvm_update): - Updated descriptions - Refactored FP module - Refactored DD module

Zoltan Miskolci — Wed, 29 Jul 2026 11:13:42 -0700

Zoltan Miskolci committed ba415df on branch LDT-5152-handler_refactor, LDT-5205-dd_nvm_update and 4 more in leahi-dialin

- Updated descriptions - Refactored FP module - Refactored DD module

· /leahi_dialin/common/dd_defs_proxy.py

(-55, +55)

| History

| Source

| Diff

· /leahi_dialin/dd/dialysate_delivery.py

(-45, +96)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/alarms.py

(-156, +50)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/balancing_chamber.py

(-20, +118)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/blood_leak.py

(-48, +165)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/concentrate_pump.py

(-33, +56)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/conductivity_sensors.py

(-30, +48)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dd_test_configs.py

(-15, +35)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/temperature_sensors.py

(-29, +43)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/ultrafiltration.py

(-10, +69)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/valves.py

(-162, +127)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/voltages.py

(-20, +35)

| History

| Source

| Diff

· /leahi_dialin/dd/proxies/ro_proxy.py

(-0, +10)

| History

| Source

| Diff

· /leahi_dialin/dd/proxies/td_proxy.py

(-26, +39)

| History

| Source

| Diff

· /leahi_dialin/fp/filtration_purification.py

(-43, +125)

| History

| Source

| Diff

… 29 more files in changeset.

leahi-dialin (LDT-5205-dd_nvm_update): Merge branch 'staging' into LDT-5152-handler_refactor

Zoltan Miskolci — Wed, 22 Jul 2026 14:12:00 -0700

Zoltan Miskolci committed 4c11f61 on branch LDT-5152-handler_refactor, LDT-5205-dd_nvm_update and 4 more in leahi-dialin

Merge branch 'staging' into LDT-5152-handler_refactor

· /leahi_dialin/common/generic_defs.py	(-13, +361)	\| History	\| Source	\| Diff
· /leahi_dialin/common/td_defs_proxy.py	(-0, +15)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/dialysate_delivery.py	(-2, +4)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/balancing_chamber.py	(-7, +5)	\| History	\| Source	\| Diff
· /leahi_dialin/td/treatment_delivery.py	(-0, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/utils/abstract_classes.py	(-0, +56)	\| History	\| Source	\| Diff

leahi-dialin (LDT-5205-dd_nvm_update): - fixed msg_id imports - updated td treatment

Zoltan Miskolci — Tue, 21 Jul 2026 16:14:03 -0700

Zoltan Miskolci committed 4bbcf07 on branch LDT-5152-handler_refactor, LDT-5205-dd_nvm_update and 4 more in leahi-dialin

- fixed msg_id imports - updated td treatment

· /leahi_dialin/common/override_templates.py	(-5, +5)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/dialysate_delivery.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/filtration_purification.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/protocols/CAN.py	(-1, +3)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/treatment.py	(-125, +137)	\| History	\| Source	\| Diff
· /leahi_dialin/td/proxies/ui_proxy.py	(-1, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/td/treatment_delivery.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/utils/abstract_classes.py	(-1, +1)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-3735-1: closed by Vendor - TEL - Arpita Srivastava

Vendor - TEL - Arpita Srivastava — Tue, 21 Jul 2026 09:52:43 -0700

Vendor - TEL - Arpita Srivastava Closed LEAHI-DIALIN-LDT-3735-1

leahi-dialin (LDT-5205-dd_nvm_update): Refactor changes #1

Zoltan Miskolci — Tue, 21 Jul 2026 09:13:52 -0700

Zoltan Miskolci committed 3f4937e on branch LDT-5152-handler_refactor, LDT-5205-dd_nvm_update and 4 more in leahi-dialin

Refactor changes #1

· /leahi_dialin/common/msg_defs.py

(-152, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/dialysate_delivery.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/alarms.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/balancing_chamber.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/blood_leak.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/concentrate_pump.py

(-2, +2)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/conductivity_sensors.py

(-2, +2)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dd_test_configs.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dialysate_pump.py

(-2, +2)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/drybicart.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/events.py

(-142, +109)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/gen_dialysate.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/heaters.py

(-2, +2)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/levels.py

(-2, +2)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/mixing_cntrl.py

(-1, +1)

| History

| Source

| Diff

… 49 more files in changeset.

LEAHI-DIALIN-LDT-3735-1: reviewers finished

Tue, 21 Jul 2026 07:29:20 -0700

Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3735-1

LEAHI-DIALIN-LDT-3735_System Data and Logs - DD - Non-Volatile Memory - 04: DEV - Feature Implementation

LEAHI-DIALIN-LDT-5152-1: started by Dara Navaei

Dara Navaei — Mon, 20 Jul 2026 12:34:32 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-5152-1

LEAHI-DIALIN-LDT-3735-1: reviewers finished

Mon, 13 Jul 2026 14:46:50 -0700

Tiffany Mejia and Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-3735-1

LEAHI-DIALIN-LDT-3735_System Data and Logs - DD - Non-Volatile Memory - 04: DEV - Feature Implementation

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "Zoltan and I had a meeting, and the counter sol..."

Behrouz NematiPour — Sun, 12 Jul 2026 23:43:02 -0700

Behrouz NematiPour replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4484-1

Zoltan and I had a meeting, and the counter solution he provided works better than mine.
He explained to me that my proposed solution has flaws.
RESOLVED.

LEAHI-DIALIN-LDT-4484-1: comment by Zoltan Miskolci "The approach of what this code does and the con..."

Zoltan Miskolci — Wed, 01 Jul 2026 14:28:52 -0700

Zoltan Miskolci replied to Behrouz NematiPour in LEAHI-DIALIN-LDT-4484-1

The approach of what this code does and the conversion module are similar in function but a differ on maintenance and flexibility.
1. The conversion module's bytearray to value methods work, but they require manual logistic around the indexing. It's the user's responsibility to handle where the reading starts and you need to code the handler for that (previous approach with MsgFieldPositions), It's inflating the method. I worked hard to remove the need for indexing where the value starts. Instead of the previous struct.unpack approach, where you needed to maintain the type, you will be needing to maintain the conversion methods that are being called, so it would be the same as before, you still need to mind the indexing, which was the main reason of changing from this approach.

2. In the current approach, you declare the type and pass it to a processor that dynamically handling the unpack type (based on the set datatype) and the indexing for that. This works much better and easier to maintain, as you can just insert a new value when it's added to the FW, and don't need to adjust all your indexes for the reading.

Example #1, changing build type from U16 to U08:

with the conversion approach, you need to change the function used, and update the starting index for all the following methods.
with the current approach you change the Datatype.U16 to Datatype.U08 and that's all you need to do.

Example #2: adding a new variable fpga_micro after fpga_minor, with U08 type:

with the conversion approach, you add the bytearray_to_byte, update the indexes for all the following reads.
with the current approach you insert an element after the fpga_minor with a value ('fpga_micro', Datatype.U08), and nothing more needed

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "RESOLVED for now."

Behrouz NematiPour — Wed, 01 Jul 2026 12:33:22 -0700

Behrouz NematiPour replied to Behrouz NematiPour in LEAHI-DIALIN-LDT-4484-1

RESOLVED for now.

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "I would not do that because the function names ..."

Behrouz NematiPour — Wed, 01 Jul 2026 12:32:17 -0700

Behrouz NematiPour replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4484-1

I would not do that because the function names and messages for each project should be different to avoid confusion.
I think that is fine for now.

RESOLVED.

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "So the same channels are used for both the Leah..."

Behrouz NematiPour — Wed, 01 Jul 2026 12:07:36 -0700

Behrouz NematiPour replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4484-1

So the same channels are used for both the Leahi and Denali?
I am not talking about how collisions are handled; that is handled by the CAN driver, not the FW or SW.
My point is that the CAN Channels by themselves do not have the meaning we want; they are only a priority.
As we defined them, we gave them a meaning as a category; therefore, it is better to name them the Denali/Leahi Channels rather than the CAN Channels.

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "RESOLVED."

Behrouz NematiPour — Wed, 01 Jul 2026 12:06:39 -0700

Behrouz NematiPour replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4484-1

RESOLVED.

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "{code} def fp_versions(self, major: int, minor..."

Behrouz NematiPour — Wed, 01 Jul 2026 12:05:06 -0700

Behrouz NematiPour replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4484-1

def fp_versions(self, major: int, minor: int, micro: int, build: int,
                     fpga_id: int, fpga_major: int, fpga_minor: int, fpga_lab: int,
                     compatibility_rev: int):
     """
     Broadcasts the current dd Version Data (Msg ID: 0x0F, 15)
     Args:
         @param major: (uint) - Major version number
         @param minor: (uint) - Minor version number
         @param micro: (uint) - Micro version number
         @param build: (uint) - Build version number
         @param fpga_id: (int) - FPGA id version number
         @param fpga_major: (int) - FPGA Major version number
         @param fpga_minor: (int) - FPGA Minor version number
         @param fpga_lab: (int) - FPGA Lab version number
         @param compatibility_rev: (uint) - The FWs/UI compatibility revision
     @return: None
     """
     if not self.can_enabled:
         raise ValueError("CAN Interface is not enabled")

     payload =  conversions.unsigned_byte_to_bytearray   (major            )
     payload += conversions.unsigned_byte_to_bytearray   (minor            )
     payload += conversions.unsigned_byte_to_bytearray   (micro            )
     payload += conversions.unsigned_short_to_bytearray  (build            )
     payload += conversions.unsigned_byte_to_bytearray   (fpga_id          )
     payload += conversions.unsigned_byte_to_bytearray   (fpga_major       )
     payload += conversions.unsigned_byte_to_bytearray   (fpga_minor       )
     payload += conversions.unsigned_byte_to_bytearray   (fpga_lab         )
     payload += conversions.unsigned_integer_to_bytearray(compatibility_rev)

     message = CAN.CanMessage.build_message(
                                         channel_id=CAN.CanChannels.fp_sync_broadcast_ch_id,
                                         message_id=msg_ids.MsgIds.MSG_ID_FP_VERSION_RESPONSE.value,
                                         payload=payload)

     self.can_interface.send(message, 0)

leahi-dialin (LDT-5409-dd-balancing-chamber-stops-duri): Merge branch 'staging' into LDT-3735-non-volatile-memory

Zoltan Miskolci — Mon, 29 Jun 2026 12:30:31 -0700

Zoltan Miskolci committed 5994ade on branch LDT-3735-non-volatile-memory, LDT-4611-hdf-fw-implementation-5-4 and 14 more in leahi-dialin

Merge branch 'staging' into LDT-3735-non-volatile-memory

· /leahi_dialin/common/dd_defs.py	(-2, +27)	\| History	\| Source	\| Diff
· /leahi_dialin/common/dd_defs_proxy.py	(-0, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/common/msg_ids.py	(-8, +35)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/dialysate_delivery.py	(-30, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/td/treatment_delivery.py	(-10, +14)	\| History	\| Source	\| Diff