· /firmware/App/Controllers/Valves.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/ModeInitPOST.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/DDInterface.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/DDInterface.h	(-2, +2)	| History	| Source	| Diff

]]> Tue, 18 Aug 2026 16:41:38 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4049-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4049-1 Vinayakam Mani , Sean Nash and Michael Garthwaite finished reviewing LEAHI-TD-FIRMWARE-LDT-4049-1 LEAHI-TD-FIRMWARE-LDT-4049_Standby - FW Implementation - 2/2: ]]> Tue, 18 Aug 2026 15:48:38 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4049-1/#c31475 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4049-1/#c31475 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4049-1

This isn't right. Look at staging for correct code.

Shouldn't this be in ModePostTreatment?

void cmdStartDDDisinfection( DD_COMMAND_T disCmdType )

Update this to work for all standby states w/ switch statement on given "new" state.

Why zeroes? Why not send TD version constants?

Add parameter (disinfection cmd enum from DDDefs.h). Then only need one signal function for all disinfection types.

change enum name too. need 1 alarm for each disinfection type.

Just do one dd disinfect request msg with a command ID payload (from enum in DDDefs.h).

Missing some disinfects.

Move up after HCOL

Swap order of == for these 2 if statements - put constant on left side.

Why?

Why is UF volume being added here? If we add it, we need to change DD f/w too. But it is not clear to me why DD f/w needs to know the UF volume.

Use ternary operator to explicitly set to TRUE or FALSE.

· /firmware/App/Drivers/RotaryValve.h	(-2, +0)	| History	| Source	| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-5, +7)	| History	| Source	| Diff
· /firmware/App/Modes/ModeInitPOST.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-11, +13)	| History	| Source	| Diff
· /firmware/App/Services/DDInterface.c	(-1, +3)	| History	| Source	| Diff
· /firmware/App/Services/DDInterface.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.h	(-8, +0)	| History	| Source	| Diff

]]> Wed, 22 Jul 2026 09:31:13 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4049-1/#c30609 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4049-1/#c30609 Sean Nash replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-4049-1

Our TODO comments are all CAPs.

I think these if statements should be looking for valve state == VALVE_STATE_IDLE, not <

Fix implementation to return a BOOL (TRUE if SW_COMPATIBILITY_REV == ddVersion.compatibilityRev.

Should return T/F. Change comment to "TRUE if DD f/w is compatible with TD f/w, FALSE if not.".

Should return a BOOL (that is what ModeStandby is expecting).

Fix isDDCompatible() function so that it returns a T/F instead of a compatibility revision.

Align comment.

Why are these added? And why commented out. H13 and H20 are not rotary valves - they are 3 way valves. They do not belong here.

Do we need this?

Change this to work for any state (passed as parameter).

Remove