Why are we commenting this out?

Magic number. Make a #define.
Should this command be sent here or in transition function of pre-tx mode?

Why are we ending air trap control here?

Why is this commented out?

Add one more blank line before test support banner.

Remove these blank lines.

· /firmware/App/Modes/ModePreTreat.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreTreat.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/StatePreTxRecirculate.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/DDInterface.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/DDInterface.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/TxParams.c	(-1, +1)	| History	| Source	| Diff

]]> Wed, 19 Aug 2026 10:13:28 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5363-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5363-1 Vendor - TEL - Arpita Srivastava and Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-5363-1 LEAHI-TD-FIRMWARE-LDT-5363_Pre-Treatment - FW Implementation - 11/6: ]]> Tue, 18 Aug 2026 14:30:47 -0700 Vendor - TEL - Vijay Pamula https://devapps.diality.us/changelog/td-firmware?cs=7ea81cd2bb8bf02de578ce14fbb2acc2ed12833f https://devapps.diality.us/changelog/td-firmware?cs=7ea81cd2bb8bf02de578ce14fbb2acc2ed12833f Vendor - TEL - Vijay Pamula committed 7ea81cd on branch LDT-2240-disposable-tube-set-self-test, LDT-4056-service-fw-implementation-2 and 6 more in td-firmware LDT-5363:Addressed review comments

· /firmware/App/Modes/StatePreTxRecirculate.c

(-2, +2)

| History

| Source

| Diff

]]> Tue, 18 Aug 2026 11:35:45 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5363-1/#c31468 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5363-1/#c31468 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-5363-1

Add initialBloodFlowComplete to outputs

Add initialBloodFlowComplete and preTxRecircStartTime to inputs.

· /firmware/App/Modes/StatePreTxRecirculate.c

(-11, +42)

| History

| Source

| Diff

]]> Mon, 17 Aug 2026 13:13:30 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5363-1/#c31466 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5363-1/#c31466 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-5363-1

Should be only one return at end of function.

I think != TRUE is better in these cases.

Should be "brief". No "s".

· /firmware/App/Modes/ModePreTreat.c	(-14, +133)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreTreat.h	(-0, +1)	| History	| Source	| Diff
· /firmware/App/Modes/StatePreTxRecirculate.c	(-1, +0)	| History	| Source	| Diff
· /firmware/App/Services/DDInterface.c	(-0, +30)	| History	| Source	| Diff
· /firmware/App/Services/DDInterface.h	(-0, +1)	| History	| Source	| Diff
· /firmware/App/Services/TxParams.c	(-0, +13)	| History	| Source	| Diff

]]> Fri, 14 Aug 2026 13:03:12 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5363-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5363-1 Dara Navaei started review LEAHI-TD-FIRMWARE-LDT-5363-1 ]]> Thu, 16 Jul 2026 15:02:40 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3992-7 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3992-7 Dara Navaei started review LEAHI-TD-FIRMWARE-LDT-3992-7 ]]> Mon, 22 Jun 2026 09:16:34 -0700 Vendor - TEL - Vijay Pamula https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4027-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4027-1 Vendor - TEL - Vijay Pamula Closed LEAHI-TD-FIRMWARE-LDT-4027-1 ]]> Wed, 17 Jun 2026 12:03:26 -0700 Dara Navaei https://devapps.diality.us/changelog/td-firmware?cs=2f282113c1540be57b9d00833224d7ce93d460cd https://devapps.diality.us/changelog/td-firmware?cs=2f282113c1540be57b9d00833224d7ce93d460cd Dara Navaei committed 2f28211 on branch LDT-2118-main-treatment-screen---td---vectorcast-tests-7-31-2026, LDT-2240-disposable-tube-set-self-test and 38 more in td-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModePreTreat.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreTreat.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/StatePreTxRecirculate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/StatePreTxRecirculate.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	| History	| Source	| Diff

]]> Fri, 12 Jun 2026 23:07:22 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4027-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4027-1 Sean Nash and Vendor - TEL - Arpita Srivastava finished reviewing LEAHI-TD-FIRMWARE-LDT-4027-1 LEAHI-TD-FIRMWARE-LDT-4027_Pre-Treatment - FW Implementation - 2/6: ]]> Fri, 12 Jun 2026 14:03:04 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4027-1/#c29873 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4027-1/#c29873 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-4027-1

align the comment part

This is right, but we don't have a patient connection state implemented yet so we will get stuck here if we do this now.
For now, comment out this line with a TODO to restore when patient connection state is implemented and add a temporary line of code to request treatment mode here.

· /firmware/App/Modes/ModePreTreat.c	(-12, +29)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreTreat.h	(-0, +1)	| History	| Source	| Diff
· /firmware/App/Modes/StatePreTxRecirculate.c	(-3, +3)	| History	| Source	| Diff

]]> Thu, 11 Jun 2026 15:10:06 -0700 Vendor - TEL - Vijay Pamula https://devapps.diality.us/changelog/td-firmware?cs=2df4b8aede603cf05cd54a319d85b4fb60611487 https://devapps.diality.us/changelog/td-firmware?cs=2df4b8aede603cf05cd54a319d85b4fb60611487 Vendor - TEL - Vijay Pamula committed 2df4b8a on branch LDT-2118-main-treatment-screen---td---vectorcast-tests-7-31-2026, LDT-2240-disposable-tube-set-self-test and 39 more in td-firmware LDT-4027: Addressed Code review comments for Pre-Treatment Recirculate State

· /firmware/App/Modes/StatePreTxRecirculate.c

(-9, +6)

| History

| Source

| Diff

]]> Tue, 09 Jun 2026 14:38:20 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4027-1/#c29694 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4027-1/#c29694 Sean Nash replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-4027-1

You only addressed the first part of my comment above.

This medium alarm is ID 196 (from enum above). So I would expect it to be at the bottom of this table. Why are you placing it here?

Remove from input: preTxRecircStartTime, recircMediumAlarmGiven and recircResumeRequested
Remove from output: recircMediumAlarmGiven and recircResumeRequested

Output should be none.