Fisheye on leahi-application/sources/model/hd/adjustment

LEAHI-APPLICATION-LDT-5572-1: started by Dara Navaei

Dara Navaei — Wed, 19 Aug 2026 14:05:55 -0700

Dara Navaei started review LEAHI-APPLICATION-LDT-5572-1

LEAHI-APPLICATION-LDT-5158-1: comment by Nicholas Ramirez "updated"

Nicholas Ramirez — Wed, 19 Aug 2026 13:51:31 -0700

Nicholas Ramirez replied to Behrouz NematiPour in LEAHI-APPLICATION-LDT-5158-1

updated

LEAHI-APPLICATION-LDT-5158-1: comment by Behrouz NematiPour "APPROVED."

Behrouz NematiPour — Wed, 19 Aug 2026 12:49:41 -0700

Behrouz NematiPour replied to Nicholas Ramirez in LEAHI-APPLICATION-LDT-5158-1

APPROVED.

LEAHI-APPLICATION-LDT-5158-1: comment by Behrouz NematiPour "RESOLVED. Added another comment regarding the ..."

Behrouz NematiPour — Wed, 19 Aug 2026 12:49:11 -0700

Behrouz NematiPour replied to Nicholas Ramirez in LEAHI-APPLICATION-LDT-5158-1

RESOLVED.
Added another comment regarding the same.

LEAHI-APPLICATION-LDT-5158-1: comment by Behrouz NematiPour "[~nramirez] Thanks for the change to the ok an..."

Behrouz NematiPour — Wed, 19 Aug 2026 12:42:07 -0700

Behrouz NematiPour commented on LEAHI-APPLICATION-LDT-5158-1

Nicholas Ramirez
Thanks for the change to the ok and result.

To be consistent, could you please use ok instead of result, since all the other parts of the code use ok as an argument, and the function itself has ok as the parameter name.
Also move the:
```
; if ( ! ok ) { goto invalid; }
```
on the "same line" and "aligned" as the evaluating parameter, to keep the code clean.

LEAHI-APPLICATION-LDT-5158-1: comment by Behrouz NematiPour "APPROVED"

Behrouz NematiPour — Wed, 19 Aug 2026 12:40:37 -0700

Behrouz NematiPour replied to Nicholas Ramirez in LEAHI-APPLICATION-LDT-5158-1

APPROVED

LEAHI-APPLICATION-LDT-5158-1: comment by Nicholas Ramirez "updated"

Nicholas Ramirez — Tue, 18 Aug 2026 16:24:52 -0700

Nicholas Ramirez replied to Nicholas Ramirez in LEAHI-APPLICATION-LDT-5158-1

updated

LEAHI-APPLICATION-LDT-5158-1: comment by Nicholas Ramirez "updated"

Nicholas Ramirez — Tue, 18 Aug 2026 16:24:45 -0700

Nicholas Ramirez replied to Nicholas Ramirez in LEAHI-APPLICATION-LDT-5158-1

updated

LEAHI-APPLICATION-LDT-5158-1: comment by Nicholas Ramirez "updated"

Nicholas Ramirez — Tue, 18 Aug 2026 16:24:38 -0700

Nicholas Ramirez replied to Nicholas Ramirez in LEAHI-APPLICATION-LDT-5158-1

updated

LEAHI-APPLICATION-LDT-5414-1: closed by Nicholas Ramirez

Nicholas Ramirez — Tue, 18 Aug 2026 15:50:28 -0700

Nicholas Ramirez Closed LEAHI-APPLICATION-LDT-5414-1

LEAHI-APPLICATION-LDT-5158-1: comment by Nicholas Ramirez "remove the ok and just check result and if any ..."

Nicholas Ramirez — Tue, 18 Aug 2026 15:35:44 -0700

Nicholas Ramirez commented on LEAHI-APPLICATION-LDT-5158-1

remove the ok and just check result and if any fails goto invalid

LEAHI-APPLICATION-LDT-5158-1: comment by Nicholas Ramirez "see if you can use payloadLen from MessageGlob..."

Nicholas Ramirez — Tue, 18 Aug 2026 15:34:40 -0700

Nicholas Ramirez commented on LEAHI-APPLICATION-LDT-5158-1

see if you can use payloadLen from MessageGlobals.h

LEAHI-APPLICATION-LDT-5158-1: comment by Nicholas Ramirez "double check"

Nicholas Ramirez — Tue, 18 Aug 2026 15:17:13 -0700

Nicholas Ramirez commented on LEAHI-APPLICATION-LDT-5158-1

double check

LEAHI-APPLICATION-LDT-5074-3: closed by Nicholas Ramirez

Nicholas Ramirez — Tue, 18 Aug 2026 15:04:03 -0700

Nicholas Ramirez Closed LEAHI-APPLICATION-LDT-5074-3

LEAHI-APPLICATION-LDT-5158-1: reviewers left LEAHI-APPLICATION-LDT-5158_SW Misc & Enhc - SW - ...

Mon, 17 Aug 2026 17:03:25 -0700

Sean Nash left LEAHI-APPLICATION-LDT-5158-1

LEAHI-APPLICATION-LDT-5158_SW Misc & Enhc - SW - 01 - SW Integration - Calibration - R&I

LEAHI-APPLICATION-LDT-5158-1: comment by Nicholas Ramirez "removedin https://devapps.diality.us/cru/LEAHI-..."

Nicholas Ramirez — Fri, 14 Aug 2026 10:22:18 -0700

Nicholas Ramirez replied to Nicholas Ramirez in LEAHI-APPLICATION-LDT-5158-1

removedin https://devapps.diality.us/cru/#LEAHI-APPLICATION-LDT-5331-1CFR-87504

LEAHI-APPLICATION-LDT-5414-1: reviewers left LEAHI-APPLICATION-LDT-5414_Disposable Tube Set Aut...

Thu, 13 Aug 2026 14:47:31 -0700

Sean Nash left LEAHI-APPLICATION-LDT-5414-1

LEAHI-APPLICATION-LDT-5414_Disposable Tube Set Auto Priming Process - SW - 01- Pre-Tx - Prime - R&I

LEAHI-APPLICATION-LDT-5414-1: reviewers finished

Wed, 12 Aug 2026 16:57:52 -0700

Behrouz NematiPour finished reviewing LEAHI-APPLICATION-LDT-5414-1

LEAHI-APPLICATION-LDT-5414_Disposable Tube Set Auto Priming Process - SW - 01- Pre-Tx - Prime - R&I

LEAHI-APPLICATION-LDT-5074-3: reviewers finished

Wed, 12 Aug 2026 16:57:18 -0700

Behrouz NematiPour finished reviewing LEAHI-APPLICATION-LDT-5074-3

LEAHI-APPLICATION-LDT-5074_SW Misc & Enhc - SW - 01 - Miscellaneous - Feature Complete - R&I

LEAHI-APPLICATION-LDT-5414-1: reviewers finished

Tue, 11 Aug 2026 17:01:37 -0700

Stephen Quong finished reviewing LEAHI-APPLICATION-LDT-5414-1

LEAHI-APPLICATION-LDT-5414_Disposable Tube Set Auto Priming Process - SW - 01- Pre-Tx - Prime - R&I

LEAHI-APPLICATION-LDT-5158-1: comment by Nicholas Ramirez "remove from prime // priming - TODO check if ne..."

Nicholas Ramirez — Tue, 11 Aug 2026 16:53:30 -0700

Nicholas Ramirez commented on LEAHI-APPLICATION-LDT-5158-1

remove from prime // priming - TODO check if needed. may not need

LEAHI-APPLICATION-LDT-5074-3: reviewers finished

Tue, 11 Aug 2026 16:20:26 -0700

Stephen Quong finished reviewing LEAHI-APPLICATION-LDT-5074-3

LEAHI-APPLICATION-LDT-5074_SW Misc & Enhc - SW - 01 - Miscellaneous - Feature Complete - R&I

LEAHI-APPLICATION-LDT-5074-3: comment by Nicholas Ramirez "BN approves"

Nicholas Ramirez — Tue, 11 Aug 2026 15:54:14 -0700

Nicholas Ramirez replied to Nicholas Ramirez in LEAHI-APPLICATION-LDT-5074-3

BN approves

LEAHI-APPLICATION-LDT-5074-3: comment by Nicholas Ramirez "BN approves"

Nicholas Ramirez — Tue, 11 Aug 2026 15:53:58 -0700

Nicholas Ramirez replied to Nicholas Ramirez in LEAHI-APPLICATION-LDT-5074-3

BN approves

LEAHI-APPLICATION-LDT-5074-3: comment by Nicholas Ramirez "BN approves"

Nicholas Ramirez — Tue, 11 Aug 2026 15:52:38 -0700

Nicholas Ramirez replied to Nicholas Ramirez in LEAHI-APPLICATION-LDT-5074-3

BN approves

LEAHI-APPLICATION-LDT-5074-3: comment by Nicholas Ramirez "BN approves"

Nicholas Ramirez — Tue, 11 Aug 2026 15:51:00 -0700

Nicholas Ramirez replied to Nicholas Ramirez in LEAHI-APPLICATION-LDT-5074-3

BN approves

leahi-application (feature/LDT-5572-calibration-Hydraulics): LDT-5417 Disposable Tube Set Auto Priming Process - SW - 01- Pre-Tx - Prime - R&I - 03: DEV - Feature Implementation & C...

Nicholas Ramirez — Fri, 07 Aug 2026 10:31:23 -0700

Nicholas Ramirez committed d62949c on branch LDT-5485-sw-misc-enhc---sw---01--asn---iso-uf, LDT-5618-sw-misc-enhc-sw-board-freeze and 9 more in leahi-application

LDT-5417 Disposable Tube Set Auto Priming Process - SW - 01- Pre-Tx - Prime - R&I - 03: DEV - Feature Implementation & Code Document [& Diagnostics]

added prime code

· /leahi.pro

(-6, +13)

| History

| Source

| Diff

· /sources/canbus/MessageGlobals.h

(-2, +2)

| History

| Source

| Diff

· /sources/gui/GuiGlobals.h

(-1, +1)

| History

| Source

| Diff

· /sources/gui/qml/components/HeaderBar.qml

(-0, +1)

| History

| Source

| Diff

· /sources/gui/qml/dialogs/diagnostics/DiagnosticsTD.qml

(-5, +0)

| History

| Source

| Diff

· /sources/gui/qml/pages/pretreatment/PreTreatmentPrime.qml

(-61, +41)

| History

| Source

| Diff

· /sources/gui/qml/pages/pretreatment/create/PreTreatmentCreateContent.qml

(-0, +2)

| History

| Source

| Diff

· /sources/model/hd/adjustment/treatment/MTreatmentAdjustRequests.h

(-1, +1)

| History

| Source

| Diff

· /sources/model/hd/data/pretreatment/MPreTreatmentDisposablesPrimeData.cpp

(-49, +0)

| History

| Source

| Diff

· /sources/model/hd/data/pretreatment/MPreTreatmentDisposablesPrimeData.h

(-79, +0)

| History

| Source

| Diff

· /sources/model/td/adjustment/posttreatment/MPostTreatmentAdjustPatientDisconnectionConfirmResponse.h

(-1, +1)

| History

| Source

| Diff

· /sources/model/td/adjustment/posttreatment/MPostTreatmentAdjustRequests.h

(-1, +1)

| History

| Source

| Diff

· /sources/model/td/data/MTDValvesData.cpp

(-6, +0)

| History

| Source

| Diff

· /sources/model/td/data/MTDValvesData.h

(-6, +0)

| History

| Source

| Diff

· /sources/model/td/data/pretreatment/MPreTreatmentDisposablesPrimeData.cpp

(-0, +55)

| History

| Source

… 7 more files in changeset.

LEAHI-APPLICATION-LDT-5414-1: started by Dara Navaei

Dara Navaei — Fri, 07 Aug 2026 10:02:00 -0700

Dara Navaei started review LEAHI-APPLICATION-LDT-5414-1

LEAHI-APPLICATION-LDT-5074-3: comment by Nicholas Ramirez "updated"

Nicholas Ramirez — Fri, 07 Aug 2026 09:53:40 -0700

Nicholas Ramirez replied to Nicholas Ramirez in LEAHI-APPLICATION-LDT-5074-3

updated

LEAHI-APPLICATION-LDT-5074-3: comment by Nicholas Ramirez "combined files"

Nicholas Ramirez — Fri, 07 Aug 2026 09:53:33 -0700

Nicholas Ramirez replied to Nicholas Ramirez in LEAHI-APPLICATION-LDT-5074-3

combined files