LEAHI-APPLICATION-LDT-5074-3 LEAHI-APPLICATION-LDT-5074_SW Misc & Enhc - SW - 01 - Miscellaneous - Feature Complete - R&I

closed on 18 Aug

Author

Moderator

Reviewers

LEAHI-APPLICATION-LDT-5074_SW Misc & Enhc - SW - 01 - Miscellaneous - Feature...

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 56

leahi-application 0
- Folder SDDs 0
  - File StopState.png 0 Remove
  - File StopState.puml 9 Remove
- Folder sources 0
  - Folder canbus 0
    - File MessageDispatcher.cpp 0 Remove
    - File MessageGlobals.h 0 Remove
    - File MessageInterpreter.cpp 0 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder components 0
        
        File HeaderBar.qml 0 Remove
        
        File IdleTimer.qml 0 Remove
      - Folder dialogs 0
        
        Folder headerbar 0
        
        File HeaderbarSettings.qml 0 Remove
        
        Folder watersample 0
        
        File WaterSampleDialog.qml 0 Remove
      - Folder pages/settings 0
        
        File SettingsInformation.qml 0 Remove
        
        File SettingsROInput.qml 0 Remove
        
        File SettingsStack.qml 0 Remove
        
        File SettingsVolumeBrightness.qml 0 Remove
      - File main.qml 0 Remove
    - File GuiGlobals.cpp 0 Remove
    - File GuiGlobals.h 0 Remove
  - Folder model 0
    - Folder dd/adjustment/settings 0
      - File MAdjustRoWaterModeResponse.cpp 0 Remove
      - File MAdjustRoWaterModeResponse.h 0 Remove
      - File MRoWaterModeResponse.cpp 0 Remove
      - File MRoWaterModeResponse.h 3 Remove
    - Folder dg/adjustment/settings 0
      - File MAdjustDGRequests.h 0 Remove
      - File MDuetRoWaterDG.cpp 0 Remove
      - File MDuetRoWaterDG.h 0 Remove
    - Folder hd 0
      - Folder adjustment/settings 0
        
        File MAdjustHDAlarmVolumeResponse.cpp 0 Remove
        
        File MAdjustHDAlarmVolumeResponse.h 0 Remove
        
        File MAdjustHDRequests.h 3 Remove
      - Folder alarm 0
        
        File MAlarmMapping.cpp 0 Remove
      - Folder data/treatment 0
        
        File MTreatmentHeparinData.h 0 Remove
    - Folder td/adjustment/settings 0
      - File MAdjustTDAlarmVolumeResponse.cpp 0 Remove
      - File MAdjustTDAlarmVolumeResponse.h 0 Remove
    - File MModel.h 0 Remove
  - Folder view 0
    - Folder hd/data/pretreatment 0
      - File VPreTreatmentStatesData.cpp 0 Remove
      - File VPreTreatmentStatesData.h 0 Remove
    - Folder settings 0
      - File VAdjustRoWaterMode.cpp 0 Remove
      - File VAdjustRoWaterMode.h 0 Remove
      - File VAdjustmentAlarmVolume.cpp 0 Remove
      - File VAdjustmentAlarmVolume.h 0 Remove
      - File VDuetRoWaterDG.cpp 0 Remove
      - File VDuetRoWaterDG.h 0 Remove
      - File VRoWaterMode.cpp 6 Remove
      - File VRoWaterMode.h 0 Remove
      - File VSettings.cpp 0 Remove
      - File VSettings.h 0 Remove
    - Folder td/data 0
      - Folder treatment 0
        
        File VTDTreatmentStatesData.cpp 0 Remove
        
        File VTDTreatmentStatesData.h 0 Remove
      - File VTreatmentRanges.cpp 0 Remove
      - File VTreatmentRanges.h 0 Remove
    - File VView.h 0 Remove
    - File VWaterSampleModel.cpp 3 Remove
    - File VWaterSampleModel.h 0 Remove
  - File ApplicationController.cpp 0 Remove
  - File ApplicationController.h 0 Remove
- File leahi.pro 0 Remove
leahi-sw.config 0
- Folder configurations 0
  - Folder Confirm 0
    - File Confirm.conf 0 Remove
  - Folder Parameters 0
    - File DataList.conf 0 Remove
  - Folder Settings 0
    - File System.conf 3 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Nicholas Ramirez	Author & Moderator	1h 43m	27	BN approves
Vendor - TEL - Sivvanarayana Kurapati	Reviewer - 0% reviewed
Tiffany Mejia	Reviewer - 0% reviewed
Stephen Quong	Reviewer - Complete	3m
Behrouz NematiPour	Reviewer - Complete	0m
Dara Navaei	Reviewer - 0% reviewed	0m
Total		1h 46m	27

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/sources/model/.../settings/MDuetRoWaterDG.cpp Deleted

Click to load diff

/sources/model/.../settings/MDuetRoWaterDG.h Deleted

Click to load diff

/sources/.../settings/MAdjustHDAlarmVolumeResponse.cpp Deleted

Click to load diff

/sources/.../settings/MAdjustHDAlarmVolumeResponse.h Deleted

Click to load diff

/sources/.../settings/VAdjustRoWaterMode.cpp Deleted

Click to load diff

/sources/.../settings/VAdjustRoWaterMode.h Deleted

Click to load diff

/sources/view/settings/VDuetRoWaterDG.cpp Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

LEAHI-APPLICATION-LDT-5074-3

LEAHI-APPLICATION-LDT-5074_SW Misc & Enhc - SW - 01 - Miscellaneous - Feature...

LEAHI-APPLICATION-LDT-5074-3 27

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

LEAHI-APPLICATION-LDT-5074_SW Misc & Enhc - SW - 01 - Miscellaneous - Feature...

LEAHI-APPLICATION-LDT-5074-3 27

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time