Fisheye on leahi-fwcommon/ https://devapps.diality.us/changelog/~br%3DLDT-5613-disposable-tube-self-test-fw-implementation/leahi-fwcommon Recent activity in "leahi-fwcommon" under directory / LEAHI-DD-FIRMWARE-LDT-5209-1: comment by Sean Nash "Add TODO to restore later. Why did this need t..." Thu, 20 Aug 2026 13:22:14 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c31572 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c31572 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-5209-1

Add TODO to restore later. Why did this need to be commented out?

]]> LEAHI-DD-FIRMWARE-LDT-5209-1: comment by Sean Nash "Remove blank line." Thu, 20 Aug 2026 13:19:52 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c31570 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c31570 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-5209-1

Remove blank line.

]]> LEAHI-DD-FIRMWARE-LDT-5209-1: comment by Sean Nash "Restore before merging." Thu, 20 Aug 2026 13:17:20 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c31568 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c31568 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-5209-1

Restore before merging.

]]> LEAHI-TD-FIRMWARE-LDT-3992-7: comment by Sean Nash "Why are we commenting this out?" Thu, 20 Aug 2026 11:21:11 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3992-7/#c31537 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3992-7/#c31537 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3992-7

Why are we commenting this out?

]]> LEAHI-TD-FIRMWARE-LDT-3992-7: comment by Sean Nash "Magic number. Make a #define. Should this com..." Thu, 20 Aug 2026 11:18:57 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3992-7/#c31536 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3992-7/#c31536 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3992-7

Magic number. Make a #define.
Should this command be sent here or in transition function of pre-tx mode?

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: closed by Vendor - TEL - Varshini Nagabooshanam Thu, 20 Aug 2026 10:32:46 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1 Vendor - TEL - Varshini Nagabooshanam Closed LEAHI-TD-FIRMWARE-LDT-2240-1 ]]> LEAHI-TD-FIRMWARE-LDT-3992-7: comment by Sean Nash "Why are we ending air trap control here?" Thu, 20 Aug 2026 10:16:47 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3992-7/#c31534 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3992-7/#c31534 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3992-7

Why are we ending air trap control here?

]]> leahi-fwcommon (staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Thu, 20 Aug 2026 10:03:57 -0700 Dara Navaei https://devapps.diality.us/changelog/leahi-fwcommon?cs=bd01ab1f0b60af9bb259f5d7526d4973abbad4ea https://devapps.diality.us/changelog/leahi-fwcommon?cs=bd01ab1f0b60af9bb259f5d7526d4973abbad4ea Dara Navaei committed bd01ab1 on branch LDT-5613-disposable-tube-self-test-fw-implementation, staging in leahi-fwcommon Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /TestSupport.h (-2, +2) | History | Source | Diff
]]> LEAHI-TD-FIRMWARE-LDT-3992-7: comment by Sean Nash "Why is this commented out?" Thu, 20 Aug 2026 09:59:52 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3992-7/#c31533 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3992-7/#c31533 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3992-7

Why is this commented out?

]]> LEAHI-TD-FIRMWARE-LDT-3992-7: comment by Sean Nash "Add one more blank line before test support ban..." Thu, 20 Aug 2026 09:46:52 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3992-7/#c31532 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3992-7/#c31532 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3992-7

Add one more blank line before test support banner.

]]> LEAHI-TD-FIRMWARE-LDT-3992-7: comment by Sean Nash "Remove these blank lines." Thu, 20 Aug 2026 09:41:31 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3992-7/#c31530 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3992-7/#c31530 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3992-7

Remove these blank lines.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: reviewers finished Wed, 19 Aug 2026 16:38:44 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1 Michael Garthwaite and Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-2240-1 LEAHI-TD-FIRMWARE-LDT-2240_Disposable Tube Set Self-Test - TD ]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "Doesn't look fixed. 717 and 732 are swapped (a..." Wed, 19 Aug 2026 14:32:50 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31526 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31526 Sean Nash replied to Vendor - TEL - Varshini Nagabooshanam in LEAHI-TD-FIRMWARE-LDT-2240-1

Doesn't look fixed. 717 and 732 are swapped (and so out of order). This array should be in order by rank.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vendor - TEL - Varshini Nagabooshanam "Fixed" Wed, 19 Aug 2026 14:20:51 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31525 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31525 Vendor - TEL - Varshini Nagabooshanam replied to Michael Garthwaite in LEAHI-TD-FIRMWARE-LDT-2240-1

Fixed

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vendor - TEL - Varshini Nagabooshanam "Fixed" Wed, 19 Aug 2026 14:19:56 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31524 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31524 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-2240-1

Fixed

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vendor - TEL - Varshini Nagabooshanam "Fixed" Wed, 19 Aug 2026 14:18:53 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31523 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31523 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-2240-1

Fixed

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vendor - TEL - Varshini Nagabooshanam "Yes, Fixed" Wed, 19 Aug 2026 14:18:18 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31522 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31522 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-2240-1

Yes, Fixed

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vendor - TEL - Varshini Nagabooshanam "Agree Fixed" Wed, 19 Aug 2026 14:18:01 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31521 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31521 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-2240-1

Agree Fixed

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vendor - TEL - Varshini Nagabooshanam "No fixed" Wed, 19 Aug 2026 14:13:15 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31520 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31520 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-2240-1

No fixed

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vendor - TEL - Varshini Nagabooshanam "Fixed" Wed, 19 Aug 2026 14:12:07 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31519 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31519 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-2240-1

Fixed

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vendor - TEL - Varshini Nagabooshanam "Fixed" Wed, 19 Aug 2026 14:11:59 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31518 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31518 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-2240-1

Fixed

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vendor - TEL - Varshini Nagabooshanam "This was merge issue earlier at that time I com..." Wed, 19 Aug 2026 14:11:51 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31517 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31517 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-2240-1

This was merge issue earlier at that time I commented out and I forget to uncomment
Fixed

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vendor - TEL - Varshini Nagabooshanam "Fixed" Wed, 19 Aug 2026 14:10:56 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31516 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31516 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-2240-1

Fixed

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vendor - TEL - Varshini Nagabooshanam "Fixed" Wed, 19 Aug 2026 14:06:01 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31515 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31515 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-2240-1

Fixed

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vendor - TEL - Varshini Nagabooshanam "Prime is not in staging, thats why I added to c..." Wed, 19 Aug 2026 14:03:45 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31514 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31514 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-2240-1

Prime is not in staging, thats why I added to confirm RX, I will fix that to prime state

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "Don't we need to go to prime state after dry se..." Wed, 19 Aug 2026 13:57:28 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31513 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31513 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

Don't we need to go to prime state after dry self-tests are done?

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "TaskGeneral is included twice. Remove this one..." Wed, 19 Aug 2026 13:50:34 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31511 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31511 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

TaskGeneral is included twice. Remove this one.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "Remove {} in case if not necessary (i.e. no loc..." Wed, 19 Aug 2026 13:38:42 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31509 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31509 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

Remove {} in case if not necessary (i.e. no local variables).

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "Remove blank line." Wed, 19 Aug 2026 13:37:26 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31508 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31508 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

Remove blank line.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "Keep a blank line between library includes and ..." Wed, 19 Aug 2026 13:30:48 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31505 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c31505 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

Keep a blank line between library includes and normal includes.

]]>