Fisheye on dd-firmware/firmware/App/Controllers/PistonPumpControl.h https://devapps.diality.us/changelog/~br%3DLDT-815-stop-state---dd_1/dd-firmware/firmware/App/Controllers/PistonPumpControl.h Recent activity in "dd-firmware" under directory /firmware/App/Controllers/PistonPumpControl.h LEAHI-DD-FIRMWARE-LDT-2004-13: started by Dara Navaei Wed, 25 Mar 2026 04:01:46 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-13 ]]> LEAHI-DD-FIRMWARE-LDT-2004-11: started by Dara Navaei Thu, 19 Mar 2026 15:47:06 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-11 ]]> DD-LDT-1735-1: closed by ven.smathamala Wed, 03 Sep 2025 15:07:08 -0700 ven.smathamala https://devapps.diality.us/cru/DD-LDT-1735-1 https://devapps.diality.us/cru/DD-LDT-1735-1 ven.smathamala  (deleted user) Closed DD-LDT-1735-1 ]]> DD-LDT-1735-1: reviewers finished Wed, 03 Sep 2025 14:56:08 -0700 https://devapps.diality.us/cru/DD-LDT-1735-1 https://devapps.diality.us/cru/DD-LDT-1735-1 Sean Nash and Vinayakam Mani finished reviewing DD-LDT-1735-1 DD-LDT-1735_Test Config Support For DD ]]> DD-LDT-1735-1: comment by Sean Nash "Fixed." Fri, 29 Aug 2025 11:05:38 -0700 Sean Nash https://devapps.diality.us/cru/DD-LDT-1735-1/#c23975 https://devapps.diality.us/cru/DD-LDT-1735-1/#c23975 Sean Nash replied to Vinayakam Mani in DD-LDT-1735-1

Fixed.

]]> DD-LDT-1735-1: comment by ven.smathamala "Fixed ." Fri, 29 Aug 2025 10:51:48 -0700 ven.smathamala https://devapps.diality.us/cru/DD-LDT-1735-1/#c23973 https://devapps.diality.us/cru/DD-LDT-1735-1/#c23973 ven.smathamala  (deleted user) replied to Vinayakam Mani in DD-LDT-1735-1

Fixed .

]]> DD-LDT-1735-1: comment by Vinayakam Mani "I guess, you should still need 'TestingActivate..." Fri, 29 Aug 2025 10:36:37 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1735-1/#c23971 https://devapps.diality.us/cru/DD-LDT-1735-1/#c23971 Vinayakam Mani commented on DD-LDT-1735-1

I guess, you should still need 'TestingActivated' check, due to a reason when system team wants to change the states as part of their testing.

]]> DD-LDT-1735-1: comment by Vinayakam Mani "timePerStep is not initialized with the values ..." Fri, 29 Aug 2025 10:34:47 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1735-1/#c23970 https://devapps.diality.us/cru/DD-LDT-1735-1/#c23970 Vinayakam Mani commented on DD-LDT-1735-1

timePerStep is not initialized with the values and being used here.

]]> DD-LDT-1735-1: comment by ven.smathamala "Swapped." Mon, 25 Aug 2025 11:53:17 -0700 ven.smathamala https://devapps.diality.us/cru/DD-LDT-1735-1/#c23860 https://devapps.diality.us/cru/DD-LDT-1735-1/#c23860 ven.smathamala  (deleted user) replied to Sean Nash in DD-LDT-1735-1

Swapped.

]]> DD-LDT-1735-1: comment by ven.smathamala "Fixed." Mon, 25 Aug 2025 11:51:49 -0700 ven.smathamala https://devapps.diality.us/cru/DD-LDT-1735-1/#c23859 https://devapps.diality.us/cru/DD-LDT-1735-1/#c23859 ven.smathamala  (deleted user) replied to Vinayakam Mani in DD-LDT-1735-1

Fixed.

]]> DD-LDT-1735-1: comment by ven.smathamala "Fixed." Mon, 25 Aug 2025 11:49:36 -0700 ven.smathamala https://devapps.diality.us/cru/DD-LDT-1735-1/#c23858 https://devapps.diality.us/cru/DD-LDT-1735-1/#c23858 ven.smathamala  (deleted user) replied to Vinayakam Mani in DD-LDT-1735-1

Fixed.

]]> DD-LDT-1735-1: comment by Vinayakam Mani "It should be equal to true? ( getTestConfigS..." Fri, 22 Aug 2025 16:04:00 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1735-1/#c23857 https://devapps.diality.us/cru/DD-LDT-1735-1/#c23857 Vinayakam Mani commented on DD-LDT-1735-1

It should be equal to true?

( getTestConfigStatus( TEST_CONFIG_DISABLE_BC_PRESSURE_ALARMS ) == TRUE )

]]> DD-LDT-1735-1: comment by Vinayakam Mani "Add open and close parenthesis." Fri, 22 Aug 2025 15:41:08 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1735-1/#c23856 https://devapps.diality.us/cru/DD-LDT-1735-1/#c23856 Vinayakam Mani commented on DD-LDT-1735-1

Add open and close parenthesis.

]]> DD-LDT-1735-1: comment by Sean Nash "Beta and Alpha are swapped here. Beta should b..." Fri, 22 Aug 2025 13:30:07 -0700 Sean Nash https://devapps.diality.us/cru/DD-LDT-1735-1/#c23850 https://devapps.diality.us/cru/DD-LDT-1735-1/#c23850 Sean Nash commented on DD-LDT-1735-1

Beta and Alpha are swapped here. Beta should be -14.... and Alpha should be 0.0.

]]> DD-LDT-1735-1: started by Dara Navaei Wed, 20 Aug 2025 10:02:30 -0700 Dara Navaei https://devapps.diality.us/cru/DD-LDT-1735-1 https://devapps.diality.us/cru/DD-LDT-1735-1 Dara Navaei started review DD-LDT-1735-1 ]]> DD-LDT-1473-1: closed by Vinayakam Mani Tue, 05 Aug 2025 13:42:10 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1473-1 https://devapps.diality.us/cru/DD-LDT-1473-1 Vinayakam Mani Closed DD-LDT-1473-1 ]]> DD-LDT-1473-1: reviewers finished Tue, 05 Aug 2025 12:46:14 -0700 https://devapps.diality.us/cru/DD-LDT-1473-1 https://devapps.diality.us/cru/DD-LDT-1473-1 Michael Garthwaite , Sean Nash and Dara Navaei finished reviewing DD-LDT-1473-1 DD-LDT-1473_Ultrafiltration DD ]]> DD-LDT-1473-1: started by Vinayakam Mani Mon, 04 Aug 2025 12:58:00 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1473-1 https://devapps.diality.us/cru/DD-LDT-1473-1 Vinayakam Mani started review DD-LDT-1473-1 ]]> DD-LDT-1473-1: comment by Michael Garthwaite "Thanks. Resolved" Mon, 04 Aug 2025 10:07:27 -0700 Michael Garthwaite https://devapps.diality.us/cru/DD-LDT-1473-1/#c23495 https://devapps.diality.us/cru/DD-LDT-1473-1/#c23495 Michael Garthwaite replied to Vinayakam Mani in DD-LDT-1473-1

Thanks. Resolved

]]> DD-LDT-1473-1: comment by Vinayakam Mani "it is moved to DDDef.h, UI team is looking for ..." Mon, 04 Aug 2025 09:44:26 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1473-1/#c23487 https://devapps.diality.us/cru/DD-LDT-1473-1/#c23487 Vinayakam Mani replied to Michael Garthwaite in DD-LDT-1473-1

it is moved to DDDef.h, UI team is looking for this mapping for their (diagnostics page) development.

]]> DD-LDT-1473-1: comment by Michael Garthwaite "Where did this valve enum go?" Mon, 04 Aug 2025 09:34:43 -0700 Michael Garthwaite https://devapps.diality.us/cru/DD-LDT-1473-1/#c23484 https://devapps.diality.us/cru/DD-LDT-1473-1/#c23484 Michael Garthwaite commented on DD-LDT-1473-1

Where did this valve enum go?

]]> DD-LDT-1473-1: comment by Vinayakam Mani "Done." Fri, 01 Aug 2025 16:42:09 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1473-1/#c23462 https://devapps.diality.us/cru/DD-LDT-1473-1/#c23462 Vinayakam Mani replied to Sean Nash in DD-LDT-1473-1

Done.

]]> DD-LDT-1473-1: comment by Vinayakam Mani "I have introduced two additional build flags in..." Fri, 01 Aug 2025 16:34:25 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1473-1/#c23458 https://devapps.diality.us/cru/DD-LDT-1473-1/#c23458 Vinayakam Mani replied to Sean Nash in DD-LDT-1473-1

I have introduced two additional build flags in 'DDCommon.h' (ENABLE_ALARM_1 and ENABLE_ALARM_2) to currently stop triggering alarms due to hardware support etc., so. it should be safe for now. if still any specific alarms triggers, will try to disable those alarms.

]]> DD-LDT-1473-1: comment by Sean Nash "2 blank lines above and below test support bann..." Fri, 01 Aug 2025 16:06:06 -0700 Sean Nash https://devapps.diality.us/cru/DD-LDT-1473-1/#c23452 https://devapps.diality.us/cru/DD-LDT-1473-1/#c23452 Sean Nash commented on DD-LDT-1473-1

2 blank lines above and below test support banners.

]]> DD-LDT-1473-1: comment by Sean Nash "Is this safe to enable now?" Fri, 01 Aug 2025 16:05:32 -0700 Sean Nash https://devapps.diality.us/cru/DD-LDT-1473-1/#c23451 https://devapps.diality.us/cru/DD-LDT-1473-1/#c23451 Sean Nash commented on DD-LDT-1473-1

Is this safe to enable now?

]]> DD-LDT-1473-1: comment by Sean Nash "Consider doing this in update compensated rate ..." Tue, 29 Jul 2025 22:23:22 -0700 Sean Nash https://devapps.diality.us/cru/DD-LDT-1473-1/#c23254 https://devapps.diality.us/cru/DD-LDT-1473-1/#c23254 Sean Nash commented on DD-LDT-1473-1

Consider doing this in update compensated rate function (only once every 2 minutes when rate actually changes).

]]> DD-LDT-1473-1: comment by Vinayakam Mani "Done." Mon, 28 Jul 2025 14:15:12 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1473-1/#c23208 https://devapps.diality.us/cru/DD-LDT-1473-1/#c23208 Vinayakam Mani replied to Sean Nash in DD-LDT-1473-1

Done.

]]> DD-LDT-1473-1: comment by Vinayakam Mani "Done." Mon, 28 Jul 2025 14:08:09 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1473-1/#c23207 https://devapps.diality.us/cru/DD-LDT-1473-1/#c23207 Vinayakam Mani replied to Sean Nash in DD-LDT-1473-1

Done.

]]> DD-LDT-1473-1: comment by Sean Nash "Remove extra blank line." Mon, 28 Jul 2025 14:03:26 -0700 Sean Nash https://devapps.diality.us/cru/DD-LDT-1473-1/#c23203 https://devapps.diality.us/cru/DD-LDT-1473-1/#c23203 Sean Nash commented on DD-LDT-1473-1

Remove extra blank line.

]]> DD-LDT-1473-1: comment by Vinayakam Mani "Done" Mon, 28 Jul 2025 14:00:54 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1473-1/#c23202 https://devapps.diality.us/cru/DD-LDT-1473-1/#c23202 Vinayakam Mani replied to Sean Nash in DD-LDT-1473-1

Done

]]>