Fisheye on ro-firmware/firmware/App/Controllers/ROPump.h https://devapps.diality.us/changelog/~br%3DLDT-828-stop-state-fp/ro-firmware/firmware/App/Controllers/ROPump.h Recent activity in "ro-firmware" under directory /firmware/App/Controllers/ROPump.h LEAHI-RO-FIRMWARE-LDT-828-1: closed by Michael Garthwaite Wed, 03 Sep 2025 08:52:54 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 Michael Garthwaite Closed LEAHI-RO-FIRMWARE-LDT-828-1 ]]> LEAHI-RO-FIRMWARE-LDT-1242-1: closed by Michael Garthwaite Wed, 03 Sep 2025 08:52:47 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 Michael Garthwaite Closed LEAHI-RO-FIRMWARE-LDT-1242-1 ]]> RO-LDT-1809-3: closed by Raghu Kallala Tue, 02 Sep 2025 14:00:53 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1809-3 https://devapps.diality.us/cru/RO-LDT-1809-3 Raghu Kallala Closed RO-LDT-1809-3 ]]> LEAHI-RO-FIRMWARE-LDT-828-1: started by Dara Navaei Tue, 02 Sep 2025 10:03:23 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 Dara Navaei started review LEAHI-RO-FIRMWARE-LDT-828-1 ]]> LEAHI-RO-FIRMWARE-LDT-1242-1: started by Dara Navaei Tue, 02 Sep 2025 10:03:14 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 Dara Navaei started review LEAHI-RO-FIRMWARE-LDT-1242-1 ]]> RO-LDT-1809-3: reviewers finished Thu, 28 Aug 2025 14:17:31 -0700 https://devapps.diality.us/cru/RO-LDT-1809-3 https://devapps.diality.us/cru/RO-LDT-1809-3 Michael Garthwaite and Sean Nash finished reviewing RO-LDT-1809-3 RO-LDT-1809_Iofp WS Setup And Bug Fixing ]]> RO-LDT-1809-3: comment by Raghu Kallala "Fixed" Wed, 27 Aug 2025 14:53:51 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1809-3/#c23921 https://devapps.diality.us/cru/RO-LDT-1809-3/#c23921 Raghu Kallala replied to Sean Nash in RO-LDT-1809-3

Fixed

]]> RO-LDT-1809-3: comment by Raghu Kallala "changed" Wed, 27 Aug 2025 14:29:46 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1809-3/#c23916 https://devapps.diality.us/cru/RO-LDT-1809-3/#c23916 Raghu Kallala replied to Sean Nash in RO-LDT-1809-3

changed

]]> RO-LDT-1809-3: comment by Raghu Kallala "Changed" Wed, 27 Aug 2025 14:29:39 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1809-3/#c23915 https://devapps.diality.us/cru/RO-LDT-1809-3/#c23915 Raghu Kallala replied to Sean Nash in RO-LDT-1809-3

Changed

]]> RO-LDT-1809-3: comment by Raghu Kallala "Changed" Wed, 27 Aug 2025 14:29:25 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1809-3/#c23914 https://devapps.diality.us/cru/RO-LDT-1809-3/#c23914 Raghu Kallala replied to Sean Nash in RO-LDT-1809-3

Changed

]]> RO-LDT-1809-3: comment by Sean Nash "Indents don't look right." Wed, 27 Aug 2025 14:00:28 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-1809-3/#c23912 https://devapps.diality.us/cru/RO-LDT-1809-3/#c23912 Sean Nash commented on RO-LDT-1809-3

Indents don't look right.

]]> RO-LDT-1809-3: comment by Sean Nash "Change to ( skipSet != TRUE )" Wed, 27 Aug 2025 13:59:50 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-1809-3/#c23911 https://devapps.diality.us/cru/RO-LDT-1809-3/#c23911 Sean Nash commented on RO-LDT-1809-3

Change to ( skipSet != TRUE )

]]> RO-LDT-1809-3: comment by Sean Nash "Change to ( skipSet != TRUE )" Wed, 27 Aug 2025 13:59:15 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-1809-3/#c23910 https://devapps.diality.us/cru/RO-LDT-1809-3/#c23910 Sean Nash commented on RO-LDT-1809-3

Change to ( skipSet != TRUE )

]]> RO-LDT-1809-3: comment by Sean Nash "Change to ( skipSet != TRUE )" Wed, 27 Aug 2025 13:58:00 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-1809-3/#c23909 https://devapps.diality.us/cru/RO-LDT-1809-3/#c23909 Sean Nash commented on RO-LDT-1809-3

Change to ( skipSet != TRUE )

]]> RO-LDT-1809-3: comment by Raghu Kallala "Moved to FluidPump" Tue, 26 Aug 2025 14:49:20 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1809-3/#c23896 https://devapps.diality.us/cru/RO-LDT-1809-3/#c23896 Raghu Kallala replied to Sean Nash in RO-LDT-1809-3

Moved to FluidPump

]]> RO-LDT-1809-3: comment by Raghu Kallala "Added blank lines as needed" Tue, 26 Aug 2025 14:46:01 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1809-3/#c23895 https://devapps.diality.us/cru/RO-LDT-1809-3/#c23895 Raghu Kallala replied to Sean Nash in RO-LDT-1809-3

Added blank lines as needed

]]> RO-LDT-1809-3: comment by Raghu Kallala "Removed multiple return" Tue, 26 Aug 2025 14:44:22 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1809-3/#c23894 https://devapps.diality.us/cru/RO-LDT-1809-3/#c23894 Raghu Kallala replied to Sean Nash in RO-LDT-1809-3

Removed multiple return

]]> RO-LDT-1809-3: comment by Raghu Kallala "Added comment line" Tue, 26 Aug 2025 14:44:12 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1809-3/#c23893 https://devapps.diality.us/cru/RO-LDT-1809-3/#c23893 Raghu Kallala replied to Sean Nash in RO-LDT-1809-3

Added comment line

]]> RO-LDT-1809-3: comment by Raghu Kallala "Done" Tue, 26 Aug 2025 14:44:07 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1809-3/#c23892 https://devapps.diality.us/cru/RO-LDT-1809-3/#c23892 Raghu Kallala replied to Sean Nash in RO-LDT-1809-3

Done

]]> RO-LDT-1809-3: comment by Raghu Kallala "Removed multiple returns" Tue, 26 Aug 2025 14:44:01 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1809-3/#c23891 https://devapps.diality.us/cru/RO-LDT-1809-3/#c23891 Raghu Kallala replied to Sean Nash in RO-LDT-1809-3

Removed multiple returns

]]> RO-LDT-1809-3: comment by Raghu Kallala "Added comment line" Tue, 26 Aug 2025 14:43:48 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1809-3/#c23890 https://devapps.diality.us/cru/RO-LDT-1809-3/#c23890 Raghu Kallala replied to Sean Nash in RO-LDT-1809-3

Added comment line

]]> RO-LDT-1809-3: comment by Raghu Kallala "Done" Tue, 26 Aug 2025 14:43:41 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1809-3/#c23889 https://devapps.diality.us/cru/RO-LDT-1809-3/#c23889 Raghu Kallala replied to Sean Nash in RO-LDT-1809-3

Done

]]> RO-LDT-1809-3: comment by Raghu Kallala "Removed return and replaced with skip flag" Tue, 26 Aug 2025 14:43:31 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1809-3/#c23888 https://devapps.diality.us/cru/RO-LDT-1809-3/#c23888 Raghu Kallala replied to Sean Nash in RO-LDT-1809-3

Removed return and replaced with skip flag

]]> RO-LDT-1809-3: comment by Raghu Kallala "Added comment line" Tue, 26 Aug 2025 14:43:09 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1809-3/#c23887 https://devapps.diality.us/cru/RO-LDT-1809-3/#c23887 Raghu Kallala replied to Sean Nash in RO-LDT-1809-3

Added comment line

]]> RO-LDT-1809-3: comment by Raghu Kallala "Done" Tue, 26 Aug 2025 14:42:49 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1809-3/#c23886 https://devapps.diality.us/cru/RO-LDT-1809-3/#c23886 Raghu Kallala replied to Sean Nash in RO-LDT-1809-3

Done

]]> RO-LDT-1809-3: comment by Sean Nash "We want 2 blank lines before and after test sup..." Tue, 26 Aug 2025 13:45:40 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-1809-3/#c23885 https://devapps.diality.us/cru/RO-LDT-1809-3/#c23885 Sean Nash commented on RO-LDT-1809-3

We want 2 blank lines before and after test support banner. So restore this deleted row.

]]> RO-LDT-1809-3: comment by Sean Nash "Cannot return here." Tue, 26 Aug 2025 13:45:00 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-1809-3/#c23884 https://devapps.diality.us/cru/RO-LDT-1809-3/#c23884 Sean Nash commented on RO-LDT-1809-3

Cannot return here.

]]> RO-LDT-1809-3: comment by Sean Nash "Add a comment." Tue, 26 Aug 2025 13:44:52 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-1809-3/#c23883 https://devapps.diality.us/cru/RO-LDT-1809-3/#c23883 Sean Nash commented on RO-LDT-1809-3

Add a comment.

]]> RO-LDT-1809-3: comment by Sean Nash "Add @param for new param." Tue, 26 Aug 2025 13:44:44 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-1809-3/#c23882 https://devapps.diality.us/cru/RO-LDT-1809-3/#c23882 Sean Nash commented on RO-LDT-1809-3

Add @param for new param.

]]> RO-LDT-1809-3: comment by Sean Nash "Add @param for new param." Tue, 26 Aug 2025 13:44:31 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-1809-3/#c23881 https://devapps.diality.us/cru/RO-LDT-1809-3/#c23881 Sean Nash commented on RO-LDT-1809-3

Add @param for new param.

]]>