Fisheye on ro-firmware/firmware/App/Modes/FPModeFault.c https://devapps.diality.us/changelog/~br%3DLDT-828-stop-state-fp/ro-firmware/firmware/App/Modes/FPModeFault.c Recent activity in "ro-firmware" under directory /firmware/App/Modes/FPModeFault.c RO-LDT-1242-1: closed by Michael Garthwaite Fri, 05 Sep 2025 07:58:15 -0700 Michael Garthwaite https://devapps.diality.us/cru/RO-LDT-1242-1 https://devapps.diality.us/cru/RO-LDT-1242-1 Michael Garthwaite Closed RO-LDT-1242-1 ]]> RO-LDT-1242-1: reviewers finished Thu, 04 Sep 2025 09:01:05 -0700 https://devapps.diality.us/cru/RO-LDT-1242-1 https://devapps.diality.us/cru/RO-LDT-1242-1 Sean Nash and Raghu Kallala finished reviewing RO-LDT-1242-1 RO-LDT-1242_Iofp Finalize Permeate Tank ]]> RO-LDT-1242-1: comment by Michael Garthwaite "reverted commit. Back to 110 ranking and change..." Thu, 04 Sep 2025 08:39:13 -0700 Michael Garthwaite https://devapps.diality.us/cru/RO-LDT-1242-1/#c24037 https://devapps.diality.us/cru/RO-LDT-1242-1/#c24037 Michael Garthwaite replied to Sean Nash in RO-LDT-1242-1

reverted commit. Back to 110 ranking and changed properties for DD fault = TRUE

]]> RO-LDT-1242-1: comment by Raghu Kallala "fault -> FALSE" Thu, 04 Sep 2025 08:19:32 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1242-1/#c24036 https://devapps.diality.us/cru/RO-LDT-1242-1/#c24036 Raghu Kallala commented on RO-LDT-1242-1

fault -> FALSE

]]> RO-LDT-1242-1: comment by Sean Nash "Or maybe 110 was correct and fault property sho..." Wed, 03 Sep 2025 12:43:25 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-1242-1/#c24028 https://devapps.diality.us/cru/RO-LDT-1242-1/#c24028 Sean Nash replied to Michael Garthwaite in RO-LDT-1242-1

Or maybe 110 was correct and fault property should be FALSE and DD fault property should be TRUE? This doesn't look like a TD fault. All other faults are DD faults.

]]> RO-LDT-1242-1: comment by Michael Garthwaite "updated pre-gen alarms that fault to rank 10" Wed, 03 Sep 2025 10:20:04 -0700 Michael Garthwaite https://devapps.diality.us/cru/RO-LDT-1242-1/#c24026 https://devapps.diality.us/cru/RO-LDT-1242-1/#c24026 Michael Garthwaite replied to Sean Nash in RO-LDT-1242-1

updated pre-gen alarms that fault to rank 10

]]> RO-LDT-1242-1: comment by Michael Garthwaite "fixed thanks!" Wed, 03 Sep 2025 10:15:21 -0700 Michael Garthwaite https://devapps.diality.us/cru/RO-LDT-1242-1/#c24025 https://devapps.diality.us/cru/RO-LDT-1242-1/#c24025 Michael Garthwaite replied to Sean Nash in RO-LDT-1242-1

fixed thanks!

]]> RO-LDT-1242-1: comment by Michael Garthwaite "just a placeholder for now ( until SA updates )..." Wed, 03 Sep 2025 10:15:14 -0700 Michael Garthwaite https://devapps.diality.us/cru/RO-LDT-1242-1/#c24024 https://devapps.diality.us/cru/RO-LDT-1242-1/#c24024 Michael Garthwaite replied to Sean Nash in RO-LDT-1242-1

just a placeholder for now ( until SA updates ). bumped it to 10 seconds in the meantime

]]> RO-LDT-1242-1: comment by Michael Garthwaite "fixed thanks!" Wed, 03 Sep 2025 10:14:30 -0700 Michael Garthwaite https://devapps.diality.us/cru/RO-LDT-1242-1/#c24023 https://devapps.diality.us/cru/RO-LDT-1242-1/#c24023 Michael Garthwaite replied to Sean Nash in RO-LDT-1242-1

fixed thanks!

]]> RO-LDT-1242-1: comment by Michael Garthwaite "fixed thanks!" Wed, 03 Sep 2025 10:14:21 -0700 Michael Garthwaite https://devapps.diality.us/cru/RO-LDT-1242-1/#c24022 https://devapps.diality.us/cru/RO-LDT-1242-1/#c24022 Michael Garthwaite replied to Sean Nash in RO-LDT-1242-1

fixed thanks!

]]> RO-LDT-1242-1: comment by Michael Garthwaite "fixed thanks!" Wed, 03 Sep 2025 10:14:09 -0700 Michael Garthwaite https://devapps.diality.us/cru/RO-LDT-1242-1/#c24021 https://devapps.diality.us/cru/RO-LDT-1242-1/#c24021 Michael Garthwaite replied to Sean Nash in RO-LDT-1242-1

fixed thanks!

]]> RO-LDT-1242-1: comment by Michael Garthwaite "fixed thanks!" Wed, 03 Sep 2025 10:13:59 -0700 Michael Garthwaite https://devapps.diality.us/cru/RO-LDT-1242-1/#c24020 https://devapps.diality.us/cru/RO-LDT-1242-1/#c24020 Michael Garthwaite replied to Sean Nash in RO-LDT-1242-1

fixed thanks!

]]> RO-LDT-1242-1: comment by Michael Garthwaite "removed comment." Wed, 03 Sep 2025 10:13:45 -0700 Michael Garthwaite https://devapps.diality.us/cru/RO-LDT-1242-1/#c24019 https://devapps.diality.us/cru/RO-LDT-1242-1/#c24019 Michael Garthwaite replied to Sean Nash in RO-LDT-1242-1

removed comment.

]]> RO-LDT-1242-1: comment by Michael Garthwaite "fixed thanks!" Wed, 03 Sep 2025 10:13:23 -0700 Michael Garthwaite https://devapps.diality.us/cru/RO-LDT-1242-1/#c24018 https://devapps.diality.us/cru/RO-LDT-1242-1/#c24018 Michael Garthwaite replied to Sean Nash in RO-LDT-1242-1

fixed thanks!

]]> RO-LDT-1242-1: comment by Michael Garthwaite "fixed thanks!" Wed, 03 Sep 2025 10:12:58 -0700 Michael Garthwaite https://devapps.diality.us/cru/RO-LDT-1242-1/#c24017 https://devapps.diality.us/cru/RO-LDT-1242-1/#c24017 Michael Garthwaite replied to Sean Nash in RO-LDT-1242-1

fixed thanks!

]]> RO-LDT-1242-1: comment by Michael Garthwaite "it was place holder until blood leak alarms are..." Wed, 03 Sep 2025 09:27:52 -0700 Michael Garthwaite https://devapps.diality.us/cru/RO-LDT-1242-1/#c24016 https://devapps.diality.us/cru/RO-LDT-1242-1/#c24016 Michael Garthwaite replied to Sean Nash in RO-LDT-1242-1

it was place holder until blood leak alarms are were in staging. its in order now.

]]> RO-LDT-566-4: closed by Michael Garthwaite Wed, 03 Sep 2025 08:53:20 -0700 Michael Garthwaite https://devapps.diality.us/cru/RO-LDT-566-4 https://devapps.diality.us/cru/RO-LDT-566-4 Michael Garthwaite Closed RO-LDT-566-4 ]]> LEAHI-RO-FIRMWARE-LDT-828-1: closed by Michael Garthwaite Wed, 03 Sep 2025 08:52:54 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 Michael Garthwaite Closed LEAHI-RO-FIRMWARE-LDT-828-1 ]]> LEAHI-RO-FIRMWARE-LDT-1242-1: closed by Michael Garthwaite Wed, 03 Sep 2025 08:52:47 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 Michael Garthwaite Closed LEAHI-RO-FIRMWARE-LDT-1242-1 ]]> RO-LDT-1809-3: closed by Raghu Kallala Tue, 02 Sep 2025 14:00:53 -0700 Raghu Kallala https://devapps.diality.us/cru/RO-LDT-1809-3 https://devapps.diality.us/cru/RO-LDT-1809-3 Raghu Kallala Closed RO-LDT-1809-3 ]]> LEAHI-RO-FIRMWARE-LDT-828-1: started by Dara Navaei Tue, 02 Sep 2025 10:03:23 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 Dara Navaei started review LEAHI-RO-FIRMWARE-LDT-828-1 ]]> LEAHI-RO-FIRMWARE-LDT-1242-1: started by Dara Navaei Tue, 02 Sep 2025 10:03:14 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 Dara Navaei started review LEAHI-RO-FIRMWARE-LDT-1242-1 ]]> RO-LDT-1242-1: comment by Sean Nash "Add comment to right." Fri, 29 Aug 2025 14:02:28 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-1242-1/#c23991 https://devapps.diality.us/cru/RO-LDT-1242-1/#c23991 Sean Nash commented on RO-LDT-1242-1

Add comment to right.

]]> RO-LDT-1242-1: comment by Sean Nash "I don't think alarms will work with gaps in thi..." Fri, 29 Aug 2025 13:54:02 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-1242-1/#c23988 https://devapps.diality.us/cru/RO-LDT-1242-1/#c23988 Sean Nash commented on RO-LDT-1242-1

I don't think alarms will work with gaps in this enum. Other table(s) will complain I think. Lookups will find wrong alarm, etc...

]]> RO-LDT-1809-3: reviewers finished Thu, 28 Aug 2025 14:17:31 -0700 https://devapps.diality.us/cru/RO-LDT-1809-3 https://devapps.diality.us/cru/RO-LDT-1809-3 Michael Garthwaite and Sean Nash finished reviewing RO-LDT-1809-3 RO-LDT-1809_Iofp WS Setup And Bug Fixing ]]> RO-LDT-1242-1: comment by Sean Nash "Align comment." Thu, 28 Aug 2025 09:59:46 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-1242-1/#c23949 https://devapps.diality.us/cru/RO-LDT-1242-1/#c23949 Sean Nash commented on RO-LDT-1242-1

Align comment.

]]> RO-LDT-1242-1: comment by Sean Nash "I think tank control has priority over recovery..." Thu, 28 Aug 2025 09:58:18 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-1242-1/#c23948 https://devapps.diality.us/cru/RO-LDT-1242-1/#c23948 Sean Nash commented on RO-LDT-1242-1

I think tank control has priority over recovery configs.

]]> RO-LDT-1242-1: comment by Sean Nash "Add blank line after declarations." Thu, 28 Aug 2025 09:56:46 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-1242-1/#c23947 https://devapps.diality.us/cru/RO-LDT-1242-1/#c23947 Sean Nash commented on RO-LDT-1242-1

Add blank line after declarations.

]]> RO-LDT-1242-1: comment by Sean Nash "Align "="." Thu, 28 Aug 2025 09:56:20 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-1242-1/#c23946 https://devapps.diality.us/cru/RO-LDT-1242-1/#c23946 Sean Nash commented on RO-LDT-1242-1

Align "=".

]]> RO-LDT-1242-1: comment by Sean Nash "Add comment to right." Thu, 28 Aug 2025 09:56:06 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-1242-1/#c23945 https://devapps.diality.us/cru/RO-LDT-1242-1/#c23945 Sean Nash commented on RO-LDT-1242-1

Add comment to right.

]]>