Fisheye on td-firmware/firmware/App/Services/CpldInterface.c https://devapps.diality.us/changelog/~br%3DLEAH-103-fw-td-unit-testing/td-firmware/firmware/App/Services/CpldInterface.c Recent activity in "td-firmware" under directory /firmware/App/Services/CpldInterface.c TD-LEAH-51-1: closed by Sean Nash Thu, 21 Nov 2024 15:20:58 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-51-1 https://devapps.diality.us/cru/TD-LEAH-51-1 Sean Nash Closed TD-LEAH-51-1 ]]> TD-LEAH-51-1: reviewers finished Thu, 21 Nov 2024 14:59:59 -0800 https://devapps.diality.us/cru/TD-LEAH-51-1 https://devapps.diality.us/cru/TD-LEAH-51-1 Michael Garthwaite finished reviewing TD-LEAH-51-1 TD-LEAH-51_FW TD Blood Pump Controller Moni ]]> TD-LEAH-51-1: reviewers finished Tue, 05 Nov 2024 10:10:53 -0800 https://devapps.diality.us/cru/TD-LEAH-51-1 https://devapps.diality.us/cru/TD-LEAH-51-1 Vinayakam Mani finished reviewing TD-LEAH-51-1 TD-LEAH-51_FW TD Blood Pump Controller Moni ]]> TD-LEAH-51-1: comment by Sean Nash "Per comment, 1320 is maximum "measured" flow ra..." Mon, 04 Nov 2024 11:53:39 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-51-1/#c20799 https://devapps.diality.us/cru/TD-LEAH-51-1/#c20799 Sean Nash replied to Vinayakam Mani in TD-LEAH-51-1

Per comment, 1320 is maximum "measured" flow rate. 700 is maximum "settable" flow rate. 500 is maximum prescribed flow rate.

]]> TD-LEAH-51-1: comment by Vinayakam Mani "Please comment comparing the previous macros in..." Fri, 01 Nov 2024 16:27:51 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-51-1/#c20737 https://devapps.diality.us/cru/TD-LEAH-51-1/#c20737 Vinayakam Mani commented on TD-LEAH-51-1

Please comment comparing the previous macros in .c file.

]]> TD-LEAH-51-1: comment by Vinayakam Mani "Please add \b style formatting for inputs, outp..." Fri, 01 Nov 2024 16:23:31 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-51-1/#c20736 https://devapps.diality.us/cru/TD-LEAH-51-1/#c20736 Vinayakam Mani commented on TD-LEAH-51-1

Please add \b style formatting for inputs, outputs and alarms (entire file). Also add alarm details where needed.

]]> TD-LEAH-51-1: comment by Vinayakam Mani "There is another macro " MAX_SETTABLE_BLOOD_FLO..." Fri, 01 Nov 2024 15:59:59 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-51-1/#c20735 https://devapps.diality.us/cru/TD-LEAH-51-1/#c20735 Vinayakam Mani commented on TD-LEAH-51-1

There is another macro " MAX_SETTABLE_BLOOD_FLOW_RATE" defining 700.. are they similar or different one? may need to change macro name or add comment for clarification.

]]> TD-LEAH-51-1: comment by Sean Nash "Fixed." Tue, 29 Oct 2024 09:07:01 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-51-1/#c20649 https://devapps.diality.us/cru/TD-LEAH-51-1/#c20649 Sean Nash replied to Vinayakam Mani in TD-LEAH-51-1

Fixed.

]]> TD-LEAH-51-1: comment by Sean Nash "Fixed." Tue, 29 Oct 2024 09:05:07 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-51-1/#c20648 https://devapps.diality.us/cru/TD-LEAH-51-1/#c20648 Sean Nash replied to Vinayakam Mani in TD-LEAH-51-1

Fixed.

]]> TD-LEAH-51-1: comment by Sean Nash "Fixed." Tue, 29 Oct 2024 09:04:06 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-51-1/#c20647 https://devapps.diality.us/cru/TD-LEAH-51-1/#c20647 Sean Nash replied to Vinayakam Mani in TD-LEAH-51-1

Fixed.

]]> TD-LEAH-51-1: comment by Vinayakam Mani "payload length check." Mon, 28 Oct 2024 10:31:37 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-51-1/#c20640 https://devapps.diality.us/cru/TD-LEAH-51-1/#c20640 Vinayakam Mani commented on TD-LEAH-51-1

payload length check.

]]> TD-LEAH-51-1: comment by Sean Nash "Fixed." Mon, 28 Oct 2024 10:27:18 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-51-1/#c20639 https://devapps.diality.us/cru/TD-LEAH-51-1/#c20639 Sean Nash replied to Vinayakam Mani in TD-LEAH-51-1

Fixed.

]]> TD-LEAH-51-1: comment by Vinayakam Mani "Remove 'a'." Mon, 28 Oct 2024 10:26:15 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-51-1/#c20638 https://devapps.diality.us/cru/TD-LEAH-51-1/#c20638 Vinayakam Mani commented on TD-LEAH-51-1

Remove 'a'.

]]> TD-LEAH-51-1: comment by Sean Nash "Fixed." Mon, 28 Oct 2024 10:24:39 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-51-1/#c20637 https://devapps.diality.us/cru/TD-LEAH-51-1/#c20637 Sean Nash replied to Vinayakam Mani in TD-LEAH-51-1

Fixed.

]]> TD-LEAH-51-1: comment by Sean Nash "Fixed." Mon, 28 Oct 2024 10:24:27 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-51-1/#c20636 https://devapps.diality.us/cru/TD-LEAH-51-1/#c20636 Sean Nash replied to Vinayakam Mani in TD-LEAH-51-1

Fixed.

]]> TD-LEAH-51-1: comment by Vinayakam Mani "unit variables initialized." Mon, 28 Oct 2024 10:23:53 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-51-1/#c20635 https://devapps.diality.us/cru/TD-LEAH-51-1/#c20635 Vinayakam Mani commented on TD-LEAH-51-1

unit variables initialized.

]]> TD-LEAH-51-1: comment by Vinayakam Mani "payload length check to be considered." Mon, 28 Oct 2024 10:20:58 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-51-1/#c20634 https://devapps.diality.us/cru/TD-LEAH-51-1/#c20634 Vinayakam Mani commented on TD-LEAH-51-1

payload length check to be considered.

]]> TD-LEAH-51-1: comment by Sean Nash "Fixed." Mon, 28 Oct 2024 10:15:48 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-51-1/#c20633 https://devapps.diality.us/cru/TD-LEAH-51-1/#c20633 Sean Nash replied to Vinayakam Mani in TD-LEAH-51-1

Fixed.

]]> TD-LEAH-51-1: comment by Vinayakam Mani "Please align the comments into same column." Mon, 28 Oct 2024 10:10:01 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-51-1/#c20631 https://devapps.diality.us/cru/TD-LEAH-51-1/#c20631 Vinayakam Mani commented on TD-LEAH-51-1

Please align the comments into same column.

]]> TD-LEAH-51-1: comment by Sean Nash "Fixed." Mon, 28 Oct 2024 10:10:09 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-51-1/#c20632 https://devapps.diality.us/cru/TD-LEAH-51-1/#c20632 Sean Nash replied to Vinayakam Mani in TD-LEAH-51-1

Fixed.

]]> TD-LEAH-51-1: comment by Sean Nash "Yes. Changed to task interval based debounce t..." Mon, 28 Oct 2024 10:07:22 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-51-1/#c20630 https://devapps.diality.us/cru/TD-LEAH-51-1/#c20630 Sean Nash replied to Vinayakam Mani in TD-LEAH-51-1

Yes. Changed to task interval based debounce timing.

]]> TD-LEAH-51-1: comment by Vinayakam Mani "Message payload length check to be considered." Mon, 28 Oct 2024 09:52:59 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-51-1/#c20629 https://devapps.diality.us/cru/TD-LEAH-51-1/#c20629 Vinayakam Mani commented on TD-LEAH-51-1

Message payload length check to be considered.

]]> TD-LEAH-51-1: comment by Vinayakam Mani "looks the same function name used in FpgaTD and..." Mon, 28 Oct 2024 09:45:39 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-51-1/#c20628 https://devapps.diality.us/cru/TD-LEAH-51-1/#c20628 Vinayakam Mani commented on TD-LEAH-51-1

looks the same function name used in FpgaTD and BloodFlow.C files. Do we want to differentiate between these two-function naming?

]]> TD-LEAH-51-1: comment by Vinayakam Mani "unit variables initialized." Mon, 28 Oct 2024 09:42:19 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-51-1/#c20627 https://devapps.diality.us/cru/TD-LEAH-51-1/#c20627 Vinayakam Mani commented on TD-LEAH-51-1

unit variables initialized.

]]> TD-LEAH-51-1: comment by Sean Nash "Fixed." Mon, 28 Oct 2024 09:37:59 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-51-1/#c20626 https://devapps.diality.us/cru/TD-LEAH-51-1/#c20626 Sean Nash replied to Vinayakam Mani in TD-LEAH-51-1

Fixed.

]]> TD-LEAH-51-1: comment by Sean Nash "Fixed." Mon, 28 Oct 2024 09:37:54 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-51-1/#c20625 https://devapps.diality.us/cru/TD-LEAH-51-1/#c20625 Sean Nash replied to Vinayakam Mani in TD-LEAH-51-1

Fixed.

]]> TD-LEAH-51-1: comment by Sean Nash "Fixed." Mon, 28 Oct 2024 09:37:40 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-51-1/#c20624 https://devapps.diality.us/cru/TD-LEAH-51-1/#c20624 Sean Nash replied to Vinayakam Mani in TD-LEAH-51-1

Fixed.

]]> TD-LEAH-51-1: comment by Vinayakam Mani "Do we need this timeout to be changed as task i..." Mon, 28 Oct 2024 09:26:13 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-51-1/#c20621 https://devapps.diality.us/cru/TD-LEAH-51-1/#c20621 Vinayakam Mani commented on TD-LEAH-51-1

Do we need this timeout to be changed as task interval counter as we were seeing additional 100ms debounce time at times (hence adjusted the requirement)?

]]> TD-LEAH-51-1: comment by Vinayakam Mani "Valves broadcast" Fri, 25 Oct 2024 17:01:18 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-51-1/#c20616 https://devapps.diality.us/cru/TD-LEAH-51-1/#c20616 Vinayakam Mani commented on TD-LEAH-51-1

Valves broadcast

]]> TD-LEAH-51-1: comment by Vinayakam Mani "Please align the comments to fit in same column..." Fri, 25 Oct 2024 16:50:01 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-51-1/#c20615 https://devapps.diality.us/cru/TD-LEAH-51-1/#c20615 Vinayakam Mani commented on TD-LEAH-51-1

Please align the comments to fit in same column, comparing the top comments.

]]>