fixed in latest code

implemented

fixed

I think this would be a TD s/w fault (alarm already define). Just need a new TD s/w fault ID in AlarmMgmtSWFaults.h.

This structure doesn't seem necessary - it's just a middle man. Why not just pass the #defines directly into the quadratic macro?

Fixed

removed from here

fixed

We need new alarm . That should be included in SRS right ? or shall i use SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_SOFTWARE_FAULT) ?

Add blank line after declarations.

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Add blank line after declarations.

I think alarm should be handled inside the setAirPumpState() function.

Should we have alarm here?

duty misspelled.

Can we remove inclusion of fpga here? It shouldn't be needed.

pushed new code

Fixed

fixed it in commit ID 71a6797

I don't like controller bypassing driver to get to fpga access functions. There should be a get function in the driver that we can call here instead.

Add blank line after declarations.

Why two leading zeroes?