Fisheye on td-firmware/firmware/App/Controllers/AlarmAudio.c https://devapps.diality.us/changelog/~br%3DLEAH-1970-td-integration-changes-1/td-firmware/firmware/App/Controllers/AlarmAudio.c Recent activity in "td-firmware" under directory /firmware/App/Controllers/AlarmAudio.c TD-LDT-94-3: closed by Sean Nash Tue, 22 Apr 2025 10:51:27 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-94-3 https://devapps.diality.us/cru/TD-LDT-94-3 Sean Nash Closed TD-LDT-94-3 ]]> TD-LDT-94-3: reviewers finished Tue, 22 Apr 2025 10:31:05 -0700 https://devapps.diality.us/cru/TD-LDT-94-3 https://devapps.diality.us/cru/TD-LDT-94-3 Vinayakam Mani and Michael Garthwaite finished reviewing TD-LDT-94-3 TD-LDT-94_Main Treatment Screen Implement ]]> TD-LDT-94-3: comment by Michael Garthwaite "RESOLVED." Tue, 22 Apr 2025 09:39:33 -0700 Michael Garthwaite https://devapps.diality.us/cru/TD-LDT-94-3/#c21963 https://devapps.diality.us/cru/TD-LDT-94-3/#c21963 Michael Garthwaite replied to Sean Nash in TD-LDT-94-3

RESOLVED.

]]> TD-LDT-94-3: comment by Michael Garthwaite "RESOLVED." Tue, 22 Apr 2025 09:39:21 -0700 Michael Garthwaite https://devapps.diality.us/cru/TD-LDT-94-3/#c21962 https://devapps.diality.us/cru/TD-LDT-94-3/#c21962 Michael Garthwaite replied to Sean Nash in TD-LDT-94-3

RESOLVED.

]]> TD-LDT-94-3: comment by Sean Nash "These get set (lines 485 and 488) before they a..." Tue, 22 Apr 2025 09:34:34 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-94-3/#c21961 https://devapps.diality.us/cru/TD-LDT-94-3/#c21961 Sean Nash replied to Michael Garthwaite in TD-LDT-94-3

These get set (lines 485 and 488) before they are used (line 491). No need to initialize before then.

]]> TD-LDT-94-3: comment by Sean Nash "OperationModes.c init function is only at power..." Tue, 22 Apr 2025 09:31:54 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-94-3/#c21960 https://devapps.diality.us/cru/TD-LDT-94-3/#c21960 Sean Nash replied to Michael Garthwaite in TD-LDT-94-3

OperationModes.c init function is only at power up. This call to init treatment mode is intended to re-init treatment mode before each treatment starts.

]]> TD-LDT-94-3: comment by Michael Garthwaite "Shouldn't these bools be set to a specific valu..." Tue, 22 Apr 2025 09:21:59 -0700 Michael Garthwaite https://devapps.diality.us/cru/TD-LDT-94-3/#c21959 https://devapps.diality.us/cru/TD-LDT-94-3/#c21959 Michael Garthwaite commented on TD-LDT-94-3

Shouldn't these bools be set to a specific value?

]]> TD-LDT-94-3: comment by Michael Garthwaite "this init is already being called in operationm..." Tue, 22 Apr 2025 09:19:39 -0700 Michael Garthwaite https://devapps.diality.us/cru/TD-LDT-94-3/#c21958 https://devapps.diality.us/cru/TD-LDT-94-3/#c21958 Michael Garthwaite commented on TD-LDT-94-3

this init is already being called in operationmode.c's init function. Do we need the redundancy?

]]> TD-LDT-94-3: comment by Sean Nash "Done." Tue, 22 Apr 2025 08:41:23 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-94-3/#c21955 https://devapps.diality.us/cru/TD-LDT-94-3/#c21955 Sean Nash replied to Vinayakam Mani in TD-LDT-94-3

Done.

]]> TD-LDT-94-3: comment by Sean Nash "Fixed." Mon, 21 Apr 2025 17:16:05 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-94-3/#c21946 https://devapps.diality.us/cru/TD-LDT-94-3/#c21946 Sean Nash replied to Vinayakam Mani in TD-LDT-94-3

Fixed.

]]> TD-LDT-94-3: comment by Sean Nash "Fixed." Mon, 21 Apr 2025 17:15:31 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-94-3/#c21945 https://devapps.diality.us/cru/TD-LDT-94-3/#c21945 Sean Nash replied to Vinayakam Mani in TD-LDT-94-3

Fixed.

]]> TD-LDT-94-3: comment by Sean Nash "Fixed." Mon, 21 Apr 2025 17:14:10 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-94-3/#c21944 https://devapps.diality.us/cru/TD-LDT-94-3/#c21944 Sean Nash replied to Vinayakam Mani in TD-LDT-94-3

Fixed.

]]> TD-LDT-94-3: comment by Sean Nash "Removed. Not necessary." Mon, 21 Apr 2025 17:13:05 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-94-3/#c21943 https://devapps.diality.us/cru/TD-LDT-94-3/#c21943 Sean Nash replied to Vinayakam Mani in TD-LDT-94-3

Removed. Not necessary.

]]> TD-LDT-94-3: comment by Sean Nash "Fixed." Mon, 21 Apr 2025 17:12:06 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-94-3/#c21942 https://devapps.diality.us/cru/TD-LDT-94-3/#c21942 Sean Nash replied to Vinayakam Mani in TD-LDT-94-3

Fixed.

]]> TD-LDT-94-3: comment by Sean Nash "Yes. Done." Mon, 21 Apr 2025 17:11:07 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-94-3/#c21941 https://devapps.diality.us/cru/TD-LDT-94-3/#c21941 Sean Nash replied to Vinayakam Mani in TD-LDT-94-3

Yes. Done.

]]> TD-LDT-94-3: comment by Sean Nash "Fixed." Mon, 21 Apr 2025 17:02:53 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-94-3/#c21940 https://devapps.diality.us/cru/TD-LDT-94-3/#c21940 Sean Nash replied to Vinayakam Mani in TD-LDT-94-3

Fixed.

]]> TD-LDT-94-3: comment by Sean Nash "Done." Mon, 21 Apr 2025 17:02:07 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-94-3/#c21939 https://devapps.diality.us/cru/TD-LDT-94-3/#c21939 Sean Nash replied to Vinayakam Mani in TD-LDT-94-3

Done.

]]> TD-LDT-94-3: comment by Sean Nash "Fixed." Mon, 21 Apr 2025 16:58:39 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-94-3/#c21938 https://devapps.diality.us/cru/TD-LDT-94-3/#c21938 Sean Nash replied to Vinayakam Mani in TD-LDT-94-3

Fixed.

]]> TD-LDT-94-3: comment by Sean Nash "Done." Mon, 21 Apr 2025 16:54:18 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-94-3/#c21937 https://devapps.diality.us/cru/TD-LDT-94-3/#c21937 Sean Nash replied to Vinayakam Mani in TD-LDT-94-3

Done.

]]> TD-LDT-94-3: comment by Sean Nash "Fixed." Mon, 21 Apr 2025 16:53:58 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-94-3/#c21936 https://devapps.diality.us/cru/TD-LDT-94-3/#c21936 Sean Nash replied to Vinayakam Mani in TD-LDT-94-3

Fixed.

]]> TD-LDT-94-3: comment by Sean Nash "Fixed." Mon, 21 Apr 2025 16:39:51 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-94-3/#c21935 https://devapps.diality.us/cru/TD-LDT-94-3/#c21935 Sean Nash replied to Vinayakam Mani in TD-LDT-94-3

Fixed.

]]> TD-LDT-94-3: comment by Sean Nash "Done." Mon, 21 Apr 2025 16:38:56 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-94-3/#c21934 https://devapps.diality.us/cru/TD-LDT-94-3/#c21934 Sean Nash replied to Vinayakam Mani in TD-LDT-94-3

Done.

]]> TD-LDT-94-3: comment by Sean Nash "Done." Mon, 21 Apr 2025 16:37:32 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-94-3/#c21933 https://devapps.diality.us/cru/TD-LDT-94-3/#c21933 Sean Nash replied to Vinayakam Mani in TD-LDT-94-3

Done.

]]> TD-LDT-94-3: comment by Sean Nash "Done." Mon, 21 Apr 2025 16:34:37 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-94-3/#c21932 https://devapps.diality.us/cru/TD-LDT-94-3/#c21932 Sean Nash replied to Vinayakam Mani in TD-LDT-94-3

Done.

]]> TD-LDT-94-3: comment by Sean Nash "Done." Mon, 21 Apr 2025 16:31:45 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-94-3/#c21931 https://devapps.diality.us/cru/TD-LDT-94-3/#c21931 Sean Nash replied to Vinayakam Mani in TD-LDT-94-3

Done.

]]> TD-LDT-94-3: comment by Vinayakam Mani "Please add message sent." Mon, 21 Apr 2025 15:13:18 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LDT-94-3/#c21930 https://devapps.diality.us/cru/TD-LDT-94-3/#c21930 Vinayakam Mani commented on TD-LDT-94-3

Please add message sent.

]]> TD-LDT-94-3: comment by Vinayakam Mani "Please add alarm/events." Mon, 21 Apr 2025 15:11:22 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LDT-94-3/#c21929 https://devapps.diality.us/cru/TD-LDT-94-3/#c21929 Vinayakam Mani commented on TD-LDT-94-3

Please add alarm/events.

]]> TD-LDT-94-3: comment by Vinayakam Mani "Update I/O. please revisit across the file." Mon, 21 Apr 2025 15:06:01 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LDT-94-3/#c21928 https://devapps.diality.us/cru/TD-LDT-94-3/#c21928 Vinayakam Mani commented on TD-LDT-94-3

Update I/O. please revisit across the file.

]]> TD-LDT-94-3: comment by Vinayakam Mani "Add alarm/event." Mon, 21 Apr 2025 15:00:03 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LDT-94-3/#c21927 https://devapps.diality.us/cru/TD-LDT-94-3/#c21927 Vinayakam Mani commented on TD-LDT-94-3

Add alarm/event.

]]> TD-LDT-94-3: comment by Vinayakam Mani "TD" Mon, 21 Apr 2025 14:52:15 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LDT-94-3/#c21926 https://devapps.diality.us/cru/TD-LDT-94-3/#c21926 Vinayakam Mani commented on TD-LDT-94-3

TD

]]>