Fisheye on td-firmware/firmware/App/Drivers/BubbleDetector.h

Fisheye on td-firmware/firmware/App/Drivers/BubbleDetector.h https://devapps.diality.us/changelog/~br%3DLEAH-1970-td-integration-changes-1/td-firmware/firmware/App/Drivers/BubbleDetector.h Recent activity in "td-firmware" under directory /firmware/App/Drivers/BubbleDetector.h TD-LDT-736-1: closed by Sean Nash Tue, 29 Jul 2025 22:07:52 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-736-1 https://devapps.diality.us/cru/TD-LDT-736-1 Sean Nash Closed TD-LDT-736-1 ]]> TD-LDT-736-1: reviewers finished Tue, 29 Jul 2025 14:55:56 -0700 https://devapps.diality.us/cru/TD-LDT-736-1 https://devapps.diality.us/cru/TD-LDT-736-1 Dara Navaei and Vinayakam Mani finished reviewing TD-LDT-736-1 TD-LDT-736_General Alarm Requirements TD ]]> TD-LDT-736-1: comment by Sean Nash "Fixed." Tue, 29 Jul 2025 14:17:21 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-736-1/#c23253 https://devapps.diality.us/cru/TD-LDT-736-1/#c23253 Sean Nash replied to Vinayakam Mani in TD-LDT-736-1

Fixed.

]]> TD-LDT-736-1: comment by Sean Nash "Fixed." Tue, 29 Jul 2025 14:16:19 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-736-1/#c23252 https://devapps.diality.us/cru/TD-LDT-736-1/#c23252 Sean Nash replied to Vinayakam Mani in TD-LDT-736-1

Fixed.

]]> TD-LDT-736-1: comment by Sean Nash "Fixed." Tue, 29 Jul 2025 14:14:52 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-736-1/#c23251 https://devapps.diality.us/cru/TD-LDT-736-1/#c23251 Sean Nash replied to Vinayakam Mani in TD-LDT-736-1

Fixed.

]]> TD-LDT-736-1: comment by Sean Nash "When Systems gives me Leahi terms, they will be..." Tue, 29 Jul 2025 14:13:22 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-736-1/#c23250 https://devapps.diality.us/cru/TD-LDT-736-1/#c23250 Sean Nash replied to Vinayakam Mani in TD-LDT-736-1

When Systems gives me Leahi terms, they will be very small fractions.

]]> TD-LDT-736-1: comment by Sean Nash "Fixed." Tue, 29 Jul 2025 14:12:34 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-736-1/#c23249 https://devapps.diality.us/cru/TD-LDT-736-1/#c23249 Sean Nash replied to Vinayakam Mani in TD-LDT-736-1

Fixed.

]]> TD-LDT-736-1: comment by Sean Nash "You're right. Old comment from Denali. Fixed." Tue, 29 Jul 2025 14:11:12 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-736-1/#c23248 https://devapps.diality.us/cru/TD-LDT-736-1/#c23248 Sean Nash replied to Vinayakam Mani in TD-LDT-736-1

You're right. Old comment from Denali. Fixed.

]]> TD-LDT-736-1: comment by Sean Nash "Came from Denali, so I believe this is what the..." Mon, 28 Jul 2025 16:57:34 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-736-1/#c23218 https://devapps.diality.us/cru/TD-LDT-736-1/#c23218 Sean Nash replied to Vinayakam Mani in TD-LDT-736-1

Came from Denali, so I believe this is what they wanted. The nearly 5 minutes is the one the user sees.

]]> TD-LDT-736-1: comment by Vinayakam Mani "space needed in sizeof( BOOL ). Follow the same..." Mon, 28 Jul 2025 15:04:13 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LDT-736-1/#c23216 https://devapps.diality.us/cru/TD-LDT-736-1/#c23216 Vinayakam Mani commented on TD-LDT-736-1

space needed in sizeof( BOOL ). Follow the same for line no : 526.

]]> TD-LDT-736-1: comment by Vinayakam Mani "Please update I/O." Mon, 28 Jul 2025 15:00:03 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LDT-736-1/#c23215 https://devapps.diality.us/cru/TD-LDT-736-1/#c23215 Vinayakam Mani commented on TD-LDT-736-1

Please update I/O.

]]> TD-LDT-736-1: comment by Vinayakam Mani "Add alarm." Mon, 28 Jul 2025 14:54:32 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LDT-736-1/#c23214 https://devapps.diality.us/cru/TD-LDT-736-1/#c23214 Vinayakam Mani commented on TD-LDT-736-1

Add alarm.

]]> TD-LDT-736-1: comment by Vinayakam Mani "Please add param." Mon, 28 Jul 2025 14:52:50 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LDT-736-1/#c23213 https://devapps.diality.us/cru/TD-LDT-736-1/#c23213 Vinayakam Mani commented on TD-LDT-736-1

Please add param.

]]> TD-LDT-736-1: comment by Vinayakam Mani "just 0.0F would work?" Mon, 28 Jul 2025 14:38:31 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LDT-736-1/#c23212 https://devapps.diality.us/cru/TD-LDT-736-1/#c23212 Vinayakam Mani commented on TD-LDT-736-1

just 0.0F would work?

]]> TD-LDT-736-1: comment by Vinayakam Mani "Is it just on/off control or variable speed con..." Mon, 28 Jul 2025 14:33:11 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LDT-736-1/#c23211 https://devapps.diality.us/cru/TD-LDT-736-1/#c23211 Vinayakam Mani commented on TD-LDT-736-1

Is it just on/off control or variable speed control?

]]> TD-LDT-736-1: comment by Vinayakam Mani "Alarm descriptions and trigger conditions calls..." Mon, 28 Jul 2025 14:25:20 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LDT-736-1/#c23209 https://devapps.diality.us/cru/TD-LDT-736-1/#c23209 Vinayakam Mani commented on TD-LDT-736-1

Alarm descriptions and trigger conditions calls out "more than 4 minutes" and Instructions says, "nearly 5 minutes". is this intended to display this way?

]]> TD-LDT-736-1: comment by Sean Nash "Why?" Mon, 28 Jul 2025 09:02:55 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-736-1/#c23179 https://devapps.diality.us/cru/TD-LDT-736-1/#c23179 Sean Nash commented on TD-LDT-736-1

Why?

]]> TD-LDT-736-1: comment by Sean Nash "Restore bulk of this function for now." Thu, 17 Jul 2025 13:27:19 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-736-1/#c22976 https://devapps.diality.us/cru/TD-LDT-736-1/#c22976 Sean Nash commented on TD-LDT-736-1

Restore bulk of this function for now.

]]> TD-LDT-736-1: comment by Sean Nash "I am. Didn't want to wait (up to 50ms) for pum..." Thu, 17 Jul 2025 12:46:55 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-736-1/#c22973 https://devapps.diality.us/cru/TD-LDT-736-1/#c22973 Sean Nash commented on TD-LDT-736-1

I am. Didn't want to wait (up to 50ms) for pump to stop if hard stop is requested. So forcing to off immediately. Not how I would ordinarily want to handle this, but in this case I am.

]]> TD-LDT-736-1: comment by Sean Nash "Why is this necessary? I would think state mac..." Thu, 17 Jul 2025 12:44:25 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-736-1/#c22972 https://devapps.diality.us/cru/TD-LDT-736-1/#c22972 Sean Nash commented on TD-LDT-736-1

Why is this necessary? I would think state machine would already handle this.

]]> TD-LDT-736-1: started by Dara Navaei Thu, 12 Jun 2025 09:24:28 -0700 Dara Navaei https://devapps.diality.us/cru/TD-LDT-736-1 https://devapps.diality.us/cru/TD-LDT-736-1 Dara Navaei started review TD-LDT-736-1 ]]> TD-LEAH-1970-1: closed by Sean Nash Thu, 23 Jan 2025 14:32:36 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-1970-1 https://devapps.diality.us/cru/TD-LEAH-1970-1 Sean Nash Closed TD-LEAH-1970-1 ]]> TD-LEAH-1970-1: reviewers finished Thu, 23 Jan 2025 14:11:13 -0800 https://devapps.diality.us/cru/TD-LEAH-1970-1 https://devapps.diality.us/cru/TD-LEAH-1970-1 Michael Garthwaite finished reviewing TD-LEAH-1970-1 TD-LEAH-1970_TD Integration Changes ]]> TD-LEAH-1970-1: reviewers finished Wed, 22 Jan 2025 11:15:37 -0800 https://devapps.diality.us/cru/TD-LEAH-1970-1 https://devapps.diality.us/cru/TD-LEAH-1970-1 Vinayakam Mani finished reviewing TD-LEAH-1970-1 TD-LEAH-1970_TD Integration Changes ]]> TD-LEAH-1970-1: comment by Sean Nash "Fixed." Wed, 22 Jan 2025 11:07:53 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-1970-1/#c21076 https://devapps.diality.us/cru/TD-LEAH-1970-1/#c21076 Sean Nash replied to Vinayakam Mani in TD-LEAH-1970-1

Fixed.

]]> TD-LEAH-1970-1: comment by Vinayakam Mani "h18Status - naming order to be changed. same fo..." Wed, 22 Jan 2025 10:31:10 -0800 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-1970-1/#c21066 https://devapps.diality.us/cru/TD-LEAH-1970-1/#c21066 Vinayakam Mani commented on TD-LEAH-1970-1

h18Status - naming order to be changed. same for H18state as well.

]]> TD-LEAH-1970-1: comment by Sean Nash "Fixed." Thu, 16 Jan 2025 14:33:09 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-1970-1/#c21049 https://devapps.diality.us/cru/TD-LEAH-1970-1/#c21049 Sean Nash replied to Vinayakam Mani in TD-LEAH-1970-1

Fixed.

]]> TD-LEAH-1970-1: comment by Sean Nash "Good point. Fixed." Thu, 16 Jan 2025 14:32:38 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-1970-1/#c21048 https://devapps.diality.us/cru/TD-LEAH-1970-1/#c21048 Sean Nash replied to Vinayakam Mani in TD-LEAH-1970-1

Good point. Fixed.

]]> td-firmware (LDT-2240-disposable-tube-set-self-test): TEST: refactor of component names. Mon, 20 Jan 2025 13:59:03 -0800 Sean Nash https://devapps.diality.us/changelog/td-firmware?cs=961784c895cb8f551a2623cd02dcbfe42d04b7c2 https://devapps.diality.us/changelog/td-firmware?cs=961784c895cb8f551a2623cd02dcbfe42d04b7c2 Sean Nash committed 961784c on branch BambooSetup, LDT-1394-blood-flow-rate-h4-rotor-count and 55 more in td-firmware TEST: refactor of component names.

· /firmware/App/Controllers/AirTrap.c (-19, +19) | History | Source | Diff

· /firmware/App/Drivers/BubbleDetector.c (-5, +5) | History | Source | Diff

· /firmware/App/Drivers/BubbleDetector.h (-1, +1) | History | Source | Diff

· /firmware/App/Drivers/LevelSensors.c (-2, +2) | History | Source | Diff

· /firmware/App/Drivers/LevelSensors.h (-3, +3) | History | Source | Diff

· /firmware/App/Drivers/PressureSensor.c (-16, +16) | History | Source | Diff

· /firmware/App/Drivers/PressureSensor.h (-2, +2) | History | Source | Diff

· /firmware/App/Drivers/RotaryValve.c (-9, +9) | History | Source | Diff

· /firmware/App/Drivers/RotaryValve.h (-3, +3) | History | Source | Diff

· /firmware/App/Drivers/Valve2Way.c (-2, +2) | History | Source | Diff

· /firmware/App/Drivers/Valve2Way.h (-1, +1) | History | Source | Diff

· /firmware/App/Modes/ModeFault.c (-1, +1) | History | Source | Diff

· /firmware/App/Modes/ModeService.c (-1, +1) | History | Source | Diff

· /firmware/App/Modes/ModeStandby.c (-3, +3) | History | Source | Diff

· /firmware/App/Monitors/Bubbles.c (-4, +4) | History | Source | Diff

… 4 more files in changeset.

]]> TD-LEAH-1970-1: comment by Vinayakam Mani "We may need to keep generic name of variable as..." Thu, 16 Jan 2025 09:56:16 -0800 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-1970-1/#c21045 https://devapps.diality.us/cru/TD-LEAH-1970-1/#c21045 Vinayakam Mani commented on TD-LEAH-1970-1

We may need to keep generic name of variable as 'pressure' instead of 'pressure_bar' (since it's no more converting into bar unit).

]]>