Fisheye on dd-firmware/firmware/App/Services/ROInterface.c https://devapps.diality.us/changelog/~br%3DLEAH-1971-dd-integration-changes-1/dd-firmware/firmware/App/Services/ROInterface.c Recent activity in "dd-firmware" under directory /firmware/App/Services/ROInterface.c LEAHI-DD-FIRMWARE-LDT-2004-13: started by Dara Navaei Wed, 25 Mar 2026 04:01:46 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-13 ]]> LEAHI-DD-FIRMWARE-LDT-2004-11: started by Dara Navaei Thu, 19 Mar 2026 15:47:06 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-11 ]]> DD-LDT-1873-1: closed by Vinayakam Mani Mon, 18 Aug 2025 10:36:00 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1873-1 https://devapps.diality.us/cru/DD-LDT-1873-1 Vinayakam Mani Closed DD-LDT-1873-1 ]]> DD-LDT-1873-1: reviewers finished Mon, 18 Aug 2025 10:21:39 -0700 https://devapps.diality.us/cru/DD-LDT-1873-1 https://devapps.diality.us/cru/DD-LDT-1873-1 Michael Garthwaite and Sean Nash finished reviewing DD-LDT-1873-1 DD-LDT-1873_Dialysate Flow Rate DD ]]> DD-LDT-1873-1: comment by Vinayakam Mani "Done." Mon, 18 Aug 2025 09:58:49 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1873-1/#c23800 https://devapps.diality.us/cru/DD-LDT-1873-1/#c23800 Vinayakam Mani replied to Sean Nash in DD-LDT-1873-1

Done.

]]> DD-LDT-1873-1: comment by Vinayakam Mani "Done." Mon, 18 Aug 2025 09:58:40 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1873-1/#c23799 https://devapps.diality.us/cru/DD-LDT-1873-1/#c23799 Vinayakam Mani replied to Sean Nash in DD-LDT-1873-1

Done.

]]> DD-LDT-1873-1: comment by Sean Nash "Remove extra blank line." Mon, 18 Aug 2025 07:54:39 -0700 Sean Nash https://devapps.diality.us/cru/DD-LDT-1873-1/#c23791 https://devapps.diality.us/cru/DD-LDT-1873-1/#c23791 Sean Nash commented on DD-LDT-1873-1

Remove extra blank line.

]]> DD-LDT-1873-1: comment by Sean Nash "isPressureDroppedDuringFill not initialized in ..." Mon, 18 Aug 2025 07:50:51 -0700 Sean Nash https://devapps.diality.us/cru/DD-LDT-1873-1/#c23790 https://devapps.diality.us/cru/DD-LDT-1873-1/#c23790 Sean Nash commented on DD-LDT-1873-1

isPressureDroppedDuringFill not initialized in init function.

]]> DD-LDT-1873-1: comment by Vinayakam Mani "Done." Wed, 13 Aug 2025 09:59:36 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1873-1/#c23707 https://devapps.diality.us/cru/DD-LDT-1873-1/#c23707 Vinayakam Mani replied to Sean Nash in DD-LDT-1873-1

Done.

]]> DD-LDT-1873-1: comment by Vinayakam Mani "Done." Wed, 13 Aug 2025 09:59:28 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1873-1/#c23706 https://devapps.diality.us/cru/DD-LDT-1873-1/#c23706 Vinayakam Mani replied to Sean Nash in DD-LDT-1873-1

Done.

]]> DD-LDT-1873-1: comment by Vinayakam Mani "Done." Wed, 13 Aug 2025 09:59:22 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1873-1/#c23705 https://devapps.diality.us/cru/DD-LDT-1873-1/#c23705 Vinayakam Mani replied to Sean Nash in DD-LDT-1873-1

Done.

]]> DD-LDT-1873-1: comment by Vinayakam Mani "Done." Wed, 13 Aug 2025 09:58:58 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1873-1/#c23704 https://devapps.diality.us/cru/DD-LDT-1873-1/#c23704 Vinayakam Mani replied to Sean Nash in DD-LDT-1873-1

Done.

]]> DD-LDT-1873-1: comment by Vinayakam Mani "Currently testing is ongoing. Will try to remov..." Wed, 13 Aug 2025 09:58:08 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1873-1/#c23703 https://devapps.diality.us/cru/DD-LDT-1873-1/#c23703 Vinayakam Mani replied to Sean Nash in DD-LDT-1873-1

Currently testing is ongoing. Will try to remove it end of this sprint.

]]> DD-LDT-1873-1: comment by Vinayakam Mani "Done." Wed, 13 Aug 2025 09:57:24 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1873-1/#c23702 https://devapps.diality.us/cru/DD-LDT-1873-1/#c23702 Vinayakam Mani replied to Sean Nash in DD-LDT-1873-1

Done.

]]> DD-LDT-1873-1: comment by Vinayakam Mani "Done." Wed, 13 Aug 2025 09:57:13 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1873-1/#c23701 https://devapps.diality.us/cru/DD-LDT-1873-1/#c23701 Vinayakam Mani replied to Sean Nash in DD-LDT-1873-1

Done.

]]> DD-LDT-1873-1: comment by Sean Nash "Align comment." Tue, 12 Aug 2025 13:57:22 -0700 Sean Nash https://devapps.diality.us/cru/DD-LDT-1873-1/#c23655 https://devapps.diality.us/cru/DD-LDT-1873-1/#c23655 Sean Nash commented on DD-LDT-1873-1

Align comment.

]]> DD-LDT-1873-1: comment by Sean Nash "Should we range check pumpId and trigger s/w fa..." Tue, 12 Aug 2025 13:56:16 -0700 Sean Nash https://devapps.diality.us/cru/DD-LDT-1873-1/#c23654 https://devapps.diality.us/cru/DD-LDT-1873-1/#c23654 Sean Nash commented on DD-LDT-1873-1

Should we range check pumpId and trigger s/w fault if out of range?

]]> DD-LDT-1873-1: comment by Sean Nash "I think these can just be done once after else." Tue, 12 Aug 2025 13:55:34 -0700 Sean Nash https://devapps.diality.us/cru/DD-LDT-1873-1/#c23652 https://devapps.diality.us/cru/DD-LDT-1873-1/#c23652 Sean Nash commented on DD-LDT-1873-1

I think these can just be done once after else.

]]> DD-LDT-1873-1: comment by Sean Nash "Are we done with temporary code? Can we just r..." Tue, 12 Aug 2025 13:53:02 -0700 Sean Nash https://devapps.diality.us/cru/DD-LDT-1873-1/#c23651 https://devapps.diality.us/cru/DD-LDT-1873-1/#c23651 Sean Nash commented on DD-LDT-1873-1

Are we done with temporary code? Can we just remove it?

]]> DD-LDT-1873-1: comment by Sean Nash "Change name (RO to FP)?" Mon, 11 Aug 2025 09:56:32 -0700 Sean Nash https://devapps.diality.us/cru/DD-LDT-1873-1/#c23598 https://devapps.diality.us/cru/DD-LDT-1873-1/#c23598 Sean Nash commented on DD-LDT-1873-1

Change name (RO to FP)?

]]> DD-LDT-1873-1: comment by Sean Nash "Change function name (RO to FP)?" Mon, 11 Aug 2025 09:55:57 -0700 Sean Nash https://devapps.diality.us/cru/DD-LDT-1873-1/#c23597 https://devapps.diality.us/cru/DD-LDT-1873-1/#c23597 Sean Nash commented on DD-LDT-1873-1

Change function name (RO to FP)?

]]> DD-LDT-1873-1: comment by Sean Nash "Update comment too." Mon, 11 Aug 2025 09:55:36 -0700 Sean Nash https://devapps.diality.us/cru/DD-LDT-1873-1/#c23596 https://devapps.diality.us/cru/DD-LDT-1873-1/#c23596 Sean Nash commented on DD-LDT-1873-1

Update comment too.

]]> DD-LDT-1873-1: comment by Sean Nash "If you get a chance, try to find out which mess..." Mon, 11 Aug 2025 09:51:35 -0700 Sean Nash https://devapps.diality.us/cru/DD-LDT-1873-1/#c23595 https://devapps.diality.us/cru/DD-LDT-1873-1/#c23595 Sean Nash replied to Vinayakam Mani in DD-LDT-1873-1

If you get a chance, try to find out which message (ID) is having the CRC error and where it's coming from (which channel) and why it's failing CRC check (e.g. was a frame missing?)

]]> DD-LDT-1873-1: comment by Vinayakam Mani "Done." Fri, 08 Aug 2025 10:48:36 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1873-1/#c23588 https://devapps.diality.us/cru/DD-LDT-1873-1/#c23588 Vinayakam Mani replied to Sean Nash in DD-LDT-1873-1

Done.

]]> DD-LDT-1873-1: comment by Vinayakam Mani "Done." Fri, 08 Aug 2025 10:48:29 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1873-1/#c23587 https://devapps.diality.us/cru/DD-LDT-1873-1/#c23587 Vinayakam Mani replied to Sean Nash in DD-LDT-1873-1

Done.

]]> DD-LDT-1873-1: comment by Vinayakam Mani "I remember seeing once some CRC error. To conti..." Fri, 08 Aug 2025 10:46:48 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1873-1/#c23586 https://devapps.diality.us/cru/DD-LDT-1873-1/#c23586 Vinayakam Mani replied to Sean Nash in DD-LDT-1873-1

I remember seeing once some CRC error. To continue development, disabled fault mode for a while.

]]> DD-LDT-1873-1: comment by Vinayakam Mani "Reverted." Fri, 08 Aug 2025 10:46:14 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1873-1/#c23585 https://devapps.diality.us/cru/DD-LDT-1873-1/#c23585 Vinayakam Mani replied to Sean Nash in DD-LDT-1873-1

Reverted.

]]> DD-LDT-1873-1: comment by Vinayakam Mani "Reverted." Fri, 08 Aug 2025 10:46:06 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1873-1/#c23584 https://devapps.diality.us/cru/DD-LDT-1873-1/#c23584 Vinayakam Mani replied to Sean Nash in DD-LDT-1873-1

Reverted.

]]> DD-LDT-1873-1: comment by Vinayakam Mani "these changes made for testing purposes. revert..." Fri, 08 Aug 2025 10:45:28 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1873-1/#c23583 https://devapps.diality.us/cru/DD-LDT-1873-1/#c23583 Vinayakam Mani replied to Sean Nash in DD-LDT-1873-1

these changes made for testing purposes. reverted to original.

]]> DD-LDT-1873-1: comment by Vinayakam Mani "Done." Fri, 08 Aug 2025 10:44:51 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1873-1/#c23582 https://devapps.diality.us/cru/DD-LDT-1873-1/#c23582 Vinayakam Mani replied to Sean Nash in DD-LDT-1873-1

Done.

]]>