Fisheye on ro-firmware/firmware/include https://devapps.diality.us/changelog/~br%3DLEAH-1972-ro-integration-changes-1/ro-firmware/firmware/include Recent activity in "ro-firmware" under directory /firmware/include LEAHI-RO-FIRMWARE-LDT-828-1: closed by Michael Garthwaite Wed, 03 Sep 2025 08:52:54 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 Michael Garthwaite Closed LEAHI-RO-FIRMWARE-LDT-828-1 ]]> LEAHI-RO-FIRMWARE-LDT-1242-1: closed by Michael Garthwaite Wed, 03 Sep 2025 08:52:47 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 Michael Garthwaite Closed LEAHI-RO-FIRMWARE-LDT-1242-1 ]]> LEAHI-RO-FIRMWARE-LDT-828-1: started by Dara Navaei Tue, 02 Sep 2025 10:03:23 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 Dara Navaei started review LEAHI-RO-FIRMWARE-LDT-828-1 ]]> LEAHI-RO-FIRMWARE-LDT-1242-1: started by Dara Navaei Tue, 02 Sep 2025 10:03:14 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 Dara Navaei started review LEAHI-RO-FIRMWARE-LDT-1242-1 ]]> RO-LEAH-1972-1: closed by Sean Nash Thu, 23 Jan 2025 14:32:43 -0800 Sean Nash https://devapps.diality.us/cru/RO-LEAH-1972-1 https://devapps.diality.us/cru/RO-LEAH-1972-1 Sean Nash Closed RO-LEAH-1972-1 ]]> RO-LEAH-1972-1: reviewers finished Thu, 23 Jan 2025 14:07:39 -0800 https://devapps.diality.us/cru/RO-LEAH-1972-1 https://devapps.diality.us/cru/RO-LEAH-1972-1 Michael Garthwaite finished reviewing RO-LEAH-1972-1 RO-LEAH-1972_RO Integration Changes ]]> RO-LEAH-1972-1: reviewers finished Wed, 22 Jan 2025 11:14:50 -0800 https://devapps.diality.us/cru/RO-LEAH-1972-1 https://devapps.diality.us/cru/RO-LEAH-1972-1 Vinayakam Mani finished reviewing RO-LEAH-1972-1 RO-LEAH-1972_RO Integration Changes ]]> RO-LEAH-1972-1: comment by Sean Nash "Fixed." Wed, 22 Jan 2025 11:01:28 -0800 Sean Nash https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21075 https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21075 Sean Nash replied to Vinayakam Mani in RO-LEAH-1972-1

Fixed.

]]> RO-LEAH-1972-1: comment by Sean Nash "Done." Wed, 22 Jan 2025 11:00:24 -0800 Sean Nash https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21074 https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21074 Sean Nash replied to Vinayakam Mani in RO-LEAH-1972-1

Done.

]]> RO-LEAH-1972-1: comment by Sean Nash "Done." Wed, 22 Jan 2025 10:58:23 -0800 Sean Nash https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21073 https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21073 Sean Nash replied to Vinayakam Mani in RO-LEAH-1972-1

Done.

]]> RO-LEAH-1972-1: comment by Sean Nash "Fixed." Wed, 22 Jan 2025 10:56:06 -0800 Sean Nash https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21072 https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21072 Sean Nash replied to Vinayakam Mani in RO-LEAH-1972-1

Fixed.

]]> RO-LEAH-1972-1: comment by Sean Nash "Done." Wed, 22 Jan 2025 10:53:41 -0800 Sean Nash https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21071 https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21071 Sean Nash replied to Vinayakam Mani in RO-LEAH-1972-1

Done.

]]> RO-LEAH-1972-1: comment by Sean Nash "Fixed." Wed, 22 Jan 2025 10:44:40 -0800 Sean Nash https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21070 https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21070 Sean Nash replied to Vinayakam Mani in RO-LEAH-1972-1

Fixed.

]]> RO-LEAH-1972-1: comment by Sean Nash "Done." Wed, 22 Jan 2025 10:43:40 -0800 Sean Nash https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21069 https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21069 Sean Nash replied to Vinayakam Mani in RO-LEAH-1972-1

Done.

]]> RO-LEAH-1972-1: comment by Sean Nash "Pressure sensor temps to stay with pressure as ..." Wed, 22 Jan 2025 10:31:20 -0800 Sean Nash https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21067 https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21067 Sean Nash replied to Vinayakam Mani in RO-LEAH-1972-1

Pressure sensor temps to stay with pressure as these temps do not have their own component designator on the flow path.

]]> RO-LEAH-1972-1: comment by Sean Nash "Done." Wed, 22 Jan 2025 10:37:08 -0800 Sean Nash https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21068 https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21068 Sean Nash replied to Vinayakam Mani in RO-LEAH-1972-1

Done.

]]> RO-LEAH-1972-1: comment by Sean Nash "Done." Wed, 22 Jan 2025 10:30:58 -0800 Sean Nash https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21065 https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21065 Sean Nash replied to Vinayakam Mani in RO-LEAH-1972-1

Done.

]]> RO-LEAH-1972-1: comment by Vinayakam Mani "Please update the naming order." Wed, 22 Jan 2025 10:10:21 -0800 Vinayakam Mani https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21064 https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21064 Vinayakam Mani commented on RO-LEAH-1972-1

Please update the naming order.

]]> RO-LEAH-1972-1: comment by Vinayakam Mani "Do we need to move this to temperature.c (like ..." Wed, 22 Jan 2025 10:07:31 -0800 Vinayakam Mani https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21063 https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21063 Vinayakam Mani commented on RO-LEAH-1972-1

Do we need to move this to temperature.c (like you moved it for flow sensor). We have temperature for Pressure and conductivity sensors. do we all need to move to one location?

]]> RO-LEAH-1972-1: comment by Vinayakam Mani "Please update the component ID first, followed ..." Wed, 22 Jan 2025 10:04:21 -0800 Vinayakam Mani https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21062 https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21062 Vinayakam Mani commented on RO-LEAH-1972-1

Please update the component ID first, followed by sensor name (for both temperature and pressure).

]]> RO-LEAH-1972-1: comment by Sean Nash "Fixed." Wed, 22 Jan 2025 10:03:17 -0800 Sean Nash https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21061 https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21061 Sean Nash replied to Vinayakam Mani in RO-LEAH-1972-1

Fixed.

]]> RO-LEAH-1972-1: comment by Vinayakam Mani "Needs to be cleaned up for RO." Wed, 22 Jan 2025 10:01:41 -0800 Vinayakam Mani https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21060 https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21060 Vinayakam Mani commented on RO-LEAH-1972-1

Needs to be cleaned up for RO.

]]> RO-LEAH-1972-1: comment by Vinayakam Mani "RO floater" Wed, 22 Jan 2025 09:59:51 -0800 Vinayakam Mani https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21059 https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21059 Vinayakam Mani commented on RO-LEAH-1972-1

RO floater

]]> RO-LEAH-1972-1: comment by Vinayakam Mani "Just to be consistent, can we change it to p7Fl..." Wed, 22 Jan 2025 09:57:41 -0800 Vinayakam Mani https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21058 https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21058 Vinayakam Mani commented on RO-LEAH-1972-1

Just to be consistent, can we change it to p7Flow (instead of FlowP7)? same for P16flow.

]]> RO-LEAH-1972-1: comment by Vinayakam Mani "Index needs to be updated per latest changes." Wed, 22 Jan 2025 09:54:01 -0800 Vinayakam Mani https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21056 https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21056 Vinayakam Mani commented on RO-LEAH-1972-1

Index needs to be updated per latest changes.

]]> RO-LEAH-1972-1: comment by Vinayakam Mani "This need to be cleaned up for RO." Wed, 22 Jan 2025 09:48:20 -0800 Vinayakam Mani https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21055 https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21055 Vinayakam Mani commented on RO-LEAH-1972-1

This need to be cleaned up for RO.

]]> RO-LEAH-1972-1: comment by Vinayakam Mani "I guess this need to be cleaned up for RO." Wed, 22 Jan 2025 09:42:19 -0800 Vinayakam Mani https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21054 https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21054 Vinayakam Mani commented on RO-LEAH-1972-1

I guess this need to be cleaned up for RO.

]]> RO-LEAH-1972-1: comment by Vinayakam Mani "CPI, CPO to be referred as P9 and P18? when th..." Wed, 22 Jan 2025 09:39:00 -0800 Vinayakam Mani https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21053 https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21053 Vinayakam Mani commented on RO-LEAH-1972-1

CPI, CPO to be referred as P9 and P18? when the code is uncommented, there is a possibility of leaving CPI/CPO as it is.

]]> RO-LEAH-1972-1: comment by Vinayakam Mani "Please update 'ropump' as 'P12Pump' and 'bstPum..." Wed, 22 Jan 2025 09:34:00 -0800 Vinayakam Mani https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21052 https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21052 Vinayakam Mani commented on RO-LEAH-1972-1

Please update 'ropump' as 'P12Pump' and 'bstPump' as 'P40Pump'.

]]> RO-LEAH-1972-1: comment by Sean Nash "Fixed." Thu, 16 Jan 2025 14:33:54 -0800 Sean Nash https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21050 https://devapps.diality.us/cru/RO-LEAH-1972-1/#c21050 Sean Nash replied to Vinayakam Mani in RO-LEAH-1972-1

Fixed.

]]>