Fisheye on ro-firmware/firmware/App/Tasks/TaskTimer.h https://devapps.diality.us/changelog/~br%3DLEAH-244-fw-ro-background-task/ro-firmware/firmware/App/Tasks/TaskTimer.h Recent activity in "ro-firmware" under directory /firmware/App/Tasks/TaskTimer.h LEAHI-RO-FIRMWARE-LDT-828-1: closed by Michael Garthwaite Wed, 03 Sep 2025 08:52:54 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 Michael Garthwaite Closed LEAHI-RO-FIRMWARE-LDT-828-1 ]]> LEAHI-RO-FIRMWARE-LDT-1242-1: closed by Michael Garthwaite Wed, 03 Sep 2025 08:52:47 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 Michael Garthwaite Closed LEAHI-RO-FIRMWARE-LDT-1242-1 ]]> LEAHI-RO-FIRMWARE-LDT-828-1: started by Dara Navaei Tue, 02 Sep 2025 10:03:23 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 Dara Navaei started review LEAHI-RO-FIRMWARE-LDT-828-1 ]]> LEAHI-RO-FIRMWARE-LDT-1242-1: started by Dara Navaei Tue, 02 Sep 2025 10:03:14 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 Dara Navaei started review LEAHI-RO-FIRMWARE-LDT-1242-1 ]]> RO-LEAH-244-1: closed by Dara Navaei Wed, 06 Nov 2024 15:01:49 -0800 Dara Navaei https://devapps.diality.us/cru/RO-LEAH-244-1 https://devapps.diality.us/cru/RO-LEAH-244-1 Dara Navaei Closed RO-LEAH-244-1 ]]> RO-LEAH-244-1: reviewers finished Wed, 06 Nov 2024 15:01:33 -0800 https://devapps.diality.us/cru/RO-LEAH-244-1 https://devapps.diality.us/cru/RO-LEAH-244-1 Sean Nash and Vinayakam Mani finished reviewing RO-LEAH-244-1 RO-LEAH-244_FW RO Background Task ]]> RO-LEAH-244-1: started by Dara Navaei Wed, 06 Nov 2024 14:56:38 -0800 Dara Navaei https://devapps.diality.us/cru/RO-LEAH-244-1 https://devapps.diality.us/cru/RO-LEAH-244-1 Dara Navaei started review RO-LEAH-244-1 ]]> RO-LEAH-244-1: comment by Sean Nash "Will resolve in next branch." Wed, 06 Nov 2024 09:51:53 -0800 Sean Nash https://devapps.diality.us/cru/RO-LEAH-244-1/#c20833 https://devapps.diality.us/cru/RO-LEAH-244-1/#c20833 Sean Nash replied to Sean Nash in RO-LEAH-244-1

Will resolve in next branch.

]]> RO-LEAH-244-1: comment by Sean Nash "Will resolve in next branch." Wed, 06 Nov 2024 09:51:20 -0800 Sean Nash https://devapps.diality.us/cru/RO-LEAH-244-1/#c20832 https://devapps.diality.us/cru/RO-LEAH-244-1/#c20832 Sean Nash replied to Sean Nash in RO-LEAH-244-1

Will resolve in next branch.

]]> RO-LEAH-244-1: comment by Sean Nash "Will resolve in next branch." Wed, 06 Nov 2024 09:51:02 -0800 Sean Nash https://devapps.diality.us/cru/RO-LEAH-244-1/#c20831 https://devapps.diality.us/cru/RO-LEAH-244-1/#c20831 Sean Nash replied to Sean Nash in RO-LEAH-244-1

Will resolve in next branch.

]]> RO-LEAH-244-1: comment by Sean Nash "Will resolve in next branch." Wed, 06 Nov 2024 09:49:56 -0800 Sean Nash https://devapps.diality.us/cru/RO-LEAH-244-1/#c20830 https://devapps.diality.us/cru/RO-LEAH-244-1/#c20830 Sean Nash replied to Dara Navaei in RO-LEAH-244-1

Will resolve in next branch.

]]> RO-LEAH-244-1: comment by Sean Nash "Will add in next branch." Wed, 06 Nov 2024 09:48:49 -0800 Sean Nash https://devapps.diality.us/cru/RO-LEAH-244-1/#c20829 https://devapps.diality.us/cru/RO-LEAH-244-1/#c20829 Sean Nash replied to Sean Nash in RO-LEAH-244-1

Will add in next branch.

]]> RO-LEAH-244-1: comment by Sean Nash "Will resolve in next branch." Wed, 06 Nov 2024 09:48:27 -0800 Sean Nash https://devapps.diality.us/cru/RO-LEAH-244-1/#c20828 https://devapps.diality.us/cru/RO-LEAH-244-1/#c20828 Sean Nash replied to Sean Nash in RO-LEAH-244-1

Will resolve in next branch.

]]> RO-LEAH-244-1: comment by Sean Nash "Will resolve in next branch." Wed, 06 Nov 2024 09:48:07 -0800 Sean Nash https://devapps.diality.us/cru/RO-LEAH-244-1/#c20827 https://devapps.diality.us/cru/RO-LEAH-244-1/#c20827 Sean Nash replied to Sean Nash in RO-LEAH-244-1

Will resolve in next branch.

]]> RO-LEAH-244-1: comment by Sean Nash "Will resolve in next branch." Wed, 06 Nov 2024 09:47:36 -0800 Sean Nash https://devapps.diality.us/cru/RO-LEAH-244-1/#c20826 https://devapps.diality.us/cru/RO-LEAH-244-1/#c20826 Sean Nash replied to Sean Nash in RO-LEAH-244-1

Will resolve in next branch.

]]> RO-LEAH-244-1: comment by Sean Nash "Will resolve in next branch." Wed, 06 Nov 2024 09:46:57 -0800 Sean Nash https://devapps.diality.us/cru/RO-LEAH-244-1/#c20825 https://devapps.diality.us/cru/RO-LEAH-244-1/#c20825 Sean Nash replied to Dara Navaei in RO-LEAH-244-1

Will resolve in next branch.

]]> RO-LEAH-244-1: comment by Sean Nash "Referring to RO alarms as RO here. In properti..." Wed, 06 Nov 2024 09:45:59 -0800 Sean Nash https://devapps.diality.us/cru/RO-LEAH-244-1/#c20824 https://devapps.diality.us/cru/RO-LEAH-244-1/#c20824 Sean Nash replied to Vinayakam Mani in RO-LEAH-244-1

Referring to RO alarms as RO here. In properties table, RO faults will be marked as DD faults (from TD perspective, they kind of are DD faults).

]]> RO-LEAH-244-1: comment by Sean Nash "Fixed." Wed, 06 Nov 2024 09:40:39 -0800 Sean Nash https://devapps.diality.us/cru/RO-LEAH-244-1/#c20823 https://devapps.diality.us/cru/RO-LEAH-244-1/#c20823 Sean Nash replied to Dara Navaei in RO-LEAH-244-1

Fixed.

]]> RO-LEAH-244-1: comment by Sean Nash "Removed." Wed, 06 Nov 2024 09:35:37 -0800 Sean Nash https://devapps.diality.us/cru/RO-LEAH-244-1/#c20822 https://devapps.diality.us/cru/RO-LEAH-244-1/#c20822 Sean Nash replied to Vinayakam Mani in RO-LEAH-244-1

Removed.

]]> RO-LEAH-244-1: comment by Sean Nash "Fixed." Wed, 06 Nov 2024 09:34:15 -0800 Sean Nash https://devapps.diality.us/cru/RO-LEAH-244-1/#c20821 https://devapps.diality.us/cru/RO-LEAH-244-1/#c20821 Sean Nash replied to Vinayakam Mani in RO-LEAH-244-1

Fixed.

]]> RO-LEAH-244-1: comment by Sean Nash "I haven't done op mode override handler in TD y..." Tue, 05 Nov 2024 10:38:42 -0800 Sean Nash https://devapps.diality.us/cru/RO-LEAH-244-1/#c20819 https://devapps.diality.us/cru/RO-LEAH-244-1/#c20819 Sean Nash replied to Dara Navaei in RO-LEAH-244-1

I haven't done op mode override handler in TD yet so I don't think that is true.

]]> RO-LEAH-244-1: comment by Vinayakam Mani "Looks Macro still naming DG." Tue, 05 Nov 2024 10:37:19 -0800 Vinayakam Mani https://devapps.diality.us/cru/RO-LEAH-244-1/#c20818 https://devapps.diality.us/cru/RO-LEAH-244-1/#c20818 Vinayakam Mani replied to Dara Navaei in RO-LEAH-244-1

Looks Macro still naming DG.

]]> ro-firmware (LDT-332-basic-dialysis-treatment-fp-UIT): LEAH-244 addressed the code review comments Tue, 05 Nov 2024 10:10:34 -0800 Dara Navaei https://devapps.diality.us/changelog/ro-firmware?cs=129a1c2f4343bc85efdb4767c2dec35e4ba8ce98 https://devapps.diality.us/changelog/ro-firmware?cs=129a1c2f4343bc85efdb4767c2dec35e4ba8ce98 Dara Navaei committed 129a1c2 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 17 more in ro-firmware LEAH-244 addressed the code review comments

· /firmware/App/Drivers/InternalADC.c (-27, +15) | History | Source | Diff
· /firmware/App/Drivers/InternalADC.h (-8, +2) | History | Source | Diff
· /firmware/App/Drivers/PAL.h (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/SafetyShutdown.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFault.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFault.h (-4, +4) | History | Source | Diff
· /firmware/App/Modes/ModeInitPOST.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/OperationModes.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtRO.c (-7, +5) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtRO.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h (-2, +5) | History | Source | Diff
· /firmware/App/Services/FpgaRO.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/FpgaRO.h (-5, +5) | History | Source | Diff
· /firmware/App/Services/Interrupts.c (-31, +5) | History | Source | Diff
… 12 more files in changeset.
]]> RO-LEAH-244-1: comment by Dara Navaei "Done" Tue, 05 Nov 2024 10:07:58 -0800 Dara Navaei https://devapps.diality.us/cru/RO-LEAH-244-1/#c20817 https://devapps.diality.us/cru/RO-LEAH-244-1/#c20817 Dara Navaei replied to Sean Nash in RO-LEAH-244-1

Done

]]> RO-LEAH-244-1: comment by Dara Navaei "Removed them." Tue, 05 Nov 2024 10:04:53 -0800 Dara Navaei https://devapps.diality.us/cru/RO-LEAH-244-1/#c20816 https://devapps.diality.us/cru/RO-LEAH-244-1/#c20816 Dara Navaei replied to Vinayakam Mani in RO-LEAH-244-1

Removed them.

]]> RO-LEAH-244-1: comment by Dara Navaei "Removed them." Tue, 05 Nov 2024 10:04:47 -0800 Dara Navaei https://devapps.diality.us/cru/RO-LEAH-244-1/#c20815 https://devapps.diality.us/cru/RO-LEAH-244-1/#c20815 Dara Navaei replied to Vinayakam Mani in RO-LEAH-244-1

Removed them.

]]> RO-LEAH-244-1: comment by Dara Navaei "Removed them." Tue, 05 Nov 2024 10:04:36 -0800 Dara Navaei https://devapps.diality.us/cru/RO-LEAH-244-1/#c20814 https://devapps.diality.us/cru/RO-LEAH-244-1/#c20814 Dara Navaei replied to Vinayakam Mani in RO-LEAH-244-1

Removed them.

]]> RO-LEAH-244-1: comment by Dara Navaei "Remove them." Tue, 05 Nov 2024 10:03:47 -0800 Dara Navaei https://devapps.diality.us/cru/RO-LEAH-244-1/#c20813 https://devapps.diality.us/cru/RO-LEAH-244-1/#c20813 Dara Navaei replied to Vinayakam Mani in RO-LEAH-244-1

Remove them.

]]> RO-LEAH-244-1: comment by Dara Navaei "Removed them." Tue, 05 Nov 2024 10:03:23 -0800 Dara Navaei https://devapps.diality.us/cru/RO-LEAH-244-1/#c20812 https://devapps.diality.us/cru/RO-LEAH-244-1/#c20812 Dara Navaei replied to Vinayakam Mani in RO-LEAH-244-1

Removed them.

]]> RO-LEAH-244-1: comment by Dara Navaei "Done" Tue, 05 Nov 2024 09:47:47 -0800 Dara Navaei https://devapps.diality.us/cru/RO-LEAH-244-1/#c20811 https://devapps.diality.us/cru/RO-LEAH-244-1/#c20811 Dara Navaei replied to Sean Nash in RO-LEAH-244-1

Done

]]>