Fisheye on hdfirmware/firmware/App

hdfirmware (DEN-16693-institutional-settings-implementation-2): STT-1965 Update per code review comments

Fri, 25 Aug 2023 13:15:41 -0700

Bill Bracken committed d07e8c7 on branch master, DEN-14706-can-messge-not-acked-fix and 139 more in hdfirmware

STT-1965 Update per code review comments

· /firmware/App/Drivers/Battery.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): STT-1965 Allow reset of override state in getI2CStatusRegister

Fri, 25 Aug 2023 10:27:43 -0700

Bill Bracken committed a3e085b on branch master, DEN-14706-can-messge-not-acked-fix and 139 more in hdfirmware

STT-1965 Allow reset of override state in getI2CStatusRegister

· /firmware/App/Drivers/Battery.c

(-6, +10)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): STT-1965 batteryI2CStatusRegister overide now reasets when value is read and is in an overriden state.

Thu, 24 Aug 2023 16:03:30 -0700

Bill Bracken committed c008c3f on branch master, DEN-14706-can-messge-not-acked-fix and 139 more in hdfirmware

STT-1965 batteryI2CStatusRegister overide now reasets when value is read and is in an overriden state.

· /firmware/App/Drivers/Battery.c

(-2, +4)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Thu, 24 Aug 2023 15:49:43 -0700

Dara Navaei committed 4eaa890 on branch master, DEN-14706-can-messge-not-acked-fix and 141 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 24 Aug 2023 15:49:27 -0700

Dara Navaei committed dd8d00b on branch master, DEN-14706-can-messge-not-acked-fix and 141 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/BloodLeak.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DGInterface.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DGInterface.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/SyringePump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Temperatures.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/HDCommon.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeInitPOST.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePostTreat.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DENBUG-59: Fixed merge conflict.

Sean Nash — Thu, 24 Aug 2023 10:53:53 -0700

Sean Nash committed 4d0c621 on branch master, DEN-14706-can-messge-not-acked-fix and 141 more in hdfirmware

DENBUG-59: Fixed merge conflict.

· /firmware/App/Controllers/BloodFlow.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/BloodLeak.c	(-10, +9)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DGInterface.c	(-6, +7)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/SyringePump.c	(-3, +18)	\| History	\| Source	\| Diff
· /firmware/App/HDCommon.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePostTreat.c	(-1, +27)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.c	(-5, +12)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-4, +120)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DENBUG-59: Fixed rinseback resume after HD fluid leak alarm issue.

Sean Nash — Wed, 23 Aug 2023 14:38:09 -0700

Sean Nash committed aa89a11 on branch master, DEN-14706-can-messge-not-acked-fix and 141 more in hdfirmware

DENBUG-59: Fixed rinseback resume after HD fluid leak alarm issue.

· /firmware/App/Modes/Rinseback.c

(-9, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Wed, 23 Aug 2023 10:06:20 -0700

Dara Navaei committed 6d7cc06 on branch master, DEN-14706-can-messge-not-acked-fix and 141 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 23 Aug 2023 10:06:11 -0700

Dara Navaei committed d611c5e on branch master, DEN-14706-can-messge-not-acked-fix and 141 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DialOutFlow.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Tue, 22 Aug 2023 16:11:05 -0700

Dara Navaei committed 7dc9e63 on branch master, DEN-14706-can-messge-not-acked-fix and 143 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 22 Aug 2023 16:10:57 -0700

Dara Navaei committed d1734c8 on branch master, DEN-14706-can-messge-not-acked-fix and 143 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Services/SystemCommMessages.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Merge remote-tracking branch 'origin/staging' into staging

Tue, 22 Aug 2023 16:07:30 -0700

Bill Bracken committed 502d4e7 on branch master, DEN-14706-can-messge-not-acked-fix and 143 more in hdfirmware

Merge remote-tracking branch 'origin/staging' into staging

· /firmware/App/Services/SystemCommMessages.c

(-1, +33)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16203: code review comments

Michael Garthwaite — Tue, 22 Aug 2023 13:31:02 -0700

Michael Garthwaite committed 650235d on branch master, DEN-14706-can-messge-not-acked-fix and 142 more in hdfirmware

DEN-16203: code review comments

· /firmware/App/Controllers/DialOutFlow.c

(-1, +0)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16203: changed dopMeasuredRate to handle set flow rate in open loop state.

Michael Garthwaite — Tue, 22 Aug 2023 10:15:49 -0700

Michael Garthwaite committed 940fffc on branch master, DEN-14706-can-messge-not-acked-fix and 142 more in hdfirmware

DEN-16203: changed dopMeasuredRate to handle set flow rate in open loop state.

· /firmware/App/Controllers/DialOutFlow.c

(-3, +11)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Mon, 21 Aug 2023 12:36:56 -0700

Dara Navaei committed af5ac96 on branch master, DEN-14706-can-messge-not-acked-fix and 143 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 21 Aug 2023 12:36:48 -0700

Dara Navaei committed edd2e65 on branch master, DEN-14706-can-messge-not-acked-fix and 143 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16245 Valve override valide for both RELEASE and DEBUG

Mon, 21 Aug 2023 11:06:39 -0700

Bill Bracken committed ecbca18 on branch master, DEN-14706-can-messge-not-acked-fix and 144 more in hdfirmware

DEN-16245 Valve override valide for both RELEASE and DEBUG

· /firmware/App/Services/SystemCommMessages.c

(-2, +0)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Fri, 18 Aug 2023 16:45:54 -0700

Dara Navaei committed 1369d81 on branch master, DEN-14706-can-messge-not-acked-fix and 147 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 18 Aug 2023 16:45:47 -0700

Dara Navaei committed 92d7088 on branch master, DEN-14706-can-messge-not-acked-fix and 147 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/Prime.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DENBUG-59: Fixed expected msg payload length for a trigger alarm msg.

Sean Nash — Fri, 18 Aug 2023 13:27:13 -0700

Sean Nash committed 24c447c on branch master, DEN-14706-can-messge-not-acked-fix and 141 more in hdfirmware

DENBUG-59: Fixed expected msg payload length for a trigger alarm msg.

· /firmware/App/Services/SystemCommMessages.c

(-16, +13)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-14706: code review comments.

Michael Garthwaite — Fri, 18 Aug 2023 10:44:55 -0700

Michael Garthwaite committed 8c54458 on branch master, DEN-14706-can-messge-not-acked-fix and 144 more in hdfirmware

DEN-14706: code review comments.

· /firmware/App/Services/SystemComm.c

(-1, +0)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-14706: changed override condition for pending ack

Michael Garthwaite — Fri, 18 Aug 2023 10:42:25 -0700

Michael Garthwaite committed 2512d50 on branch master, DEN-14706-can-messge-not-acked-fix and 144 more in hdfirmware

DEN-14706: changed override condition for pending ack

· /firmware/App/Services/SystemComm.c

(-2, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DENBUG-59: Updated post-tx logic to handle recovery of ac power during reservoir drain per DEN-15763.

Sean Nash — Fri, 18 Aug 2023 09:10:40 -0700

Sean Nash committed dcfa6a5 on branch master, DEN-14706-can-messge-not-acked-fix and 141 more in hdfirmware

DENBUG-59: Updated post-tx logic to handle recovery of ac power during reservoir drain per DEN-15763.

· /firmware/App/Modes/ModePostTreat.c

(-10, +14)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16278-hd-pretreatment-prime-start-state-does-not-allow-pause...

Fri, 18 Aug 2023 09:01:46 -0700

James Walter Taylor committed f66b4b2 on branch master, DEN-14706-can-messge-not-acked-fix and 148 more in hdfirmware

DEN-16278-hd-pretreatment-prime-start-state-does-not-allow-pause

Added pause/stop property detection in start state.

· /firmware/App/Modes/Prime.c

(-2, +6)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16164: Removed reservoir weight check in fill settle state

Michael Garthwaite — Fri, 18 Aug 2023 08:00:14 -0700

Michael Garthwaite committed 21212f3 on branch master, DEN-14706-can-messge-not-acked-fix and 142 more in hdfirmware

DEN-16164: Removed reservoir weight check in fill settle state

· /firmware/App/Services/Reservoirs.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-14706: HD pending ACK override message handling and implementation.

Michael Garthwaite — Thu, 17 Aug 2023 18:45:37 -0700

Michael Garthwaite committed 97a93f3 on branch master, DEN-14706-can-messge-not-acked-fix and 144 more in hdfirmware

DEN-14706: HD pending ACK override message handling and implementation.

· /firmware/App/Services/SystemComm.c	(-3, +64)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.h	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +32)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +3)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16164: code review comments.

Michael Garthwaite — Thu, 17 Aug 2023 14:21:43 -0700

Michael Garthwaite committed 56551a8 on branch master, DEN-14706-can-messge-not-acked-fix and 142 more in hdfirmware

DEN-16164: code review comments.

· /firmware/App/Modes/SelfTests.c

(-3, +3)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16164: compiler fixes.

Michael Garthwaite — Thu, 17 Aug 2023 12:54:35 -0700

Michael Garthwaite committed 8ba790d on branch master, DEN-14706-can-messge-not-acked-fix and 142 more in hdfirmware

DEN-16164: compiler fixes.

· /firmware/App/Modes/SelfTests.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16164: Code review comments. Changed stop state for handle all alarms for depressurized Inverse logic for setting VB...

Michael Garthwaite — Thu, 17 Aug 2023 11:28:37 -0700

Michael Garthwaite committed 0dafd72 on branch master, DEN-14706-can-messge-not-acked-fix and 142 more in hdfirmware

DEN-16164: Code review comments. Changed stop state for handle all alarms for depressurized Inverse logic for setting VBA to Pos B during dry self test failures and ensure HD only does it during dry self test.

· /firmware/App/Modes/SelfTests.c

(-8, +11)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Thu, 17 Aug 2023 10:58:39 -0700

Dara Navaei committed 0b3059f on branch master, DEN-14706-can-messge-not-acked-fix and 150 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff