Fisheye on hdfirmware/firmware/App/Controllers/DialOutFlow.c https://devapps.diality.us/changelog/~br%3Dbugfix%25402fDEN-16391-fw-dialysate-temperature-alarm-not-sensitive-enough-use-tdi-moving-avg/hdfirmware/firmware/App/Controllers/DialOutFlow.c Recent activity in "hdfirmware" under directory /firmware/App/Controllers/DialOutFlow.c HD-DENBUG-104-1: closed by Sean Nash Mon, 26 Feb 2024 15:44:42 -0800 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-104-1 https://devapps.diality.us/cru/HD-DENBUG-104-1 Sean Nash Closed HD-DENBUG-104-1 ]]> HD-DENBUG-104-2: closed by Sean Nash Mon, 26 Feb 2024 15:44:32 -0800 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-104-2 https://devapps.diality.us/cru/HD-DENBUG-104-2 Sean Nash Closed HD-DENBUG-104-2 ]]> HD-DENBUG-104-2: reviewers finished Mon, 26 Feb 2024 15:13:16 -0800 https://devapps.diality.us/cru/HD-DENBUG-104-2 https://devapps.diality.us/cru/HD-DENBUG-104-2 Michael Garthwaite and Vinayakam Mani finished reviewing HD-DENBUG-104-2 HD-DENBUG-104_Alarm 38 HD Fault Dpi Rotor T ]]> HD-DENBUG-104-1: reviewers finished Mon, 26 Feb 2024 15:12:51 -0800 https://devapps.diality.us/cru/HD-DENBUG-104-1 https://devapps.diality.us/cru/HD-DENBUG-104-1 Michael Garthwaite and Vinayakam Mani finished reviewing HD-DENBUG-104-1 HD-DENBUG-104_Alarm 38 HD Fault Dpi Rotor T ]]> HD-DENBUG-104-2: started by Dara Navaei Fri, 23 Feb 2024 14:50:28 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DENBUG-104-2 https://devapps.diality.us/cru/HD-DENBUG-104-2 Dara Navaei started review HD-DENBUG-104-2 ]]> HD-DENBUG-104-1: started by Dara Navaei Fri, 23 Feb 2024 14:50:19 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DENBUG-104-1 https://devapps.diality.us/cru/HD-DENBUG-104-1 Dara Navaei started review HD-DENBUG-104-1 ]]> HD-DEN-16518-2: closed by Vinayakam Mani Tue, 16 Jan 2024 16:29:34 -0800 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16518-2 https://devapps.diality.us/cru/HD-DEN-16518-2 Vinayakam Mani Closed HD-DEN-16518-2 ]]> HD-DEN-16518-2: reviewers finished Mon, 15 Jan 2024 16:16:01 -0800 https://devapps.diality.us/cru/HD-DEN-16518-2 https://devapps.diality.us/cru/HD-DEN-16518-2 Sean Nash and Michael Garthwaite finished reviewing HD-DEN-16518-2 HD-DEN-16518_Alarm 41 Triggered ON Dvt 014 AT The Beginning OF Treatment ]]> HD-DEN-16518-1: closed by Vinayakam Mani Mon, 15 Jan 2024 12:05:25 -0800 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16518-1 https://devapps.diality.us/cru/HD-DEN-16518-1 Vinayakam Mani Closed HD-DEN-16518-1 ]]> HD-DEN-16518-2: started by Dara Navaei Mon, 15 Jan 2024 12:00:36 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16518-2 https://devapps.diality.us/cru/HD-DEN-16518-2 Dara Navaei started review HD-DEN-16518-2 ]]> HD-DEN-16518-1: reviewers finished Mon, 15 Jan 2024 11:10:23 -0800 https://devapps.diality.us/cru/HD-DEN-16518-1 https://devapps.diality.us/cru/HD-DEN-16518-1 Michael Garthwaite and Sean Nash finished reviewing HD-DEN-16518-1 HD-DEN-16518_Alarm 41 Triggered ON Dvt 014 AT The Beginning OF Treatment ]]> HD-DEN-16518-1: comment by Michael Garthwaite "RESOLVED IN CODE WALKTHROUGH." Mon, 15 Jan 2024 11:10:04 -0800 Michael Garthwaite https://devapps.diality.us/cru/HD-DEN-16518-1/#c19349 https://devapps.diality.us/cru/HD-DEN-16518-1/#c19349 Michael Garthwaite replied to Vinayakam Mani in HD-DEN-16518-1

RESOLVED IN CODE WALKTHROUGH.

]]> HD-DEN-16518-1: comment by Vinayakam Mani "Updated code changes. Open loop still maintains..." Mon, 15 Jan 2024 11:04:07 -0800 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16518-1/#c19348 https://devapps.diality.us/cru/HD-DEN-16518-1/#c19348 Vinayakam Mani replied to Vinayakam Mani in HD-DEN-16518-1

Updated code changes. Open loop still maintains the minimum PWM duty cycle as 10%.

]]> HD-DEN-16518-1: comment by Vinayakam Mani "Updated code changes. Open loop still maintains..." Mon, 15 Jan 2024 11:01:44 -0800 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16518-1/#c19347 https://devapps.diality.us/cru/HD-DEN-16518-1/#c19347 Vinayakam Mani replied to Michael Garthwaite in HD-DEN-16518-1

Updated code changes. Open loop still maintains the minimum PWM duty cycle as 10%.

]]> HD-DEN-16518-1: comment by Sean Nash "Do we want to have the 11% minimum here? I tho..." Mon, 15 Jan 2024 10:42:25 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16518-1/#c19346 https://devapps.diality.us/cru/HD-DEN-16518-1/#c19346 Sean Nash replied to Michael Garthwaite in HD-DEN-16518-1

Do we want to have the 11% minimum here? I thought it was just for closed loop control.

]]> HD-DEN-16518-1: comment by Michael Garthwaite "This will cause open loop control mode to have ..." Mon, 15 Jan 2024 10:25:37 -0800 Michael Garthwaite https://devapps.diality.us/cru/HD-DEN-16518-1/#c19345 https://devapps.diality.us/cru/HD-DEN-16518-1/#c19345 Michael Garthwaite commented on HD-DEN-16518-1

This will cause open loop control mode to have a minimum of 11% instead of 10%. For open loop, pwmDC is assigned a value at line 295. Do we still need the #define for the 10% pwm lower limit?

]]> HD-DEN-16518-1: started by Dara Navaei Wed, 03 Jan 2024 12:00:58 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16518-1 https://devapps.diality.us/cru/HD-DEN-16518-1 Dara Navaei started review HD-DEN-16518-1 ]]> HD-DEN-16512-2: closed by Vinayakam Mani Mon, 18 Dec 2023 10:24:33 -0800 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16512-2 https://devapps.diality.us/cru/HD-DEN-16512-2 Vinayakam Mani Closed HD-DEN-16512-2 ]]> HD-DEN-16512-2: reviewers finished Mon, 18 Dec 2023 09:51:51 -0800 https://devapps.diality.us/cru/HD-DEN-16512-2 https://devapps.diality.us/cru/HD-DEN-16512-2 Sean Nash and Dara Navaei finished reviewing HD-DEN-16512-2 HD-DEN-16512_Dpo Stops During Treatment After Reconfirming Dialysate Flow Rate ]]> hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Mon, 18 Dec 2023 09:43:23 -0800 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=8c7e0b560084c2d8141b10e7c442697fca21bde9 https://devapps.diality.us/changelog/hdfirmware?cs=8c7e0b560084c2d8141b10e7c442697fca21bde9 Dara Navaei committed 8c7e0b5 on branch master, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2 and 58 more in hdfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DialOutFlow.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/DialOutFlow.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/Dialysis.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/Dialysis.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeTreatment.c (-1, +1) | History | Source | Diff
]]> HD-DEN-16512-1: closed by Dara Navaei Sun, 17 Dec 2023 15:54:13 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16512-1 https://devapps.diality.us/cru/HD-DEN-16512-1 Dara Navaei Closed HD-DEN-16512-1 ]]> HD-DEN-16512-2: started by Dara Navaei Fri, 15 Dec 2023 11:55:51 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16512-2 https://devapps.diality.us/cru/HD-DEN-16512-2 Dara Navaei started review HD-DEN-16512-2 ]]> HD-DEN-16512-1: reviewers finished Thu, 14 Dec 2023 13:10:40 -0800 https://devapps.diality.us/cru/HD-DEN-16512-1 https://devapps.diality.us/cru/HD-DEN-16512-1 Dara Navaei finished reviewing HD-DEN-16512-1 HD-DEN-16512_Dpo Stops During Treatment After Reconfirming Dialysate Flow Rate ]]> HD-DEN-16512-1: reviewers finished Thu, 07 Dec 2023 09:44:37 -0800 https://devapps.diality.us/cru/HD-DEN-16512-1 https://devapps.diality.us/cru/HD-DEN-16512-1 Sean Nash finished reviewing HD-DEN-16512-1 HD-DEN-16512_Dpo Stops During Treatment After Reconfirming Dialysate Flow Rate ]]> HD-DEN-16512-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 07 Dec 2023 09:41:09 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16512-1/#c19304 https://devapps.diality.us/cru/HD-DEN-16512-1/#c19304 Sean Nash replied to Vinayakam Mani in HD-DEN-16512-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16512-1: comment by Vinayakam Mani "Done." Wed, 06 Dec 2023 16:05:03 -0800 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16512-1/#c19303 https://devapps.diality.us/cru/HD-DEN-16512-1/#c19303 Vinayakam Mani replied to Sean Nash in HD-DEN-16512-1

Done.

]]> HD-DEN-16512-1: reviewers resumed Wed, 06 Dec 2023 15:42:53 -0800 https://devapps.diality.us/cru/HD-DEN-16512-1 https://devapps.diality.us/cru/HD-DEN-16512-1 jtaylor  (deleted user) resumed reviewing HD-DEN-16512-1 HD-DEN-16512_Dpo Stops During Treatment After Reconfirming Dialysate Flow Rate ]]> HD-DEN-16512-1: comment by Sean Nash "Consider splitting this if and the setDialysisP..." Mon, 04 Dec 2023 14:22:47 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16512-1/#c19302 https://devapps.diality.us/cru/HD-DEN-16512-1/#c19302 Sean Nash commented on HD-DEN-16512-1

Consider splitting this if and the setDialysisParams() function into two: 1) blood flow rate changed and 2) dialysate flow rate changed.

]]> HD-DEN-16512-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 28 Nov 2023 09:25:29 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16512-1/#c19283 https://devapps.diality.us/cru/HD-DEN-16512-1/#c19283 Sean Nash replied to Vinayakam Mani in HD-DEN-16512-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16512-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 28 Nov 2023 09:24:08 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16512-1/#c19282 https://devapps.diality.us/cru/HD-DEN-16512-1/#c19282 Sean Nash replied to Vinayakam Mani in HD-DEN-16512-1

RESOLVED in CODE WALKTHROUGH.

]]>