The approach of what this code does and the conversion module are similar in function but a differ on maintenance and flexibility.
1. The conversion module's bytearray to value methods work, but they require manual logistic around the indexing. It's the user's responsibility to handle where the reading starts and you need to code the handler for that (previous approach with MsgFieldPositions), It's inflating the method. I worked hard to remove the need for indexing where the value starts. Instead of the previous struct.unpack approach, where you needed to maintain the type, you will be needing to maintain the conversion methods that are being called, so it would be the same as before, you still need to mind the indexing, which was the main reason of changing from this approach.

2. In the current approach, you declare the type and pass it to a processor that dynamically handling the unpack type (based on the set datatype) and the indexing for that. This works much better and easier to maintain, as you can just insert a new value when it's added to the FW, and don't need to adjust all your indexes for the reading.

Example #1, changing build type from U16 to U08:

• with the conversion approach, you need to change the function used, and update the starting index for all the following methods.
• with the current approach you change the Datatype.U16 to Datatype.U08 and that's all you need to do.

Example #2: adding a new variable fpga_micro after fpga_minor, with U08 type:

• with the conversion approach, you add the bytearray_to_byte, update the indexes for all the following reads.
• with the current approach you insert an element after the fpga_minor with a value ('fpga_micro', Datatype.U08), and nothing more needed

fixed. thanks!

fixed. thanks

Add uncompensated conductivity to the init too

Add uncompensated conductivity to the init too

RESOLVED for now.

I would not do that because the function names and messages for each project should be different to avoid confusion.
I think that is fine for now.

RESOLVED.

even though we are sending U08 at Firmware. Due to structure padding Raw message for priority is converted as 16 bits. While receiving we need to read them as U16. Here is my debug values [CortexR4] ALARM_PROP_T size = 22 bytes
byte[0] = 0x03
byte[1] = 0x00
byte[2] = 0x6F
byte[3] = 0x00
byte[4] = 0x01
byte[5] = 0x00
byte[6] = 0x00
byte[7] = 0x01
byte[8] = 0x00
byte[9] = 0x00
byte[10] = 0x01
byte[11] = 0x00
byte[12] = 0x00
byte[13] = 0x01
byte[14] = 0x00
byte[15] = 0x00
byte[16] = 0x01
byte[17] = 0x00
byte[18] = 0x00
byte[19] = 0x01
byte[20] = 0x0A
byte[21] = 0x00

This is structure defined at firmware side
struct AlarmTableRequestPayload

;
typedef struct AlarmTableRequestPayload ALARM_PROP_T;

So the same channels are used for both the Leahi and Denali?
I am not talking about how collisions are handled; that is handled by the CAN driver, not the FW or SW.
My point is that the CAN Channels by themselves do not have the meaning we want; they are only a priority.
As we defined them, we gave them a meaning as a category; therefore, it is better to name them the Denali/Leahi Channels rather than the CAN Channels.

RESOLVED.

No, that will cause an error on pip

Please leave a comment to remind the developers that "-" will confuse .whl.

Should this be "." instead of "-" to be consistent?

Is this .wsl or .whl?

FW sends U16 for now, after it's changed to U08, this will be updated

I pushed the changes, no idea why it's not present here

· /build.sh	(-0, +1)	| History	| Source	| Diff
· /leahi_dialin/version.py	(-1, +1)	| History	| Source	| Diff

]]> Tue, 30 Jun 2026 16:56:16 -0700 Behrouz NematiPour https://devapps.diality.us/changelog/leahi-dialin?cs=c4950bcf4b6655fa936422534d21d9210f406e0a https://devapps.diality.us/changelog/leahi-dialin?cs=c4950bcf4b6655fa936422534d21d9210f406e0a Behrouz NematiPour committed c4950bc on branch LDT-4505, LDT-4614-dialysate-composition-mixing-algo-integration-with-td-proxy and 5 more in leahi-dialin Merge branch 'feature/LDT-4787-enhancement-power-off' into staging

]]> Tue, 30 Jun 2026 16:28:33 -0700 Behrouz NematiPour https://devapps.diality.us/changelog/leahi-dialin?cs=99518dc1e66a13cb913f1ff51967e3cfe4ce6df0 https://devapps.diality.us/changelog/leahi-dialin?cs=99518dc1e66a13cb913f1ff51967e3cfe4ce6df0 Behrouz NematiPour committed 99518dc on branch LDT-4505, LDT-4614-dialysate-composition-mixing-algo-integration-with-td-proxy and 5 more in leahi-dialin Merge branch 'feature/LDT-4747-fp-diagnostics' into staging

]]> Tue, 30 Jun 2026 14:57:25 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4160-1/#c30238 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4160-1/#c30238 Vinayakam Mani commented on LEAHI-DIALIN-LDT-4160-1

Priority data type is U08?