Fisheye on leahi-dialin/leahi_dialin

LEAHI-DIALIN-LDT-4787-1: closed by Nicholas Ramirez

Nicholas Ramirez — Thu, 02 Jul 2026 15:39:35 -0700

Nicholas Ramirez Closed LEAHI-DIALIN-LDT-4787-1

LEAHI-DIALIN-LDT-4787-1: reviewers finished

Thu, 02 Jul 2026 15:38:23 -0700

Behrouz NematiPour and Stephen Quong finished reviewing LEAHI-DIALIN-LDT-4787-1

LEAHI-DIALIN-LDT-4787_NON-FEATURE: SW Misc & Enhc - SW - 01 - Power Control - Shutdown - R&I

LEAHI-DIALIN-LDT-4787-1: comment by Nicholas Ramirez "bn approves"

Nicholas Ramirez — Thu, 02 Jul 2026 15:36:14 -0700

Nicholas Ramirez replied to Nicholas Ramirez in LEAHI-DIALIN-LDT-4787-1

bn approves

LEAHI-DIALIN-LDT-4747-1: closed by Nicholas Ramirez

Nicholas Ramirez — Thu, 02 Jul 2026 15:35:22 -0700

Nicholas Ramirez Closed LEAHI-DIALIN-LDT-4747-1

LEAHI-DIALIN-LDT-4747-1: reviewers finished

Thu, 02 Jul 2026 15:31:13 -0700

Stephen Quong finished reviewing LEAHI-DIALIN-LDT-4747-1

LDT-4747: SW Integration - FP Diagnostics - DialIn

LEAHI-DIALIN-LDT-4539-1: reviewers finished

Thu, 02 Jul 2026 15:14:05 -0700

Vinayakam Mani finished reviewing LEAHI-DIALIN-LDT-4539-1

LEAHI-DIALIN-LDT-4539_Provide event on Service state change

LEAHI-DIALIN-LDT-4160-1: reviewers finished

Thu, 02 Jul 2026 15:11:45 -0700

Vinayakam Mani finished reviewing LEAHI-DIALIN-LDT-4160-1

LEAHI-DIALIN-LDT-4160_[Request] Get function for full detailed Alarm Table

LEAHI-DIALIN-LDT-4873-1: reviewers finished

Thu, 02 Jul 2026 14:13:44 -0700

Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-4873-1

LEAHI-DIALIN-LDT-4873_(Request) Add config to disable conductive level sensor fault

leahi-dialin (develop): Merge branch 'LDT-4873' into develop

Zoltan Miskolci — Thu, 02 Jul 2026 14:10:27 -0700

Zoltan Miskolci committed 2755d8b on branch develop in leahi-dialin

Merge branch 'LDT-4873' into develop

· /leahi_dialin/common/test_config_defs.py

(-2, +3)

| History

| Source

| Diff

leahi-dialin (develop): Added test config for conductivity alarm

Zoltan Miskolci — Thu, 02 Jul 2026 14:10:00 -0700

Zoltan Miskolci committed f68df23 on branch LDT-4873, develop in leahi-dialin

Added test config for conductivity alarm

· /leahi_dialin/common/test_config_defs.py

(-2, +3)

| History

| Source

| Diff

LEAHI-DIALIN-LDT-4873-1: started by Dara Navaei

Dara Navaei — Thu, 02 Jul 2026 14:02:47 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-4873-1

LEAHI-DIALIN-LDT-4505-1: closed by Vendor - TEL - Varshini Nagabooshanam

Vendor - TEL - Varshini Nagabooshanam — Thu, 02 Jul 2026 13:19:41 -0700

Vendor - TEL - Varshini Nagabooshanam Closed LEAHI-DIALIN-LDT-4505-1

LEAHI-DIALIN-LDT-4614-1: reviewers finished

Thu, 02 Jul 2026 09:54:03 -0700

Zoltan Miskolci finished reviewing LEAHI-DIALIN-LDT-4614-1

LEAHI-DIALIN-LDT-4614_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 5/1:

LEAHI-DIALIN-LDT-4734-1: reviewers finished

Wed, 01 Jul 2026 20:58:33 -0700

Vendor - TEL - Sameer Poyil , Vinayakam Mani and Zoltan Miskolci finished reviewing LEAHI-DIALIN-LDT-4734-1

LEAHI-DIALIN-LDT-4734_Water Treatment and Degassing - FW Iteration - 5/4:

LEAHI-DIALIN-LDT-4734-1: reviewers joined LEAHI-DIALIN-LDT-4734_Water Treatment and Degassin...

Wed, 01 Jul 2026 20:58:28 -0700

Vendor - TEL - Sameer Poyil joined LEAHI-DIALIN-LDT-4734-1

LEAHI-DIALIN-LDT-4734_Water Treatment and Degassing - FW Iteration - 5/4:

LEAHI-DIALIN-LDT-4614-1: started by Dara Navaei

Dara Navaei — Wed, 01 Jul 2026 15:17:25 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-4614-1

LEAHI-DIALIN-LDT-4484-1: comment by Zoltan Miskolci "The approach of what this code does and the con..."

Zoltan Miskolci — Wed, 01 Jul 2026 14:28:52 -0700

Zoltan Miskolci replied to Behrouz NematiPour in LEAHI-DIALIN-LDT-4484-1

The approach of what this code does and the conversion module are similar in function but a differ on maintenance and flexibility.
1. The conversion module's bytearray to value methods work, but they require manual logistic around the indexing. It's the user's responsibility to handle where the reading starts and you need to code the handler for that (previous approach with MsgFieldPositions), It's inflating the method. I worked hard to remove the need for indexing where the value starts. Instead of the previous struct.unpack approach, where you needed to maintain the type, you will be needing to maintain the conversion methods that are being called, so it would be the same as before, you still need to mind the indexing, which was the main reason of changing from this approach.

2. In the current approach, you declare the type and pass it to a processor that dynamically handling the unpack type (based on the set datatype) and the indexing for that. This works much better and easier to maintain, as you can just insert a new value when it's added to the FW, and don't need to adjust all your indexes for the reading.

Example #1, changing build type from U16 to U08:

with the conversion approach, you need to change the function used, and update the starting index for all the following methods.
with the current approach you change the Datatype.U16 to Datatype.U08 and that's all you need to do.

Example #2: adding a new variable fpga_micro after fpga_minor, with U08 type:

with the conversion approach, you add the bytearray_to_byte, update the indexes for all the following reads.
with the current approach you insert an element after the fpga_minor with a value ('fpga_micro', Datatype.U08), and nothing more needed

LEAHI-DIALIN-LDT-4734-1: comment by Michael Garthwaite "fixed. thanks!"

Michael Garthwaite — Wed, 01 Jul 2026 15:00:14 -0700

Michael Garthwaite replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4734-1

fixed. thanks!

LEAHI-DIALIN-LDT-4734-1: comment by Michael Garthwaite "fixed. thanks"

Michael Garthwaite — Wed, 01 Jul 2026 14:59:50 -0700

Michael Garthwaite replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4734-1

fixed. thanks

LEAHI-DIALIN-LDT-4734-1: comment by Zoltan Miskolci "Add uncompensated conductivity to the init too"

Zoltan Miskolci — Wed, 01 Jul 2026 14:40:41 -0700

Zoltan Miskolci commented on LEAHI-DIALIN-LDT-4734-1

Add uncompensated conductivity to the init too

LEAHI-DIALIN-LDT-4734-1: comment by Zoltan Miskolci "Add uncompensated conductivity to the init too"

Zoltan Miskolci — Wed, 01 Jul 2026 14:40:29 -0700

Zoltan Miskolci commented on LEAHI-DIALIN-LDT-4734-1

Add uncompensated conductivity to the init too

LEAHI-DIALIN-LDT-4878-1: closed by Zoltan Miskolci

Zoltan Miskolci — Wed, 01 Jul 2026 14:25:49 -0700

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-4878-1

LEAHI-DIALIN-LDT-4878-1: reviewers finished

Wed, 01 Jul 2026 12:58:56 -0700

Michael Garthwaite and Dara Navaei finished reviewing LEAHI-DIALIN-LDT-4878-1

LEAHI-DIALIN-LDT-4878_(Dialin) The wheel file generated by the build.sh command failed to install

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "RESOLVED for now."

Behrouz NematiPour — Wed, 01 Jul 2026 12:33:22 -0700

Behrouz NematiPour replied to Behrouz NematiPour in LEAHI-DIALIN-LDT-4484-1

RESOLVED for now.

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "I would not do that because the function names ..."

Behrouz NematiPour — Wed, 01 Jul 2026 12:32:17 -0700

Behrouz NematiPour replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4484-1

I would not do that because the function names and messages for each project should be different to avoid confusion.
I think that is fine for now.

RESOLVED.

LEAHI-DIALIN-LDT-4160-1: comment by Vendor - TEL - Santhoshkumar Reddy Alasandagutti "even though we are sending U08 at Firmware. Due..."

Vendor - TEL - Santhoshkumar Reddy Alasandagutti — Wed, 01 Jul 2026 12:12:10 -0700

Vendor - TEL - Santhoshkumar Reddy Alasandagutti replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4160-1

even though we are sending U08 at Firmware. Due to structure padding Raw message for priority is converted as 16 bits. While receiving we need to read them as U16. Here is my debug values [CortexR4] ALARM_PROP_T size = 22 bytes
byte[0] = 0x03
byte[1] = 0x00
byte[2] = 0x6F
byte[3] = 0x00
byte[4] = 0x01
byte[5] = 0x00
byte[6] = 0x00
byte[7] = 0x01
byte[8] = 0x00
byte[9] = 0x00
byte[10] = 0x01
byte[11] = 0x00
byte[12] = 0x00
byte[13] = 0x01
byte[14] = 0x00
byte[15] = 0x00
byte[16] = 0x01
byte[17] = 0x00
byte[18] = 0x00
byte[19] = 0x01
byte[20] = 0x0A
byte[21] = 0x00

This is structure defined at firmware side
struct AlarmTableRequestPayload

Unknown macro: { U08 alarmPriority; U16 alarmSubRank; U08 alarmSource; U08 alarmIsFault; U08 alarmIsDDFault; U08 alarmStops; U08 alarmConditionClearImmed; ///< Alarm condition is cleared immediately (does not persist after alarm triggered) U08 alarmNoClear; ///< Alarm cannot be cleared (unrecoverable)? U08 alarmNoResume; ///< Alarm prevents treatment resume U08 alarmNoRinseback; ///< Alarm prevents rinseback U08 alarmNoEndTreatment; ///< Alarm prevents ending treatment U08 alarmBlockRinseback; ///< Alarm should not trigger while in rinseback states U08 alarmBlockEndTx; ///< Alarm should not trigger while in post-treatment mode U08 alarmNoBloodRecirc; ///< Alarm prevents blood re-circulation U08 alarmNoDialysateRecirc; ///< Alarm prevents dialysate re-circulation U08 alarmAutoResume; ///< Alarm should resume automatically once the condition is cleared U08 alarmClearOnly; ///< Clear only this alarm on user acknowledgment U08 alarmTreatmentLog; ///< Log alarm to treatment log if active during treatment U16 alarmID; ///< Alarm ID }

;
typedef struct AlarmTableRequestPayload ALARM_PROP_T;

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "So the same channels are used for both the Leah..."

Behrouz NematiPour — Wed, 01 Jul 2026 12:07:36 -0700

Behrouz NematiPour replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4484-1

So the same channels are used for both the Leahi and Denali?
I am not talking about how collisions are handled; that is handled by the CAN driver, not the FW or SW.
My point is that the CAN Channels by themselves do not have the meaning we want; they are only a priority.
As we defined them, we gave them a meaning as a category; therefore, it is better to name them the Denali/Leahi Channels rather than the CAN Channels.

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "RESOLVED."

Behrouz NematiPour — Wed, 01 Jul 2026 12:06:39 -0700

Behrouz NematiPour replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4484-1

RESOLVED.

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "{code} def fp_versions(self, major: int, minor..."

Behrouz NematiPour — Wed, 01 Jul 2026 12:05:06 -0700

Behrouz NematiPour replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4484-1

def fp_versions(self, major: int, minor: int, micro: int, build: int,
                     fpga_id: int, fpga_major: int, fpga_minor: int, fpga_lab: int,
                     compatibility_rev: int):
     """
     Broadcasts the current dd Version Data (Msg ID: 0x0F, 15)
     Args:
         @param major: (uint) - Major version number
         @param minor: (uint) - Minor version number
         @param micro: (uint) - Micro version number
         @param build: (uint) - Build version number
         @param fpga_id: (int) - FPGA id version number
         @param fpga_major: (int) - FPGA Major version number
         @param fpga_minor: (int) - FPGA Minor version number
         @param fpga_lab: (int) - FPGA Lab version number
         @param compatibility_rev: (uint) - The FWs/UI compatibility revision
     @return: None
     """
     if not self.can_enabled:
         raise ValueError("CAN Interface is not enabled")

     payload =  conversions.unsigned_byte_to_bytearray   (major            )
     payload += conversions.unsigned_byte_to_bytearray   (minor            )
     payload += conversions.unsigned_byte_to_bytearray   (micro            )
     payload += conversions.unsigned_short_to_bytearray  (build            )
     payload += conversions.unsigned_byte_to_bytearray   (fpga_id          )
     payload += conversions.unsigned_byte_to_bytearray   (fpga_major       )
     payload += conversions.unsigned_byte_to_bytearray   (fpga_minor       )
     payload += conversions.unsigned_byte_to_bytearray   (fpga_lab         )
     payload += conversions.unsigned_integer_to_bytearray(compatibility_rev)

     message = CAN.CanMessage.build_message(
                                         channel_id=CAN.CanChannels.fp_sync_broadcast_ch_id,
                                         message_id=msg_ids.MsgIds.MSG_ID_FP_VERSION_RESPONSE.value,
                                         payload=payload)

     self.can_interface.send(message, 0)

leahi-dialin (develop): Merge branch 'LDT-4505' into develop

Zoltan Miskolci — Wed, 01 Jul 2026 11:08:37 -0700

Zoltan Miskolci committed ad4c490 on branch develop in leahi-dialin

Merge branch 'LDT-4505' into develop

· /leahi_dialin/td/modules/blood_flow.py

(-1, +1)

| History

| Source

| Diff