Fisheye on td-firmware/firmware/App/Services/StateServices/TubeSetAutoEject.h https://devapps.diality.us/changelog/~br%3Ddevelop/td-firmware/firmware/App/Services/StateServices/TubeSetAutoEject.h Recent activity in "td-firmware" under directory /firmware/App/Services/StateServices/TubeSetAutoEject.h LEAHI-TD-FIRMWARE-LDT-4013-2: reviewers finished Mon, 15 Jun 2026 14:47:43 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2 Vendor - TEL - Jashwant Gantyada , Vendor - TEL - Arpita Srivastava and Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-4013-2 LEAHI-TD-FIRMWARE-LDT-4013_Fluid Bolus - FW Implementation - 2/4: ]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Vendor - TEL - Arpita Srivastava "Thank you for the clarification!" Mon, 15 Jun 2026 11:36:28 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29916 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29916 Vendor - TEL - Arpita Srivastava replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-4013-2

Thank you for the clarification!

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Vendor - TEL - Arpita Srivastava "break into two lines" Mon, 15 Jun 2026 11:33:03 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29915 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29915 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-4013-2

break into two lines

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Vendor - TEL - Arpita Srivastava "Add alarm ALARM_ID_TD_EMPTY_SALINE_BAG" Mon, 15 Jun 2026 11:32:09 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29914 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29914 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-4013-2

Add alarm ALARM_ID_TD_EMPTY_SALINE_BAG

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Vendor - TEL - Arpita Srivastava "Add newAlarmIndicateStop to output" Mon, 15 Jun 2026 11:27:41 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29913 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29913 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-4013-2

Add newAlarmIndicateStop to output

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Vendor - TEL - Arpita Srivastava "Add newAlarmIndicateStop to input and output." Mon, 15 Jun 2026 11:21:36 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29912 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29912 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-4013-2

Add newAlarmIndicateStop to input and output.

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Sean Nash "Arpita, we don't want to use doxygen style comm..." Fri, 12 Jun 2026 23:04:10 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29898 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29898 Sean Nash replied to Vendor - TEL - Arpita Srivastava in LEAHI-TD-FIRMWARE-LDT-4013-2

Arpita, we don't want to use doxygen style comments for function prototypes since we cover functions with the function headers. so this is the proper type of comments.

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Vendor - TEL - Arpita Srivastava "pauseBolusResumeState is input" Fri, 12 Jun 2026 15:50:24 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29890 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29890 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-4013-2

pauseBolusResumeState is input

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Vendor - TEL - Arpita Srivastava "add alarm" Fri, 12 Jun 2026 15:47:28 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29889 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29889 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-4013-2

add alarm

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Vendor - TEL - Arpita Srivastava "Replace // to ///< for line 56 to 60" Fri, 12 Jun 2026 15:45:41 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29888 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29888 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-4013-2

Replace // to ///< for line 56 to 60

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: reviewers added to LEAHI-TD-FIRMWARE-LDT-4013_Fluid Bolus - FW Implem... Fri, 12 Jun 2026 15:27:04 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2 Sean Nash added Vendor - TEL - Jashwant Gantyada to LEAHI-TD-FIRMWARE-LDT-4013-2 LEAHI-TD-FIRMWARE-LDT-4013_Fluid Bolus - FW Implementation - 2/4: ]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Sean Nash "Use // comments for function prototypes." Fri, 12 Jun 2026 15:06:58 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29887 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29887 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-2

Use // comments for function prototypes.

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Sean Nash "Either no comment or // comment for function pr..." Fri, 12 Jun 2026 15:06:17 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29886 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29886 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-2

Either no comment or // comment for function prototypes since doxygen captures function details from function headers.

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Sean Nash "These were fine (and preferred) as // because d..." Fri, 12 Jun 2026 15:04:48 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29885 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29885 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-2

These were fine (and preferred) as // because doxygen gets function details from function headers in the .c file.

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Sean Nash "Should we be looking at tubing set type instead..." Fri, 12 Jun 2026 09:32:29 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29845 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29845 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-2

Should we be looking at tubing set type instead of modality here?

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Sean Nash "Can we not determine this now? Why TODO?" Fri, 12 Jun 2026 09:28:58 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29844 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29844 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-2

Can we not determine this now? Why TODO?

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Sean Nash "Shouldn't we be checking tubing set type instea..." Fri, 12 Jun 2026 09:27:41 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29843 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29843 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-2

Shouldn't we be checking tubing set type instead of modality here?

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Sean Nash "verify given type is valid (< NUM_OF_TUBE_SET_T..." Fri, 12 Jun 2026 09:23:16 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29840 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29840 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-2

verify given type is valid (< NUM_OF_TUBE_SET_TYPES) and trigger s/w fault if invalid.

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Sean Nash "Initialize to UNKNOWN type. Remove TODO." Fri, 12 Jun 2026 09:22:32 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29839 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29839 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-2

Initialize to UNKNOWN type. Remove TODO.

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Sean Nash "Consider adding TUBE_SET_TYPE_UNKNOWN = 0 as fi..." Fri, 12 Jun 2026 09:21:16 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29838 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29838 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-2

Consider adding TUBE_SET_TYPE_UNKNOWN = 0 as first enum so you can initialize a type variable to something before we install/identify the type.

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Sean Nash "Use /// when above, use ///< when to the right...." Fri, 12 Jun 2026 09:17:40 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29836 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29836 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-2

Use /// when above, use ///< when to the right.
Also remove extra space before Tube

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: comment by Sean Nash "Change // to ///<" Fri, 12 Jun 2026 09:17:56 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29837 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29837 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-2

Change // to ///<

]]> LEAHI-TD-FIRMWARE-LDT-4013-2: started by Dara Navaei Fri, 12 Jun 2026 04:02:26 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2 Dara Navaei started review LEAHI-TD-FIRMWARE-LDT-4013-2 ]]> LEAHI-TD-FIRMWARE-LDT-1886-2: closed by Vendor - TEL - Praneeth Bunne Fri, 22 May 2026 15:39:48 -0700 Vendor - TEL - Praneeth Bunne https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2 Vendor - TEL - Praneeth Bunne Closed LEAHI-TD-FIRMWARE-LDT-1886-2 ]]> LEAHI-TD-FIRMWARE-LDT-1886-2: reviewers finished Fri, 22 May 2026 13:31:18 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2 Sean Nash and Vendor - TEL - Arpita Srivastava finished reviewing LEAHI-TD-FIRMWARE-LDT-1886-2 LEAHI-TD-FIRMWARE-LDT-1886_Blood Set Auto-Load and Auto-Eject - TD ]]> td-firmware (LDT-2240-disposable-tube-set-self-test): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Fri, 22 May 2026 11:47:14 -0700 Dara Navaei https://devapps.diality.us/changelog/td-firmware?cs=9cc543b1c2508280767573e20eddd94e68be1fb5 https://devapps.diality.us/changelog/td-firmware?cs=9cc543b1c2508280767573e20eddd94e68be1fb5 Dara Navaei committed 9cc543b on branch LDT-1886-blood-set-auto-load-and-auto-ej, LDT-2240-disposable-tube-set-self-test and 22 more in td-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodFlow.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Ejector.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Ejector.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeInitPOST.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModePostTreat.c (-3, +3) | History | Source | Diff
· /firmware/App/Modes/ModePostTreat.h (-3, +3) | History | Source | Diff
· /firmware/App/Modes/ModePreTreat.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModePreTreat.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/StateServices/TubeSetAutoEject.c (-3, +3) | History | Source | Diff
· /firmware/App/Services/StateServices/TubeSetAutoEject.h (-3, +3) | History | Source | Diff
· /firmware/App/Services/StateServices/TubeSetInstall.c (-3, +3) | History | Source | Diff
· /firmware/App/Services/StateServices/TubeSetInstall.h (-3, +3) | History | Source | Diff
]]> LEAHI-TD-FIRMWARE-LDT-1886-2: comment by Vendor - TEL - Arpita Srivastava "We can rename priorState to previousInstallStat..." Wed, 20 May 2026 15:48:42 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2/#c29259 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2/#c29259 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-1886-2

We can rename priorState to previousInstallState.
Also, it should be declared as a static variable to be able to retain previousState value when the control goes out of the function.

]]> LEAHI-TD-FIRMWARE-LDT-1886-2: comment by Vendor - TEL - Arpita Srivastava "There is still merge conflict? Please resolve ..." Tue, 19 May 2026 15:36:43 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2/#c29194 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2/#c29194 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-1886-2

There is still merge conflict?
Please resolve merge conflict and build the code in your local before pushing.

]]> LEAHI-TD-FIRMWARE-LDT-1886-2: comment by Sean Nash "This merge conflict is still unresolved." Tue, 19 May 2026 15:35:43 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2/#c29193 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2/#c29193 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1886-2

This merge conflict is still unresolved.

]]> LEAHI-TD-FIRMWARE-LDT-1886-2: comment by Vendor - TEL - Arpita Srivastava "leak in the comment section." Tue, 19 May 2026 15:34:57 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2/#c29192 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2/#c29192 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-1886-2

leak in the comment section.

]]>