RESOLVED

Done

RESOLVED

I will work on that later in prTx-UF story and it has only been fixed here since it wasn't passing the test sometimes while testing the Alarm design.

Yes I know. I accidently clicked it and there's no way to unclick

Our process calls for only 1 UNRESOLVED and 1 RESOLVED response (comment) per thread please.

1 - I mean that timer is not only for handling our implementation it may have another purpose which we are stopping by killing the only timer it has.
2 - in your

timerEvent {
    ...
    if( ! _timerIsActive ) return;
    ...
}

Since any object has only one timer I have a feeling that by killing the object's only timer, then any refreshing or chores for any kind of signal/slot maintenance will be stoped.

That's the intention - to stop the timer. Since the UI is continually trying to reconnect to the last paired device while it is off, if a user goes into the bluetooth settings page and hits "Scan for devices", the timer is stopped during the scan to avoid conflicts between the timer and the scan.

I prefer to have a boolean flag to return from the virtual method in case we don't need it to handle the functionality we put there.

This doesn't make sense to me, can you clarify?

RESOLVED

I am not sure killing the QObject timer would be a good idea, but also I couldn't find any recommendation not to do it.
Since any object has only one timer I have a feeling that by killing the object's only timer, then any refreshing or chores for any kind of signal/slot maintenance will be stoped.

I prefer to have a boolean flag to return from the virtual method in case we don't need it to handle the functionality we put there.

When we add the correct object dictionary in the names.py then sys/v&v/... can use it and don't need the object name anymore to do so.
Not 100% agree.
Also, we need to have a consistent naming for the currently existing objectName in the code, I'll later provide a standard.

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

Please note that the code review has to be automatic, by making it manual and mixed up with other features, this may happen.
RESOLVED

RESOLVED

It's not the components themselves that do what you want it's how you call and manage it and having another component was unnecessary.
RESOLVED regardless.

RESOLVED

RESOLVED

RESOLVED

RESOLVED.

RESOLVED.

RESOLVED