UI-DEN-4860-BLE-1 UI-DEN-4860_BLE

closed on 27 Jan 21

Author

Reviewers

UI-DEN-4860_BLE

Activity

Details
Objectives
General Comments 1
Unresolved
Resolved
Number of files included: 100

application 0
- Folder resources/images 0
  - File alarm.svg 0 Remove
  - File alert.png 3 Remove
  - File bell-off.svg 0 Remove
  - File bell.svg 0 Remove
- Folder scripts 0
  - File run.sh 11 Remove
- Folder sources 0
  - Folder bluetooth 0
    - File BLEScanner.cpp 8 Remove
    - File BLEScanner.h 0 Remove
  - Folder canbus 0
    - File MessageDispatcher.cpp 0 Remove
    - File MessageDispatcher.h 0 Remove
    - File MessageGlobals.h 0 Remove
    - File MessageInterpreter.cpp 0 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder components 0
        
        Folder pretreatment 0
        
        File ConfirmTreatmentSubTable.qml 0 Remove
        
        File ConfirmTreatmentTable.qml 0 Remove
        
        File ConfirmTreatmentTableEntry.qml 0 Remove
        
        File SliderCreateTreatment.qml 0 Remove
        
        File SliderDoubleCreateTreatment.qml 0 Remove
        
        File TopMenuBarCreateTreatment.qml 0 Remove
        
        File ConfirmTreatmentSubTable.qml 0 Remove
        
        File ConfirmTreatmentTable.qml 0 Remove
        
        File ConfirmTreatmentTableEntry.qml 0 Remove
        
        File ScreenItem.qml 3 Remove
        
        File SettingsItem.qml 3 Remove
        
        File SliderCreateTreatment.qml 0 Remove
        
        File SliderDoubleCreateTreatment.qml 0 Remove
        
        File TopMenuBarCreateTreatment.qml 0 Remove
      - Folder dialogs 0
        
        File Alert.qml 3 Remove
        
        File NotificationDialog.qml 18 Remove
      - Folder globals 0
        
        File Fonts.qml 0 Remove
        
        File Variables.qml 0 Remove
      - Folder pages 0
        
        Folder treatment 0
        
        Folder sections 0
        
        File TreatmentVitals.qml 0 Remove
        
        File TreatmentConfirm.qml 0 Remove
        
        File TreatmentCreate.qml 0 Remove
        
        File TreatmentPrime.qml 0 Remove
        
        File TreatmentStack.qml 0 Remove
        
        File SettingsBluetooth.qml 0 Remove
        
        File SettingsHome.qml 0 Remove
      - File main.qml 0 Remove
    - File GuiController.cpp 0 Remove
    - File GuiController.h 0 Remove
    - File GuiGlobals.cpp 0 Remove
    - File GuiGlobals.h 0 Remove
    - File guiglobals.cpp 0 Remove
  - Folder model 0
    - Folder hd/adjustment 0
      - File MTreatmentAdjustRequests.h 0 Remove
    - File MEndTreatmentResponse.cpp 0 Remove
    - File MEndTreatmentResponse.h 0 Remove
    - File MModel.h 0 Remove
    - File MStartTreatmentResponse.cpp 0 Remove
    - File MStartTreatmentResponse.h 0 Remove
  - Folder storage 0
    - File FileHandler.cpp 0 Remove
    - File Logger.cpp 0 Remove
    - File StorageGlobals.cpp 0 Remove
    - File StorageGlobals.h 0 Remove
  - Folder view 0
    - File VAlert.cpp 0 Remove
    - File VAlert.h 0 Remove
    - File VBluetooth.cpp 0 Remove
    - File VBluetooth.h 0 Remove
    - File VBluetoothDeviceInfo.cpp 0 Remove
    - File VBluetoothDeviceInfo.h 0 Remove
    - File VTreatmentBegin.cpp 0 Remove
    - File VTreatmentBegin.h 0 Remove
    - File VTreatmentCreate.cpp 0 Remove
    - File VTreatmentCreate.h 0 Remove
    - File VTreatmentEnd.cpp 0 Remove
    - File VTreatmentEnd.h 0 Remove
    - File VView.h 0 Remove
    - File VVitals.cpp 0 Remove
    - File VVitals.h 0 Remove
    - File vview.h 0 Remove
  - File threads.cpp 0 Remove
- Folder unittests 0
  - File tst_canbus.cpp 0 Remove
  - File tst_messaging.cpp 0 Remove
  - File tst_messaging.h 0 Remove
  - File tst_models.cpp 0 Remove
  - File tst_models.cpp 0 Remove
  - File tst_models.h 0 Remove
  - File tst_views.cpp 0 Remove
  - File tst_views.cpp 0 Remove
  - File tst_views.h 0 Remove
- File .gitignore 0 Remove
- File cppcheck.err 0 Remove
- File cppcheck.log 0 Remove
- File denali.pro 6 Remove
- File denali.pro.user 0 Remove
- File denali.qrc 0 Remove
- File main.cpp 0 Remove
testsuites 0
- Folder shared/scripts 0
  - File names.py 0 Remove
- Folder tools 0
  - File run_tests.sh 0 Remove
- Folder tst_AlarmCleared 0
  - File test.py 0 Remove
- Folder tst_AlarmFlags 0
  - File config.xml 0 Remove
  - File test.py 0 Remove
- Folder tst_AlarmSilence 0
  - File config.xml 0 Remove
  - File test.py 0 Remove
- Folder tst_Alarm_Colors 0
  - File test.py 0 Remove
- Folder tst_ConfirmPrimingBegin 0
  - File test.py 0 Remove
- Folder tst_CreateTreatment 0
  - File test.py 0 Remove
- Folder tst_TreatmentHeparineData 0
  - File test.py 0 Remove
- Folder tst_TreatmentStatesData 0
  - File test.py 0 Remove
- Folder tst_Treatment_Adjustment_Heparin 0
  - File test.py 0 Remove
- Folder tst_Treatment_Adjustment_Pressures 0
  - File test.py 0 Remove
- File suite.conf 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
plucia (deleted user)	Author	4h 24m	20	Done
Behrouz NematiPour	Reviewer - Complete	3h 53m	36	RESOLVED
pmontazemi (deleted user)	Reviewer - Complete	21m
Total		8h 39m	56

Linked issues
- DEN-4860

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

plucia (deleted user)

As of today, 12.30.2020: Code Coverage: 100% SquishQt tests: 100% passing Uni...

As of today, 12.30.2020:
Code Coverage: 100%
SquishQt tests: 100% passing
Unit Tests: 100% passing

30 Dec 20

Click to load diff

/sources/.../components/ConfirmTreatmentSubTable.qml Deleted

Click to load diff

/sources/.../components/ConfirmTreatmentTable.qml Deleted

Click to load diff

/sources/.../components/ConfirmTreatmentTableEntry.qml Deleted

Click to load diff

/sources/.../components/SliderCreateTreatment.qml Deleted

Click to load diff

/sources/.../components/SliderDoubleCreateTreatment.qml Deleted

Click to load diff

/sources/.../components/TopMenuBarCreateTreatment.qml Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

UI-DEN-4860-BLE-1

UI-DEN-4860_BLE

UI-DEN-4860-BLE-1 56

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

plucia (deleted user)

Log time

UI-DEN-4860_BLE

UI-DEN-4860-BLE-1 56

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

plucia (deleted user)

Log time