Fisheye on dgfirmware/firmware/App/Tasks/TaskTimer.h https://devapps.diality.us/changelog/~br%3Ddgcommonfix/dgfirmware/firmware/App/Tasks/TaskTimer.h Recent activity in "dgfirmware" under directory /firmware/App/Tasks/TaskTimer.h DG-UCOMMITS-37: closed by Sean Nash Thu, 03 Aug 2023 13:21:06 -0700 Sean Nash https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Sean Nash Closed DG-UCOMMITS-37 ]]> DG-UCOMMITS-37: reviewers finished Thu, 03 Aug 2023 10:09:19 -0700 https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Dara Navaei finished reviewing DG-UCOMMITS-37 DG Staging Unreviewed Commits ]]> DG-UCOMMITS-37: reviewers finished Wed, 02 Aug 2023 16:01:41 -0700 https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Sean Nash finished reviewing DG-UCOMMITS-37 DG Staging Unreviewed Commits ]]> DG-UCOMMITS-37: started by Dara Navaei Mon, 08 May 2023 09:44:32 -0700 Dara Navaei https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Dara Navaei started review DG-UCOMMITS-37 ]]> DG-DEN-4322-1: closed by qnguyen Fri, 28 Aug 2020 17:19:28 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-4322-1 https://devapps.diality.us/cru/DG-DEN-4322-1 qnguyen  (deleted user) Closed DG-DEN-4322-1 ]]> DG-DEN-4322-1: reviewers finished Fri, 28 Aug 2020 16:43:38 -0700 https://devapps.diality.us/cru/DG-DEN-4322-1 https://devapps.diality.us/cru/DG-DEN-4322-1 Sean Nash and pmontazemi  (deleted user) finished reviewing DG-DEN-4322-1 DG-DEN-4322_DG Water RO Rejection ]]> DG-DEN-4322-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Fri, 28 Aug 2020 16:33:08 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-4322-1/#c4244 https://devapps.diality.us/cru/DG-DEN-4322-1/#c4244 pmontazemi  (deleted user) replied to qnguyen  (deleted user) in DG-DEN-4322-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-4322-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Fri, 28 Aug 2020 16:32:49 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-4322-1/#c4243 https://devapps.diality.us/cru/DG-DEN-4322-1/#c4243 pmontazemi  (deleted user) replied to qnguyen  (deleted user) in DG-DEN-4322-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-4322-1: comment by qnguyen "Done." Wed, 26 Aug 2020 11:45:04 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-4322-1/#c3998 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3998 qnguyen  (deleted user) replied to pmontazemi  (deleted user) in DG-DEN-4322-1

Done.

]]> DG-DEN-4322-1: comment by qnguyen "Done." Wed, 26 Aug 2020 11:44:53 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-4322-1/#c3997 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3997 qnguyen  (deleted user) replied to pmontazemi  (deleted user) in DG-DEN-4322-1

Done.

]]> DG-DEN-4322-1: comment by pmontazemi "Insert extra line before return." Wed, 26 Aug 2020 10:45:48 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-4322-1/#c3962 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3962 pmontazemi  (deleted user) commented on DG-DEN-4322-1

Insert extra line before return.

]]> DG-DEN-4322-1: comment by pmontazemi "{ at next line based on C Coding Standard" Wed, 26 Aug 2020 10:40:16 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-4322-1/#c3957 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3957 pmontazemi  (deleted user) commented on DG-DEN-4322-1

{ at next line based on C Coding Standard

]]> DG-DEN-4322-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 26 Aug 2020 10:36:27 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-4322-1/#c3954 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3954 Sean Nash replied to Dara Navaei in DG-DEN-4322-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-4322-1: comment by Dara Navaei "This has been fixed in Sprint26." Wed, 26 Aug 2020 10:36:14 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-4322-1/#c3953 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3953 Dara Navaei replied to qnguyen  (deleted user) in DG-DEN-4322-1

This has been fixed in Sprint26.

]]> DG-DEN-4322-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 26 Aug 2020 10:35:08 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-4322-1/#c3952 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3952 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-4322-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-4322-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 26 Aug 2020 10:34:41 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-4322-1/#c3951 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3951 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-4322-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-4322-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 26 Aug 2020 10:34:25 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-4322-1/#c3950 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3950 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-4322-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-4322-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 26 Aug 2020 10:34:01 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-4322-1/#c3949 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3949 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-4322-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-4322-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 26 Aug 2020 10:32:53 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-4322-1/#c3947 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3947 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-4322-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-4322-1: comment by qnguyen "Fixed." Wed, 26 Aug 2020 00:31:02 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-4322-1/#c3938 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3938 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-4322-1

Fixed.

]]> DG-DEN-4322-1: comment by qnguyen "Fixed. Module Pressure should use these definit..." Wed, 26 Aug 2020 00:27:33 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-4322-1/#c3937 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3937 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-4322-1

Fixed. Module Pressure should use these definitions rather than defining its own.

]]> DG-DEN-4322-1: comment by qnguyen "Done." Wed, 26 Aug 2020 00:23:14 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-4322-1/#c3936 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3936 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-4322-1

Done.

]]> DG-DEN-4322-1: comment by qnguyen "Done." Wed, 26 Aug 2020 00:21:38 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-4322-1/#c3935 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3935 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-4322-1

Done.

]]> DG-DEN-4322-1: comment by qnguyen "Yes, it should be one blank line at the end. I ..." Wed, 26 Aug 2020 00:12:23 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-4322-1/#c3933 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3933 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-4322-1

Yes, it should be one blank line at the end. I do see in code composer there is one blank line at the end of these files.

]]> DG-DEN-4322-1: comment by qnguyen "[~dnavaei] Can you please respond to this chang..." Wed, 26 Aug 2020 00:10:53 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-4322-1/#c3932 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3932 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-4322-1

Dara Navaei Can you please respond to this change?

]]> DG-DEN-4322-1: comment by Sean Nash "The code in this header file should be added to..." Tue, 25 Aug 2020 23:43:19 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-4322-1/#c3931 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3931 Sean Nash commented on DG-DEN-4322-1

The code in this header file should be added to the SystemCommMessages group for now. This header file will be going away at some point and its definitions distributed to other header files.

]]> DG-DEN-4322-1: comment by Sean Nash "I think we decided that all .c and .h files wou..." Tue, 25 Aug 2020 23:33:49 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-4322-1/#c3930 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3930 Sean Nash commented on DG-DEN-4322-1

I think we decided that all .c and .h files would end with one blank line. Looks like all DG source files now have no blank lines at end.

]]> DG-DEN-4322-1: comment by Sean Nash "Were these not used anywhere? Even if not, see..." Tue, 25 Aug 2020 23:31:39 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-4322-1/#c3929 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3929 Sean Nash commented on DG-DEN-4322-1

Were these not used anywhere? Even if not, seems like it may be in future (or should already be, but other drivers are defining their own). I recommend keeping these.

]]> DG-DEN-4322-1: comment by Sean Nash "I've been putting 2 blank lines above and below..." Tue, 25 Aug 2020 23:17:49 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-4322-1/#c3928 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3928 Sean Nash commented on DG-DEN-4322-1

I've been putting 2 blank lines above and below this comment to emphasize we're moving to Dialin support functions.

]]> DG-DEN-4322-1: comment by Sean Nash "There are more public functions below this line..." Tue, 25 Aug 2020 23:10:59 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-4322-1/#c3927 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3927 Sean Nash commented on DG-DEN-4322-1

There are more public functions below this line. I generally prefer public functions on top and private function below, but this is not required and would conflict with other considerations like keeping Dialin functions (which are public) at very bottom of module. Recommend removing this comment.

]]>