Fisheye on dgfirmware/firmware/source/adc.c https://devapps.diality.us/changelog/~br%3Ddgcommonfix/dgfirmware/firmware/source/adc.c Recent activity in "dgfirmware" under directory /firmware/source/adc.c DG-COMMON-FIX-1: closed by Dara Navaei Thu, 19 Oct 2023 08:43:59 -0700 Dara Navaei https://devapps.diality.us/cru/DG-COMMON-FIX-1 https://devapps.diality.us/cru/DG-COMMON-FIX-1 Dara Navaei Closed DG-COMMON-FIX-1 ]]> DG-COMMON-FIX-1: reviewers finished Thu, 19 Oct 2023 08:43:51 -0700 https://devapps.diality.us/cru/DG-COMMON-FIX-1 https://devapps.diality.us/cru/DG-COMMON-FIX-1 Dara Navaei finished reviewing DG-COMMON-FIX-1 DG-COMMON-FIX_Review ]]> DG-COMMON-FIX-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:43:46 -0700 Dara Navaei https://devapps.diality.us/cru/DG-COMMON-FIX-1/#c19114 https://devapps.diality.us/cru/DG-COMMON-FIX-1/#c19114 Dara Navaei replied to pmontazemi  (deleted user) in DG-COMMON-FIX-1

RESOLVED in CODE WALKTHROUGH

]]> DG-COMMON-FIX-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:43:32 -0700 Dara Navaei https://devapps.diality.us/cru/DG-COMMON-FIX-1/#c19113 https://devapps.diality.us/cru/DG-COMMON-FIX-1/#c19113 Dara Navaei replied to pmontazemi  (deleted user) in DG-COMMON-FIX-1

RESOLVED in CODE WALKTHROUGH

]]> DG-COMMON-FIX-1: started by Dara Navaei Thu, 19 Oct 2023 08:43:00 -0700 Dara Navaei https://devapps.diality.us/cru/DG-COMMON-FIX-1 https://devapps.diality.us/cru/DG-COMMON-FIX-1 Dara Navaei started review DG-COMMON-FIX-1 ]]> DG-DEN-2650-1: closed by Dara Navaei Thu, 19 Oct 2023 08:42:37 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei Closed DG-DEN-2650-1 ]]> DG-DEN-2650-1: reviewers finished Thu, 19 Oct 2023 08:42:03 -0700 https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei finished reviewing DG-DEN-2650-1 DG-DEN-2650_DG Firmware Infrastructure ]]> DG-DEN-2650-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:41:49 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1/#c19112 https://devapps.diality.us/cru/DG-DEN-2650-1/#c19112 Dara Navaei replied to Sean Nash in DG-DEN-2650-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-2650-1: started by Dara Navaei Thu, 19 Oct 2023 08:41:19 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei started review DG-DEN-2650-1 ]]> DG-DEN-7605-1: closed by Sean Nash Thu, 10 Jun 2021 15:21:59 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-7605-1 https://devapps.diality.us/cru/DG-DEN-7605-1 Sean Nash Closed DG-DEN-7605-1 ]]> DG-DEN-7605-1: reviewers finished Thu, 10 Jun 2021 15:05:09 -0700 https://devapps.diality.us/cru/DG-DEN-7605-1 https://devapps.diality.us/cru/DG-DEN-7605-1 qnguyen  (deleted user) , Dara Navaei and pmontazemi  (deleted user) finished reviewing DG-DEN-7605-1 DG-DEN-7605_HD DG Self Tests ]]> DG-DEN-7605-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Thu, 27 May 2021 10:32:56 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-7605-1/#c10129 https://devapps.diality.us/cru/DG-DEN-7605-1/#c10129 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-7605-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-7605-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Thu, 27 May 2021 10:32:48 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-7605-1/#c10128 https://devapps.diality.us/cru/DG-DEN-7605-1/#c10128 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-7605-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-7605-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Thu, 27 May 2021 10:32:01 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-7605-1/#c10127 https://devapps.diality.us/cru/DG-DEN-7605-1/#c10127 pmontazemi  (deleted user) replied to Sean Nash in DG-DEN-7605-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-7605-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Thu, 27 May 2021 10:31:49 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-7605-1/#c10126 https://devapps.diality.us/cru/DG-DEN-7605-1/#c10126 pmontazemi  (deleted user) replied to Sean Nash in DG-DEN-7605-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-7605-1: comment by Sean Nash "Fixed." Wed, 26 May 2021 09:35:00 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-7605-1/#c10123 https://devapps.diality.us/cru/DG-DEN-7605-1/#c10123 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-7605-1

Fixed.

]]> DG-DEN-7605-1: comment by Sean Nash "Yes. Fixed." Wed, 26 May 2021 09:06:35 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-7605-1/#c10122 https://devapps.diality.us/cru/DG-DEN-7605-1/#c10122 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-7605-1

Yes. Fixed.

]]> DG-DEN-7605-1: comment by qnguyen "Consider re-word to something more general. Thi..." Wed, 26 May 2021 09:02:51 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-7605-1/#c10121 https://devapps.diality.us/cru/DG-DEN-7605-1/#c10121 qnguyen  (deleted user) commented on DG-DEN-7605-1

Consider re-word to something more general. This function might be used by ModeHeatDisinfect to tare on an active reservoir.

]]> DG-DEN-7605-1: comment by qnguyen "Should this be in interval count?" Wed, 26 May 2021 08:58:51 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-7605-1/#c10120 https://devapps.diality.us/cru/DG-DEN-7605-1/#c10120 qnguyen  (deleted user) commented on DG-DEN-7605-1

Should this be in interval count?

]]> DG-DEN-7605-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH." Fri, 21 May 2021 10:42:04 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-7605-1/#c10012 https://devapps.diality.us/cru/DG-DEN-7605-1/#c10012 Dara Navaei replied to Sean Nash in DG-DEN-7605-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-7605-1: comment by Sean Nash "Fixed." Fri, 21 May 2021 10:20:40 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-7605-1/#c9999 https://devapps.diality.us/cru/DG-DEN-7605-1/#c9999 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-7605-1

Fixed.

]]> DG-DEN-7605-1: comment by Sean Nash "Fixed." Fri, 21 May 2021 10:20:05 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-7605-1/#c9998 https://devapps.diality.us/cru/DG-DEN-7605-1/#c9998 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-7605-1

Fixed.

]]> DG-DEN-7605-1: comment by Sean Nash "I have no preference on that. Data is temporar..." Thu, 20 May 2021 08:57:30 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-7605-1/#c9987 https://devapps.diality.us/cru/DG-DEN-7605-1/#c9987 Sean Nash replied to Dara Navaei in DG-DEN-7605-1

I have no preference on that. Data is temporary either way. By reference is a little easier on the stack.

]]> DG-DEN-7605-1: comment by pmontazemi "If we align, we align everything, otherwise, no..." Wed, 19 May 2021 15:29:09 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-7605-1/#c9964 https://devapps.diality.us/cru/DG-DEN-7605-1/#c9964 pmontazemi  (deleted user) commented on DG-DEN-7605-1

If we align, we align everything, otherwise, no extra spaces between variables and the "=" sign.

]]> DG-DEN-7605-1: comment by pmontazemi "Align comment." Wed, 19 May 2021 15:28:11 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-7605-1/#c9963 https://devapps.diality.us/cru/DG-DEN-7605-1/#c9963 pmontazemi  (deleted user) commented on DG-DEN-7605-1

Align comment.

]]> DG-DEN-7605-1: comment by Dara Navaei "I thought we decided to pass the broadcast data..." Sat, 15 May 2021 09:51:30 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-7605-1/#c9867 https://devapps.diality.us/cru/DG-DEN-7605-1/#c9867 Dara Navaei commented on DG-DEN-7605-1

I thought we decided to pass the broadcast data as a reference. Did we change that?

]]> DG-DEN-7605-1: started by Sean Nash Sun, 02 May 2021 15:24:35 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-7605-1 https://devapps.diality.us/cru/DG-DEN-7605-1 Sean Nash started review DG-DEN-7605-1 ]]> DG-DEN-2650-1: reviewers finished Tue, 07 Jul 2020 15:10:29 -0700 https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 pmontazemi  (deleted user) finished reviewing DG-DEN-2650-1 DG-DEN-2650_DG Firmware Infrastructure ]]> DG-DEN-2650-1: reviewers added to DG-DEN-2650_DG Firmware Infrastructure Mon, 06 Jul 2020 10:47:29 -0700 https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei added qnguyen  (deleted user) to DG-DEN-2650-1 DG-DEN-2650_DG Firmware Infrastructure ]]> DG-DEN-2650-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Fri, 19 Jun 2020 10:56:35 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-2650-1/#c2487 https://devapps.diality.us/cru/DG-DEN-2650-1/#c2487 pmontazemi  (deleted user) replied to Sean Nash in DG-DEN-2650-1

RESOLVED in CODE WALKTHROUGH.

]]>