· /leahi_dialin/common/constants.py	(-0, +2)	| History	| Source	| Diff
· /leahi_dialin/common/generic_defs.py	(-0, +61)	| History	| Source
· /leahi_dialin/common/msg_defs.py	(-7, +6)	| History	| Source	| Diff
· /leahi_dialin/common/msg_ids.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/common/td_defs.py	(-83, +118)	| History	| Source	| Diff
· /leahi_dialin/common/test_config_defs.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/td/modules/syringe_pump.py	(-22, +41)	| History	| Source	| Diff
· /leahi_dialin/td/modules/valves.py	(-66, +39)	| History	| Source	| Diff
· /leahi_dialin/td/treatment_delivery.py	(-83, +72)	| History	| Source	| Diff
· /leahi_dialin/ui/dd_messaging.py	(-27, +27)	| History	| Source	| Diff
· /leahi_dialin/ui/fp_messaging.py	(-17, +17)	| History	| Source	| Diff
· /leahi_dialin/ui/td_messaging.py	(-104, +104)	| History	| Source	| Diff
· /leahi_dialin/utils/abstract_classes.py	(-0, +157)	| History	| Source

]]> Mon, 01 Jun 2026 08:01:21 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3904-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3904-1 Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3904-1 LEAHI-DIALIN-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes ]]> Fri, 29 May 2026 10:05:00 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3904-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3904-1 Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-3904-1 LEAHI-DIALIN-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes ]]> Thu, 21 May 2026 17:09:11 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3904-1/#c29310 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3904-1/#c29310 Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-3904-1

references to Denali has been removed

Shouldn't we use Leahi instead of Denali?

· /leahi_dialin/utils/__init__.py

(-0, +1)

| History

| Source

| Diff

]]> Wed, 06 May 2026 16:07:39 -0700 Zoltan Miskolci https://devapps.diality.us/changelog/leahi-dialin?cs=27cd8e0e7b47617083e8c12f73306f0ba648e687 https://devapps.diality.us/changelog/leahi-dialin?cs=27cd8e0e7b47617083e8c12f73306f0ba648e687 Zoltan Miskolci committed 27cd8e0 on branch LDT-3735-non-volatile-memory, LDT-3904-opmode-the-operation-mode-broad and 3 more in leahi-dialin - Updated Event enum - Updated Datatypes enum - Added some debugging print to abstract class - Removed some init import to remove cyclic dependencies - Updated alarms

· /leahi_dialin/common/dd_defs.py	(-10, +11)	| History	| Source	| Diff
· /leahi_dialin/common/fp_defs.py	(-1, +3)	| History	| Source	| Diff
· /leahi_dialin/common/generic_defs.py	(-8, +10)	| History	| Source	| Diff
· /leahi_dialin/common/test_config_defs.py	(-2, +1)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/alarms.py	(-25, +15)	| History	| Source	| Diff
· /leahi_dialin/fp/modules/alarms.py	(-25, +16)	| History	| Source	| Diff
· /leahi_dialin/fp/modules/events.py	(-14, +13)	| History	| Source	| Diff
· /leahi_dialin/fp/modules/permeate_tank.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/td/modules/alarms.py	(-41, +29)	| History	| Source	| Diff
· /leahi_dialin/td/modules/events.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/td/modules/td_test_configs.py	(-1, +2)	| History	| Source	| Diff
· /leahi_dialin/utils/__init__.py	(-28, +0)	| History	| Source	| Diff
· /leahi_dialin/utils/abstract_classes.py	(-10, +39)	| History	| Source	| Diff
· /leahi_dialin/utils/enums/__init__.py	(-23, +2)	| History	| Source	| Diff

]]> Tue, 05 May 2026 14:25:28 -0700 Zoltan Miskolci https://devapps.diality.us/changelog/leahi-dialin?cs=34b64ff2d8a64f4b7b60b80bb7cf4c36845e5943 https://devapps.diality.us/changelog/leahi-dialin?cs=34b64ff2d8a64f4b7b60b80bb7cf4c36845e5943 Zoltan Miskolci committed 34b64ff on branch LDT-3735-non-volatile-memory, LDT-3904-opmode-the-operation-mode-broad and 3 more in leahi-dialin - Updated DD and TD module - Updaterd TDValvePosition enum

· /leahi_dialin/common/td_defs.py	(-6, +8)	| History	| Source	| Diff
· /leahi_dialin/dd/dialysate_delivery.py	(-8, +4)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/balancing_chamber.py	(-1, +0)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/blood_leak.py	(-1, +0)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/concentrate_pump.py	(-27, +26)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/conductivity_sensors.py	(-7, +6)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/dialysate_pump.py	(-22, +21)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/drybicart.py	(-1, +0)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/gen_dialysate.py	(-1, +0)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/heaters.py	(-11, +10)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/levels.py	(-6, +4)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/post_gen_dialysate.py	(-1, +0)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/pre_gen_dialysate.py	(-1, +0)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/pressure_sensors.py	(-7, +6)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/rinse_pump.py	(-1, +0)	| History	| Source	| Diff
… 40 more files in changeset.

]]> Mon, 04 May 2026 17:46:48 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3904-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3904-1 Dara Navaei started review LEAHI-DIALIN-LDT-3904-1 ]]> Mon, 04 May 2026 17:24:25 -0700 Zoltan Miskolci https://devapps.diality.us/changelog/leahi-dialin?cs=6d104d3185ac3ed7c18c97ecdc13fd59bf53a8d1 https://devapps.diality.us/changelog/leahi-dialin?cs=6d104d3185ac3ed7c18c97ecdc13fd59bf53a8d1 Zoltan Miskolci committed 6d104d3 on branch LDT-3735-non-volatile-memory, LDT-3904-opmode-the-operation-mode-broad and 3 more in leahi-dialin - Handler and import refactoring of DD module

· /leahi_dialin/common/alarm_defs.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/common/alarm_priorities.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/common/dd_defs.py	(-21, +1)	| History	| Source	| Diff
· /leahi_dialin/common/dd_defs_proxy.py	(-1, +2)	| History	| Source	| Diff
· /leahi_dialin/common/disp_defs.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/common/fp_defs.py	(-22, +1)	| History	| Source	| Diff
· /leahi_dialin/common/fp_defs_proxy.py	(-1, +2)	| History	| Source	| Diff
· /leahi_dialin/common/generic_defs.py	(-0, +57)	| History	| Source
· /leahi_dialin/common/global_vars.py	(-43, +0)	| History	| Source	| Diff
· /leahi_dialin/common/msg_defs.py	(-4, +5)	| History	| Source	| Diff
· /leahi_dialin/common/msg_ids.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/common/td_defs.py	(-21, +1)	| History	| Source	| Diff
· /leahi_dialin/common/td_defs_proxy.py	(-1, +2)	| History	| Source	| Diff
· /leahi_dialin/common/test_config_defs.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/dd/dialysate_delivery.py	(-33, +58)	| History	| Source	| Diff
… 31 more files in changeset.

]]> Mon, 09 Feb 2026 10:34:41 -0800 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1 Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3350-1 ]]> Sat, 07 Feb 2026 16:46:15 -0800 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1 Dara Navaei finished reviewing LEAHI-DIALIN-LDT-3350-1 LEAHI-DIALIN-LDT-3350_[Leahi-Dialin] Add from_str function to the enums ]]> Fri, 06 Feb 2026 09:23:57 -0800 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1/#c27081 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1/#c27081 Zoltan Miskolci replied to Dara Navaei in LEAHI-DIALIN-LDT-3350-1

We agreed to change back the enums into the static variation.
Why would that cover a class that has been implemented to mask the enums from direct access, so if they need to be changed to dynamic or renamed or anything, the other repositories that are using them through this class won't be affected or need any update.

Did we not decide to revert all the changes back and the redesign the whole concept again?

· /leahi_dialin/common/alarm_priorities.py	(-0, +1)	| History	| Source	| Diff
· /leahi_dialin/common/msg_defs.py	(-0, +1)	| History	| Source	| Diff
· /leahi_dialin/common/msg_ids.py	(-0, +1)	| History	| Source	| Diff
· /leahi_dialin/common/test_config_defs.py	(-0, +2)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/blood_leak.py	(-0, +1)	| History	| Source	| Diff
· /leahi_dialin/td/modules/alarms.py	(-0, +1)	| History	| Source	| Diff
· /leahi_dialin/utils/base.py	(-6, +4)	| History	| Source	| Diff
· /leahi_dialin/utils/nv_ops_utils.py	(-1, +2)	| History	| Source	| Diff

]]> Tue, 03 Feb 2026 15:55:46 -0800 Behrouz NematiPour https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1/#c26993 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1/#c26993 Behrouz NematiPour replied to Behrouz NematiPour in LEAHI-DIALIN-LDT-3350-1

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

This design is incorrect,
For common codes, a proxy or a wrapper class should have been implemented.
We will keep it for now to unblock the rest of the team.

This is incorrect.
We should not create many objects for all the Enum classes in an API, and we should not use memory that may not even be in use.
We will keep it for now to unblock the rest of the team.

When building locally without all the parameters the generated name throws an error during python pip install.
So this ensures that if no parameter is added, it uses the default name which is compatible with pip install.
The " -+. " sequence is throwing an error.

removed commented out line

It's a class containing all the enums of the def file.
Yes we need them as many other Framework and huge amount of code are using them.

Obviously not.
You were reminding me about backwards compatibility. This variable and class ensures that even with this major refactor to the enum structure, the current codebase remains working.

Yes, they are aliases that are used for example in Dialin's temperature sensor module to decide which msg id to use for the override.
Updating an alias's value when adding new entries to the enum is easier then changing the last or first sensor type across Dialin modules, which could be forgotten or missed.

DialinEnum from_str function using it to match a strung to an enum member. Converting the string to enum for cleaner code in test cases.

Yes