LEAHI-DIALIN-LDT-3350_[Leahi-Dialin] Add from_str function to the enums

Activity

LEAHI-DIALIN-LDT-3350-1 28

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 1h 9 We agreed to change back the enums into the static variat...
    Reviewer - Complete 47m 6 Did we not decide to revert all the changes back and the ...
    Reviewer - Complete 49m 12 Look in the td_defs.py for the same comment.
    Reviewer - 49% reviewed 7m    
    Reviewer - 0% reviewed      
    Reviewer - 21% reviewed 7m    
    Reviewer - 98% reviewed 25m 1 can you remove this Opode as MODE_TPAR is obsolete and up...
    Reviewer - 0% reviewed      
    Reviewer - 29% reviewed 8m    
    Total   3h 25m 28  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /leahi_dialin/common/__init__.py Changed 2
    Open in IDE #permalink
    /leahi_dialin/common/alarm_priorities.py Changed
    Open in IDE #permalink
    /leahi_dialin/common/dd_defs.py Changed 6
    Open in IDE #permalink
    /leahi_dialin/common/defs_base.py Deleted
    Open in IDE #permalink
    /leahi_dialin/common/fp_defs.py Changed 6
    Open in IDE #permalink
    /leahi_dialin/common/msg_defs.py Changed
    Open in IDE #permalink
    /leahi_dialin/common/msg_ids.py Changed
    Open in IDE #permalink
    /leahi_dialin/common/td_defs.py Changed 10
    Open in IDE #permalink
    /leahi_dialin/common/test_config_defs.py Changed
    Open in IDE #permalink
    /leahi_dialin/dd/modules/blood_leak.py Changed
    Open in IDE #permalink
    /leahi_dialin/dd/modules/valves.py Changed
    Open in IDE #permalink
    /leahi_dialin/td/modules/alarms.py Changed
    Open in IDE #permalink
    /leahi_dialin/td/modules/events.py Changed 2
    Open in IDE #permalink
    /leahi_dialin/utils/base.py Changed
    Open in IDE #permalink
    /leahi_dialin/utils/nv_ops_utils.py Changed
    Open in IDE #permalink
    /build.sh Changed 2
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time