Fisheye on leahi-dialin/leahi_dialin/td/modules/buttons.py

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "Zoltan and I had a meeting, and the counter sol..."

Behrouz NematiPour — Sun, 12 Jul 2026 23:43:02 -0700

Behrouz NematiPour replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4484-1

Zoltan and I had a meeting, and the counter solution he provided works better than mine.
He explained to me that my proposed solution has flaws.
RESOLVED.

LEAHI-DIALIN-LDT-4874-1: started by Dara Navaei

Dara Navaei — Thu, 09 Jul 2026 10:48:25 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-4874-1

LEAHI-DIALIN-LDT-4484-1: comment by Zoltan Miskolci "The approach of what this code does and the con..."

Zoltan Miskolci — Wed, 01 Jul 2026 14:28:52 -0700

Zoltan Miskolci replied to Behrouz NematiPour in LEAHI-DIALIN-LDT-4484-1

The approach of what this code does and the conversion module are similar in function but a differ on maintenance and flexibility.
1. The conversion module's bytearray to value methods work, but they require manual logistic around the indexing. It's the user's responsibility to handle where the reading starts and you need to code the handler for that (previous approach with MsgFieldPositions), It's inflating the method. I worked hard to remove the need for indexing where the value starts. Instead of the previous struct.unpack approach, where you needed to maintain the type, you will be needing to maintain the conversion methods that are being called, so it would be the same as before, you still need to mind the indexing, which was the main reason of changing from this approach.

2. In the current approach, you declare the type and pass it to a processor that dynamically handling the unpack type (based on the set datatype) and the indexing for that. This works much better and easier to maintain, as you can just insert a new value when it's added to the FW, and don't need to adjust all your indexes for the reading.

Example #1, changing build type from U16 to U08:

with the conversion approach, you need to change the function used, and update the starting index for all the following methods.
with the current approach you change the Datatype.U16 to Datatype.U08 and that's all you need to do.

Example #2: adding a new variable fpga_micro after fpga_minor, with U08 type:

with the conversion approach, you add the bytearray_to_byte, update the indexes for all the following reads.
with the current approach you insert an element after the fpga_minor with a value ('fpga_micro', Datatype.U08), and nothing more needed

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "RESOLVED for now."

Behrouz NematiPour — Wed, 01 Jul 2026 12:33:22 -0700

Behrouz NematiPour replied to Behrouz NematiPour in LEAHI-DIALIN-LDT-4484-1

RESOLVED for now.

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "I would not do that because the function names ..."

Behrouz NematiPour — Wed, 01 Jul 2026 12:32:17 -0700

Behrouz NematiPour replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4484-1

I would not do that because the function names and messages for each project should be different to avoid confusion.
I think that is fine for now.

RESOLVED.

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "So the same channels are used for both the Leah..."

Behrouz NematiPour — Wed, 01 Jul 2026 12:07:36 -0700

Behrouz NematiPour replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4484-1

So the same channels are used for both the Leahi and Denali?
I am not talking about how collisions are handled; that is handled by the CAN driver, not the FW or SW.
My point is that the CAN Channels by themselves do not have the meaning we want; they are only a priority.
As we defined them, we gave them a meaning as a category; therefore, it is better to name them the Denali/Leahi Channels rather than the CAN Channels.

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "RESOLVED."

Behrouz NematiPour — Wed, 01 Jul 2026 12:06:39 -0700

Behrouz NematiPour replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4484-1

RESOLVED.

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "{code} def fp_versions(self, major: int, minor..."

Behrouz NematiPour — Wed, 01 Jul 2026 12:05:06 -0700

Behrouz NematiPour replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4484-1

def fp_versions(self, major: int, minor: int, micro: int, build: int,
                     fpga_id: int, fpga_major: int, fpga_minor: int, fpga_lab: int,
                     compatibility_rev: int):
     """
     Broadcasts the current dd Version Data (Msg ID: 0x0F, 15)
     Args:
         @param major: (uint) - Major version number
         @param minor: (uint) - Minor version number
         @param micro: (uint) - Micro version number
         @param build: (uint) - Build version number
         @param fpga_id: (int) - FPGA id version number
         @param fpga_major: (int) - FPGA Major version number
         @param fpga_minor: (int) - FPGA Minor version number
         @param fpga_lab: (int) - FPGA Lab version number
         @param compatibility_rev: (uint) - The FWs/UI compatibility revision
     @return: None
     """
     if not self.can_enabled:
         raise ValueError("CAN Interface is not enabled")

     payload =  conversions.unsigned_byte_to_bytearray   (major            )
     payload += conversions.unsigned_byte_to_bytearray   (minor            )
     payload += conversions.unsigned_byte_to_bytearray   (micro            )
     payload += conversions.unsigned_short_to_bytearray  (build            )
     payload += conversions.unsigned_byte_to_bytearray   (fpga_id          )
     payload += conversions.unsigned_byte_to_bytearray   (fpga_major       )
     payload += conversions.unsigned_byte_to_bytearray   (fpga_minor       )
     payload += conversions.unsigned_byte_to_bytearray   (fpga_lab         )
     payload += conversions.unsigned_integer_to_bytearray(compatibility_rev)

     message = CAN.CanMessage.build_message(
                                         channel_id=CAN.CanChannels.fp_sync_broadcast_ch_id,
                                         message_id=msg_ids.MsgIds.MSG_ID_FP_VERSION_RESPONSE.value,
                                         payload=payload)

     self.can_interface.send(message, 0)

LEAHI-DIALIN-LDT-4484-1: comment by Zoltan Miskolci "Being generic is the whole point of it. It was..."

Zoltan Miskolci — Mon, 29 Jun 2026 09:28:46 -0700

Zoltan Miskolci replied to Behrouz NematiPour in LEAHI-DIALIN-LDT-4484-1

Being generic is the whole point of it.
It was renamed because this is a dialin dedicated to Leahi unit and calling the messages DenaliMessage is misleading.
It was renamed to CanMessage for 2 reason:
1. This is a Leahi only dialin, so there is no need to differentiate between different type of Can Messages as there would be only 1 type
2. Calling it CanMessage will make it more future compatible when the dialin get copied over for a new unit development (unlikely in the foreseeable future but possible), removing the need to rename it again

LEAHI-DIALIN-LDT-4484-1: comment by Zoltan Miskolci "There is no Leahi or Denali CANChannels. There..."

Zoltan Miskolci — Mon, 29 Jun 2026 09:40:38 -0700

Zoltan Miskolci replied to Behrouz NematiPour in LEAHI-DIALIN-LDT-4484-1

There is no Leahi or Denali CANChannels.
There are CAN channels and the naming is what that channel is being used for.
The collision occurs in the FW and the FW handles it before sending out a message.
When reading a CAN, there are no collisions, so there are no priorities. So I have no clue what you want here.

LEAHI-DIALIN-LDT-4484-1: comment by Zoltan Miskolci "done"

Zoltan Miskolci — Mon, 29 Jun 2026 09:39:48 -0700

Zoltan Miskolci replied to Behrouz NematiPour in LEAHI-DIALIN-LDT-4484-1

done

LEAHI-DIALIN-LDT-4484-1: comment by Zoltan Miskolci "I have no idea what you are referring to as the..."

Zoltan Miskolci — Mon, 29 Jun 2026 09:35:17 -0700

Zoltan Miskolci replied to Behrouz NematiPour in LEAHI-DIALIN-LDT-4484-1

I have no idea what you are referring to as the link is not working.
The need to define the type and the name of the data being read is necessary, so if it's not here it will be somewhere else, that we can't escape.
Exporting that to different files won't serve a purpose and will only increase complexity as when debugging you will need to reference a separate file.
For the defs it made sense as they are used multiple places, but what a message contains is a single use place, so storing it separately is meaningless as it won't have any use outside of this single function.

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "I am happy to see that this old code is improvi..."

Behrouz NematiPour — Thu, 25 Jun 2026 17:33:21 -0700

Behrouz NematiPour commented on LEAHI-DIALIN-LDT-4484-1

I am happy to see that this old code is improving.
I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically.
Examples can be found in the following file in this CR:
https://devapps.diality.us/cru/#LEAHI-DIALIN-LDT-4484-1CFR-84688

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "Please add a docstring for the function. inclu..."

Behrouz NematiPour — Thu, 25 Jun 2026 17:18:50 -0700

Behrouz NematiPour commented on LEAHI-DIALIN-LDT-4484-1

Please add a docstring for the function.
including the intention and parameters with their intentions.

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "Same for CanChannels. The Channels we are refe..."

Behrouz NematiPour — Thu, 25 Jun 2026 17:16:40 -0700

Behrouz NematiPour commented on LEAHI-DIALIN-LDT-4484-1

Same for CanChannels.
The Channels we are referring to here are Leahi's or Denali's.
Channels mainly have no meaning beyond their priorities when a collision occurs.

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "I recommend DenaliMessage or LeahiMessage, as C..."

Behrouz NematiPour — Thu, 25 Jun 2026 16:00:32 -0700

Behrouz NematiPour commented on LEAHI-DIALIN-LDT-4484-1

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending.
I'm not sure why the name was changed, as it is a lot of change.
Also, there is no CAN Message.
There is a CAN Frame and a Leahi/Denali Message.

LEAHI-DIALIN-LDT-4484-1: comment by Zoltan Miskolci "updated"

Zoltan Miskolci — Tue, 23 Jun 2026 10:40:49 -0700

Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-4484-1

updated

LEAHI-DIALIN-LDT-4484-1: comment by Raghu Kallala "Remove extra spaces before comment"

Raghu Kallala — Tue, 23 Jun 2026 10:31:47 -0700

Raghu Kallala commented on LEAHI-DIALIN-LDT-4484-1

Remove extra spaces before comment

LEAHI-DIALIN-LDT-4484-1: reviewers left LEAHI-DIALIN-LDT-4484_[Dialin] Create Dry Self Tes...

Thu, 11 Jun 2026 13:30:43 -0700

Sean Nash left LEAHI-DIALIN-LDT-4484-1

LEAHI-DIALIN-LDT-4484_[Dialin] Create Dry Self Test module in dialin

LEAHI-DIALIN-LDT-4484-1: started by Dara Navaei

Dara Navaei — Mon, 08 Jun 2026 11:20:24 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-4484-1

LEAHI-DIALIN-LDT-3904-1: closed by Zoltan Miskolci

Zoltan Miskolci — Mon, 01 Jun 2026 16:20:43 -0700

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3904-1

LEAHI-DIALIN-LDT-3904-1: reviewers finished

Mon, 01 Jun 2026 08:01:21 -0700

Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3904-1

LEAHI-DIALIN-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes

LEAHI-DIALIN-LDT-3904-1: reviewers finished

Fri, 29 May 2026 10:05:00 -0700

Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-3904-1

LEAHI-DIALIN-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes

LEAHI-DIALIN-LDT-3904-1: comment by Zoltan Miskolci "references to Denali has been removed"

Zoltan Miskolci — Thu, 21 May 2026 17:09:11 -0700

Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-3904-1

references to Denali has been removed

leahi-dialin (LDT-4733-request-add-variables): Removed Denali reference

Zoltan Miskolci — Thu, 21 May 2026 11:31:31 -0700

Zoltan Miskolci committed 1f2bf6d on branch LDT-3735-non-volatile-memory, LDT-4001-hdf---fw-implementation-2-4 and 33 more in leahi-dialin

Removed Denali reference

· /CHANGELOG.md

(-2, +2)

| History

| Source

| Diff

· /README.md

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/common/msg_defs.py

(-3, +3)

| History

| Source

| Diff

· /leahi_dialin/common/override_templates.py

(-9, +9)

| History

| Source

| Diff

· /leahi_dialin/dd/dialysate_delivery.py

(-12, +12)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/alarms.py

(-10, +10)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/balancing_chamber.py

(-9, +9)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/blood_leak.py

(-12, +12)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/concentrate_pump.py

(-11, +11)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/conductivity_sensors.py

(-11, +11)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dd_test_configs.py

(-7, +7)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dialysate_pump.py

(-11, +11)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/drybicart.py

(-10, +10)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/events.py

(-5, +5)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/gen_dialysate.py

(-10, +10)

| History

| Source

| Diff

… 61 more files in changeset.

LEAHI-DIALIN-LDT-3904-1: comment by Raghu Kallala "Shouldn't we use Leahi instead of Denali?"

Raghu Kallala — Thu, 21 May 2026 07:44:38 -0700

Raghu Kallala commented on LEAHI-DIALIN-LDT-3904-1

Shouldn't we use Leahi instead of Denali?

leahi-dialin (LDT-4733-request-add-variables): - Updated DD and TD module - Updaterd TDValvePosition enum

Zoltan Miskolci — Tue, 05 May 2026 14:25:28 -0700

Zoltan Miskolci committed 34b64ff on branch LDT-3735-non-volatile-memory, LDT-4001-hdf---fw-implementation-2-4 and 33 more in leahi-dialin

- Updated DD and TD module - Updaterd TDValvePosition enum

· /leahi_dialin/common/td_defs.py

(-6, +8)

| History

| Source

| Diff

· /leahi_dialin/dd/dialysate_delivery.py

(-8, +4)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/balancing_chamber.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/blood_leak.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/concentrate_pump.py

(-27, +26)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/conductivity_sensors.py

(-7, +6)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dialysate_pump.py

(-22, +21)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/drybicart.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/gen_dialysate.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/heaters.py

(-11, +10)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/levels.py

(-6, +4)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/post_gen_dialysate.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/pre_gen_dialysate.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/pressure_sensors.py

(-7, +6)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/rinse_pump.py

(-1, +0)

| History

| Source

| Diff

… 40 more files in changeset.

LEAHI-DIALIN-LDT-3904-1: started by Dara Navaei

Dara Navaei — Mon, 04 May 2026 17:46:48 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-3904-1

leahi-dialin (LDT-4733-request-add-variables): - DD refactor Changes in FP and TD module

Zoltan Miskolci — Mon, 04 May 2026 17:24:48 -0700

Zoltan Miskolci committed f03c9a3 on branch LDT-3735-non-volatile-memory, LDT-4001-hdf---fw-implementation-2-4 and 33 more in leahi-dialin

- DD refactor Changes in FP and TD module

· /leahi_dialin/fp/filtration_purification.py

(-1, +2)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/alarms.py

(-7, +8)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/boost_pump.py

(-3, +4)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/conductivity_sensors.py

(-3, +4)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/events.py

(-17, +17)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/flow_sensors.py

(-3, +4)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/fp_test_configs.py

(-4, +4)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/levels.py

(-3, +4)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/permeate_tank.py

(-3, +4)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/pressure_sensors.py

(-3, +4)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/ro_pump.py

(-3, +4)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/temperatures.py

(-3, +4)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/valves.py

(-3, +4)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/water_pumps.py

(-3, +3)

| History

| Source

| Diff

· /leahi_dialin/fp/proxies/dd_proxy.py

(-2, +2)

| History

| Source

| Diff

… 18 more files in changeset.

LEAHI-DIALIN-LDT-3557-1: closed by Zoltan Miskolci

Zoltan Miskolci — Thu, 05 Mar 2026 10:46:36 -0800

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3557-1