updated

APPROVED.

RESOLVED.
Added another comment regarding the same.

Nicholas Ramirez
Thanks for the change to the ok and result.

• To be consistent, could you please use ok instead of result, since all the other parts of the code use ok as an argument, and the function itself has ok as the parameter name.
• Also move the:

  ; if ( ! ok ) { goto invalid; }
  

  on the "same line" and "aligned" as the evaluating parameter, to keep the code clean.

APPROVED

updated

updated

updated

remove the ok and just check result and if any fails goto invalid

see if you can use payloadLen from MessageGlobals.h

double check

removedin https://devapps.diality.us/cru/#LEAHI-APPLICATION-LDT-5331-1CFR-87504

remove from prime // priming - TODO check if needed. may not need

BN approves

BN approves

BN approves

BN approves

updated

combined files

fixed

updated

address cr comments

· /leahi.pro	(-2, +0)	| History	| Source	| Diff
· /sources/ApplicationController.cpp	(-5, +16)	| History	| Source	| Diff
· /sources/ApplicationController.h	(-0, +1)	| History	| Source	| Diff
· /sources/gui/GuiGlobals.cpp	(-1, +0)	| History	| Source	| Diff
· /sources/gui/qml/components/HeaderBar.qml	(-0, +1)	| History	| Source	| Diff
· /sources/gui/qml/dialogs/watersample/WaterSampleDialog.qml	(-5, +5)	| History	| Source	| Diff
· /sources/gui/qml/main.qml	(-2, +0)	| History	| Source	| Diff
· /sources/gui/qml/pages/settings/SettingsInformation.qml	(-1, +1)	| History	| Source	| Diff
· /sources/gui/qml/pages/settings/SettingsROInput.qml	(-4, +4)	| History	| Source	| Diff
· /sources/model/dd/adjustment/settings/MRoWaterModeResponse.cpp	(-3, +3)	| History	| Source	| Diff
· /sources/model/dd/adjustment/settings/MRoWaterModeResponse.h	(-3, +3)	| History	| Source	| Diff
· /sources/view/VView.h	(-1, +0)	| History	| Source	| Diff
· /sources/view/VWaterSampleModel.cpp	(-2, +2)	| History	| Source	| Diff
· /sources/view/VWaterSampleModel.h	(-1, +8)	| History	| Source	| Diff
· /sources/view/settings/VAdjustRoWaterMode.cpp	(-32, +0)	| History	| Source	| Diff
… 3 more files in changeset.

]]> Thu, 06 Aug 2026 15:50:26 -0700 Nicholas Ramirez https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5074-3/#c31100 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5074-3/#c31100 Nicholas Ramirez commented on LEAHI-APPLICATION-LDT-5074-3

fix bug that was fixed in develop branch

combine views - Move adjustRO watermode into here

change mValue to mStatus

bn approves