Ok, sounds good.

RESOLVED

Good point,
I agree with the two intervals, it would be clarifying.
For the counter, though, it might not be always the case.
I will start doing it in my next task, since I would like to change all, to be consistent across the entire code base.

Only a suggestion:
It is a good idea to append the unit to the end of the variable name especially for time. It helps improve readability and clarity.

For instance, here, we have ms and the next one, _pendingInterval is in seconds. and I believe _pendingCounter is in minutes based on the .cpp file's comment.

_interval_ms
_pendingInterval_sec
_pendingCounter_min

RESOLVED

Thanks for the feedback.
Fixed.

The variable, destination, itself is a QString, you don't need to do QString("%1").arg(destination), you can pass destination in directly.

RESOLVED.

Sure Sean, if that is the decision, will do it soon and create a case for that.
I also believe some other CL Switches need to be removed, which were only implemented for our testing at the time (CANBus).

Issue DEN-13441 - MR: Make the Dialin log permanent with no switch [CL switches review/removal] has been successfully created

If this is to log Dialin messages, we should always do that (no switch). If a Dialin command is given/responded to, we definitely want to know about that - so want to see it in the log. Dialin commands are always one-shot type messages, so will not impact log size.

RESOLVED.

RESOLVED.

RESOLVED

This code is going to be used later in the Log Export for slow transfer & confirmation for the USB port slow transfer issue.
I kept it in the application repo to keep it safe.
Commented out to not affect the coverage.

http://dvm-linux02:8060/cru/#UI-DEN-12716-2CFR-30978
in PostTreatmentReview.qml@40