No, that will cause an error on pip

· /build.sh

(-3, +3)

| History

| Source

| Diff

]]> Wed, 01 Jul 2026 10:27:37 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4878-1/#c30289 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4878-1/#c30289 Dara Navaei commented on LEAHI-DIALIN-LDT-4878-1

Please leave a comment to remind the developers that "-" will confuse .whl.

Should this be "." instead of "-" to be consistent?

Is this .wsl or .whl?

· /build.sh

(-3, +3)

| History

| Source

| Diff

]]> Wed, 01 Jul 2026 09:35:15 -0700 Zoltan Miskolci https://devapps.diality.us/changelog/leahi-dialin?cs=8efa9d8eb51bb0ad26493acdb9db739c3a8338b0 https://devapps.diality.us/changelog/leahi-dialin?cs=8efa9d8eb51bb0ad26493acdb9db739c3a8338b0 Zoltan Miskolci committed 8efa9d8 on branch LDT-4614-dialysate-composition-mixing-algo-integration-with-td-proxy, LDT-4733-request-add-variables and 11 more in leahi-dialin fix

· /build.sh

(-3, +1)

| History

| Source

| Diff

]]> Wed, 01 Jul 2026 09:29:10 -0700 Zoltan Miskolci https://devapps.diality.us/changelog/leahi-dialin?cs=230095218088ec691b15c63393c7bc1d51ed9ab3 https://devapps.diality.us/changelog/leahi-dialin?cs=230095218088ec691b15c63393c7bc1d51ed9ab3 Zoltan Miskolci committed 2300952 on branch LDT-4614-dialysate-composition-mixing-algo-integration-with-td-proxy, LDT-4733-request-add-variables and 11 more in leahi-dialin fix

· /build.sh	(-0, +1)	| History	| Source	| Diff
· /leahi_dialin/version.py	(-1, +1)	| History	| Source	| Diff

]]> Mon, 29 Jun 2026 11:20:27 -0700 Zoltan Miskolci https://devapps.diality.us/changelog/leahi-dialin?cs=98d23618919a0412046b9589c2b22bd1095af497 https://devapps.diality.us/changelog/leahi-dialin?cs=98d23618919a0412046b9589c2b22bd1095af497 Zoltan Miskolci committed 98d2361 on branch LDT-3735-non-volatile-memory, LDT-4505 and 16 more in leahi-dialin Updated build.sh

· /build.sh

(-6, +13)

| History

| Source

| Diff

]]> Mon, 29 Jun 2026 11:01:24 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4878-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4878-1 Dara Navaei started review LEAHI-DIALIN-LDT-4878-1 ]]> Thu, 11 Jun 2026 13:30:14 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3735-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3735-1 Sean Nash left LEAHI-DIALIN-LDT-3735-1 LEAHI-DIALIN-LDT-3735_System Data and Logs - DD - Non-Volatile Memory - 04: DEV - Feature Implementation ]]> Wed, 03 Jun 2026 17:02:29 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3735-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3735-1 Dara Navaei started review LEAHI-DIALIN-LDT-3735-1 ]]> Mon, 09 Feb 2026 10:34:41 -0800 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1 Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3350-1 ]]> Sat, 07 Feb 2026 16:46:15 -0800 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1 Dara Navaei finished reviewing LEAHI-DIALIN-LDT-3350-1 LEAHI-DIALIN-LDT-3350_[Leahi-Dialin] Add from_str function to the enums ]]> Fri, 06 Feb 2026 09:23:57 -0800 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1/#c27081 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1/#c27081 Zoltan Miskolci replied to Dara Navaei in LEAHI-DIALIN-LDT-3350-1

We agreed to change back the enums into the static variation.
Why would that cover a class that has been implemented to mask the enums from direct access, so if they need to be changed to dynamic or renamed or anything, the other repositories that are using them through this class won't be affected or need any update.

Did we not decide to revert all the changes back and the redesign the whole concept again?

· /build.sh

(-1, +1)

| History

| Source

| Diff

]]> Tue, 03 Feb 2026 15:55:46 -0800 Behrouz NematiPour https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1/#c26993 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1/#c26993 Behrouz NematiPour replied to Behrouz NematiPour in LEAHI-DIALIN-LDT-3350-1

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

This design is incorrect,
For common codes, a proxy or a wrapper class should have been implemented.
We will keep it for now to unblock the rest of the team.

This is incorrect.
We should not create many objects for all the Enum classes in an API, and we should not use memory that may not even be in use.
We will keep it for now to unblock the rest of the team.

When building locally without all the parameters the generated name throws an error during python pip install.
So this ensures that if no parameter is added, it uses the default name which is compatible with pip install.
The " -+. " sequence is throwing an error.

removed commented out line

It's a class containing all the enums of the def file.
Yes we need them as many other Framework and huge amount of code are using them.

Obviously not.
You were reminding me about backwards compatibility. This variable and class ensures that even with this major refactor to the enum structure, the current codebase remains working.