Fisheye on application/sources/model/dg/data/MDGConductivityData.cpp

UI-DEN-12031-2: closed by Dara Navaei

Dara Navaei — Tue, 19 Nov 2024 15:27:58 -0800

Dara Navaei Closed UI-DEN-12031-2

UI-DEN-12031-2: reviewers finished

Tue, 19 Nov 2024 13:54:25 -0800

Behrouz NematiPour and Dara Navaei finished reviewing UI-DEN-12031-2

UI-DEN-12031_Leahi/Features/Den 12031 UI AM Models Nested Ifs

UI-DEN-12031-2: started by Dara Navaei

Dara Navaei — Tue, 19 Nov 2024 13:27:27 -0800

Dara Navaei started review UI-DEN-12031-2

UI-DEN-SUNRISE-1: closed by Dara Navaei

Dara Navaei — Fri, 15 Nov 2024 12:54:28 -0800

Dara Navaei Closed UI-DEN-SUNRISE-1

UI-DEN-SUNRISE-1: reviewers removed from UI-DEN-SUNRISE

Fri, 07 Jun 2024 09:05:01 -0700

Dara Navaei removed Sean Nash and vduong (deleted user) from UI-DEN-SUNRISE-1

UI-DEN-SUNRISE

UI-DEN-SUNRISE-1: started by Dara Navaei

Dara Navaei — Fri, 07 Jun 2024 09:04:34 -0700

Dara Navaei started review UI-DEN-SUNRISE-1

application (DEN-16553-UI-BN-WPA3-Support): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 24 Jan 2024 14:28:27 -0800

Dara Navaei committed 2ef03b2 on branch master, @Environement_Swith and 61 more in application

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /alarmMapping.sh

(-1, +1)

| History

| Source

| Diff

· /cho.sh

(-1, +1)

| History

| Source

| Diff

· /cppcheck.sh

(-1, +1)

| History

| Source

| Diff

· /cr_objectives.sh

(-1, +1)

| History

| Source

| Diff

· /imake.sh

(-1, +1)

| History

| Source

| Diff

· /main.cpp

(-2, +2)

| History

| Source

| Diff

· /remove-exra-emptylines.sh

(-1, +1)

| History

| Source

| Diff

· /sources/AlarmGenerator.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/AlarmGenerator.h

(-1, +1)

| History

| Source

| Diff

· /sources/ApplicationController.cpp

(-2, +2)

| History

| Source

| Diff

· /sources/ApplicationController.h

(-1, +1)

| History

| Source

| Diff

· /sources/ApplicationPost.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/ApplicationPost.h

(-1, +1)

| History

| Source

| Diff

· /sources/MainTimer.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/MainTimer.h

(-1, +1)

| History

| Source

| Diff

… 598 more files in changeset.

UI-DEN-12121-1: closed by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 11:03:57 -0700

Dara Navaei Closed UI-DEN-12121-1

UI-DEN-12121-1: reviewers finished

Thu, 19 Oct 2023 11:03:44 -0700

Dara Navaei finished reviewing UI-DEN-12121-1

UI-DEN-12121_SW Dev Sprint 65

UI-DEN-12121-1: comment by Dara Navaei "RESOLVED"

Dara Navaei — Thu, 19 Oct 2023 11:03:35 -0700

Dara Navaei replied to Behrouz NematiPour in UI-DEN-12121-1

RESOLVED

UI-DEN-12121-1: started by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 11:02:21 -0700

Dara Navaei started review UI-DEN-12121-1

UI-DEN-12121-1: comment by Dara Navaei "RESOLVED"

Dara Navaei — Thu, 19 Oct 2023 10:39:08 -0700

Dara Navaei replied to Behrouz NematiPour in UI-DEN-12121-1

RESOLVED

UI-DEN-14936-1: closed by Behrouz NematiPour

Behrouz NematiPour — Fri, 31 Mar 2023 14:17:31 -0700

Behrouz NematiPour Closed UI-DEN-14936-1

UI-DEN-14936-1: reviewers finished

Fri, 31 Mar 2023 06:56:15 -0700

jishii (deleted user) finished reviewing UI-DEN-14936-1

UI-DEN-14936_UI BN S93

application (bugfix/DEN-16597-UI-BN-S114): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 30 Mar 2023 18:22:13 -0700

Dara Navaei committed 53b262f on branch master, @Environement_Swith and 164 more in application

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /main.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/MessageDispatcher.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/MessageGlobals.h

(-1, +1)

| History

| Source

| Diff

· /sources/gui/GuiGlobals.h

(-1, +1)

| History

| Source

| Diff

· /sources/gui/qml/components/DebugDataColumn.qml

(-1, +1)

| History

| Source

| Diff

· /sources/gui/qml/dialogs/DiagnosticsDialog.qml

(-1, +1)

| History

| Source

| Diff

· /sources/gui/qml/globals/Fonts.qml

(-2, +2)

| History

| Source

| Diff

· /sources/gui/qml/pages/endtreatment/EndTreatmentRinsebackStack.qml

(-1, +1)

| History

| Source

| Diff

· /sources/model/dg/adjustment/settings/MAdjustDGRequests.h

(-1, +1)

| History

| Source

| Diff

· /sources/model/dg/adjustment/settings/MAdjustDGServiceDatesResponse.h

(-1, +1)

| History

| Source

| Diff

· /sources/model/dg/data/MDGConductivityData.cpp

(-2, +2)

| History

| Source

| Diff

· /sources/model/dg/data/MDGConductivityData.h

(-1, +1)

| History

| Source

| Diff

· /sources/model/dg/data/MDGDrainPumpData.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/model/dg/data/MDGDrainPumpData.h

(-1, +1)

| History

| Source

| Diff

· /sources/model/dg/data/MDGROPumpData.cpp

(-2, +2)

| History

| Source

| Diff

… 43 more files in changeset.

UI-DEN-14936-1: reviewers finished

Thu, 30 Mar 2023 17:59:12 -0700

Sean Nash finished reviewing UI-DEN-14936-1

UI-DEN-14936_UI BN S93

UI-DEN-14936-1: comment by Sean Nash "RESOLVED."

Sean Nash — Thu, 30 Mar 2023 17:58:59 -0700

Sean Nash replied to Behrouz NematiPour in UI-DEN-14936-1

RESOLVED.

UI-DEN-14936-1: comment by Behrouz NematiPour "Thanks, Will update my comment."

Behrouz NematiPour — Thu, 30 Mar 2023 17:41:33 -0700

Behrouz NematiPour replied to Sean Nash in UI-DEN-14936-1

Thanks,
Will update my comment.

UI-DEN-14936-1: comment by Sean Nash "RESOLVED."

Sean Nash — Thu, 30 Mar 2023 17:31:14 -0700

Sean Nash replied to Behrouz NematiPour in UI-DEN-14936-1

RESOLVED.

UI-DEN-14936-1: comment by Sean Nash "RESOLVED."

Sean Nash — Thu, 30 Mar 2023 17:30:49 -0700

Sean Nash replied to Behrouz NematiPour in UI-DEN-14936-1

RESOLVED.

UI-DEN-14936-1: comment by Sean Nash "Your comment has ???. Trying to help."

Sean Nash — Thu, 30 Mar 2023 17:30:24 -0700

Sean Nash replied to Behrouz NematiPour in UI-DEN-14936-1

Your comment has ???. Trying to help.

UI-DEN-14936-1: comment by Behrouz NematiPour "Fixed too."

Behrouz NematiPour — Thu, 30 Mar 2023 01:07:18 -0700

Behrouz NematiPour replied to Sean Nash in UI-DEN-14936-1

Fixed too.

UI-DEN-14936-1: comment by Behrouz NematiPour "Great catch, Thank a lot Sean for catching tha..."

Behrouz NematiPour — Thu, 30 Mar 2023 01:07:04 -0700

Behrouz NematiPour replied to Sean Nash in UI-DEN-14936-1

Great catch,
Thank a lot Sean for catching that.
It is fixed.

application (bugfix/DEN-16597-UI-BN-S114): CR: Addressing Code Review comment UI-DEN-14936-1#c16983...

Behrouz NematiPour — Thu, 30 Mar 2023 01:06:02 -0700

Behrouz NematiPour committed 5d13e39 on branch master, @Environement_Swith and 165 more in application

CR: Addressing Code Review comment UI-DEN-14936-1#c16983

http://devapps.diality.us:8060/cru/UI-DEN-14936-1#c16983

· /sources/model/dg/data/MDGConductivityData.cpp	(-40, +40)	\| History	\| Source	\| Diff
· /sources/model/dg/data/MDGConductivityData.h	(-1, +1)	\| History	\| Source	\| Diff

UI-DEN-14936-1: comment by Behrouz NematiPour "Not clear what you want me to do here?"

Behrouz NematiPour — Thu, 30 Mar 2023 01:04:55 -0700

Behrouz NematiPour replied to Sean Nash in UI-DEN-14936-1

Not clear what you want me to do here?

UI-DEN-14936-1: comment by Sean Nash "In post-treatment, there are a few states to wo..."

Sean Nash — Wed, 29 Mar 2023 15:46:51 -0700

Sean Nash commented on UI-DEN-14936-1

In post-treatment, there are a few states to work through to ensure reservoirs get drained:

/* Post-Treatment drain reservoirs state machine. */
typedef enum Drain_States
{
DRAIN_DG_DEPRIME_STATE = 0, ///< Drain DG De-prime dialysate lines of excess fluid state.
DRAIN_RESERVOIR_SWITCH_STATE, ///< Switch reservoir state.
DRAIN_RESERVOIR_START_DRAIN_STATE, ///< Drain reservoir start drain state.
DRAIN_RESERVOIR_DRAIN_STATE, ///< Drain first reservoir state.
DRAIN_RESERVOIR_COMPLETE_STATE, ///< Drain complete state.
NUM_OF_DRAIN_STATES ///< Number of drain states.
} DRAIN_STATE_T;

UI-DEN-14936-1: comment by Sean Nash "Same ordering should apply here (even if order ..."

Sean Nash — Wed, 29 Mar 2023 15:28:41 -0700

Sean Nash commented on UI-DEN-14936-1

Same ordering should apply here (even if order doesn't matter - prefer to match structure of message payload).

UI-DEN-14936-1: comment by Sean Nash "I think the raw order should be cpi, cpo, cd1, ..."

Sean Nash — Wed, 29 Mar 2023 15:26:47 -0700

Sean Nash commented on UI-DEN-14936-1

I think the raw order should be cpi, cpo, cd1, cd2 (reverse of what's here). Same order issue with status below.

application (bugfix/DEN-16597-UI-BN-S114): DEN-14853 UI Out Of Sync With Firmware On Handled Messages

Behrouz NematiPour — Fri, 24 Mar 2023 05:14:41 -0700

Behrouz NematiPour committed 95c2b1e on branch master, @Environement_Swith and 165 more in application

DEN-14853 UI Out Of Sync With Firmware On Handled Messages

· /sources/canbus/MessageGlobals.h	(-1, +1)	\| History	\| Source	\| Diff
· /sources/gui/qml/dialogs/DiagnosticsDialog.qml	(-8, +24)	\| History	\| Source	\| Diff
· /sources/model/dg/adjustment/settings/MAdjustDGRequests.h	(-1, +1)	\| History	\| Source	\| Diff
· /sources/model/dg/adjustment/settings/MAdjustDGServiceDatesResponse.h	(-1, +1)	\| History	\| Source	\| Diff
· /sources/model/dg/data/MDGConductivityData.cpp	(-0, +32)	\| History	\| Source	\| Diff
· /sources/model/dg/data/MDGConductivityData.h	(-10, +35)	\| History	\| Source	\| Diff
· /sources/model/hd/data/treatmentlog/MTreatmentLogEventData.h	(-1, +1)	\| History	\| Source	\| Diff
· /sources/view/dg/data/VDGConductivityData.cpp	(-6, +13)	\| History	\| Source	\| Diff
· /sources/view/dg/data/VDGConductivityData.h	(-0, +8)	\| History	\| Source	\| Diff

UI-DEN-14936-1: started by Behrouz NematiPour

Behrouz NematiPour — Tue, 21 Mar 2023 04:25:05 -0700

Behrouz NematiPour started review UI-DEN-14936-1