UI-DEN-12121-1 UI-DEN-12121_SW Dev Sprint 65

closed on 19 Oct 23

Author

Moderator

Reviewers

UI-DEN-12121_SW Dev Sprint 65

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 44

application 0
- Folder sources 0
  - Folder canbus 0
    - File MessageGlobals.h 6 Remove
    - File MessageInterpreter.cpp 0 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder dialogs 0
        
        File DiagnosticsDialog.qml 14 Remove
      - Folder pages/endtreatment/rinseback 0
        
        File EndTreatmentRinsebackComplete.qml 0 Remove
      - File AlarmItem.qml 0 Remove
      - File main.qml 7 Remove
    - File GuiGlobals.cpp 0 Remove
    - File GuiGlobals.h 3 Remove
  - Folder model 0
    - Folder dg 0
      - Folder adjustment/settings 0
        
        File MAdjustDGVersionsResponse.cpp 0 Remove
        
        File MAdjustDGVersionsResponse.h 0 Remove
      - Folder data 0
        
        File MDGConductivityData.cpp 0 Remove
        
        File MDGConductivityData.h 3 Remove
        
        File MDGValvesStatesData.h 0 Remove
    - Folder hd 0
      - Folder adjustment/settings 0
        
        File MAdjustHDVersionsResponse.cpp 0 Remove
        
        File MAdjustHDVersionsResponse.h 0 Remove
      - Folder alarm 0
        
        File MAlarmMapping.cpp 0 Remove
      - Folder data 0
        
        Folder treatment 0
        
        File MTreatmentRinsebackData.cpp 0 Remove
        
        File MTreatmentRinsebackData.h 2 Remove
        
        File MTreatmentStatesData.cpp 0 Remove
        
        File MTreatmentStatesData.h 3 Remove
        
        File MHDAirBubbleData.cpp 0 Remove
        
        File MHDAirBubbleData.h 5 Remove
        
        File MHDAirTrapData.cpp 0 Remove
        
        File MHDAirTrapData.h 4 Remove
        
        File MHDBloodLeakData.cpp 0 Remove
        
        File MHDBloodLeakData.h 5 Remove
    - File MModel.h 0 Remove
  - Folder view 0
    - Folder dg/data 0
      - File VDGConductivityData.cpp 0 Remove
      - File VDGConductivityData.h 2 Remove
      - File VDGValvesStatesData.cpp 0 Remove
      - File VDGValvesStatesData.h 2 Remove
    - Folder hd/data 0
      - Folder treatment 0
        
        File VTreatmentRinsebackData.cpp 0 Remove
        
        File VTreatmentRinsebackData.h 2 Remove
      - File VHDAirBubbleData.cpp 2 Remove
      - File VHDAirBubbleData.h 2 Remove
      - File VHDAirTrapData.cpp 2 Remove
      - File VHDAirTrapData.h 2 Remove
      - File VHDBloodLeakData.cpp 0 Remove
      - File VHDBloodLeakData.h 2 Remove
    - Folder settings 0
      - File VAdjustmentVersions.cpp 0 Remove
      - File VAdjustmentVersions.h 0 Remove
    - File VView.h 0 Remove
- File denali.pro 0 Remove
- File denali.pro.user 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Michael Garthwaite	Author & Moderator	25m	7	Fixed. Thanks!
Sean Nash	Reviewer - 100% reviewed	10m	1	Let's keep it.
Dara Navaei	Reviewer - Complete	35m	2	RESOLVED
Behrouz NematiPour	Reviewer - Complete	3h 39m	58	RESOLVED I fixed it in my own branch and merged it into t...
Total		4h 50m	68

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

UI-DEN-12121-1

UI-DEN-12121_SW Dev Sprint 65

UI-DEN-12121-1 68

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

UI-DEN-12121_SW Dev Sprint 65

UI-DEN-12121-1 68

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time