Fisheye on dgfirmware/firmware/dg_build_history.log https://devapps.diality.us/changelog/~br%3Dmaster/dgfirmware/firmware/dg_build_history.log Recent activity in "dgfirmware" under directory /firmware/dg_build_history.log DG-DEN-14902-1: closed by Dara Navaei Fri, 15 Nov 2024 12:53:35 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14902-1 https://devapps.diality.us/cru/DG-DEN-14902-1 Dara Navaei Closed DG-DEN-14902-1 ]]> DG-DEN-9480-1: closed by Dara Navaei Thu, 19 Oct 2023 08:05:20 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-9480-1 https://devapps.diality.us/cru/DG-DEN-9480-1 Dara Navaei Closed DG-DEN-9480-1 ]]> DG-DEN-9480-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:05:10 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-9480-1/#c19092 https://devapps.diality.us/cru/DG-DEN-9480-1/#c19092 Dara Navaei replied to Sean Nash in DG-DEN-9480-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-9480-1: started by Dara Navaei Thu, 19 Oct 2023 08:03:54 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-9480-1 https://devapps.diality.us/cru/DG-DEN-9480-1 Dara Navaei started review DG-DEN-9480-1 ]]> DG-DEN-14902-1: comment by wbracken "Includes should be in alphabetical order." Tue, 16 May 2023 17:32:52 -0700 wbracken https://devapps.diality.us/cru/DG-DEN-14902-1/#c17621 https://devapps.diality.us/cru/DG-DEN-14902-1/#c17621 wbracken  (deleted user) commented on DG-DEN-14902-1

Includes should be in alphabetical order.

]]> DG-DEN-15336-1: closed by wbracken Mon, 15 May 2023 13:53:03 -0700 wbracken https://devapps.diality.us/cru/DG-DEN-15336-1 https://devapps.diality.us/cru/DG-DEN-15336-1 wbracken  (deleted user) Closed DG-DEN-15336-1 ]]> DG-DEN-15336-1: reviewers finished Mon, 15 May 2023 13:52:30 -0700 https://devapps.diality.us/cru/DG-DEN-15336-1 https://devapps.diality.us/cru/DG-DEN-15336-1 jtaylor  (deleted user) , dcox  (deleted user) and Sean Nash finished reviewing DG-DEN-15336-1 DG-DEN-15336_FW Add Framing Error FE And Overrun Error OE TO DG TO Fpga Communications ]]> DG-DEN-14902-1: comment by jtaylor "Introducing build flags seems like a bad idea. ..." Mon, 15 May 2023 08:34:36 -0700 jtaylor https://devapps.diality.us/cru/DG-DEN-14902-1/#c17527 https://devapps.diality.us/cru/DG-DEN-14902-1/#c17527 jtaylor  (deleted user) commented on DG-DEN-14902-1

Introducing build flags seems like a bad idea. Are these temporary tests?

]]> DG-DEN-15336-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 15 May 2023 08:17:20 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15336-1/#c17526 https://devapps.diality.us/cru/DG-DEN-15336-1/#c17526 Sean Nash replied to wbracken  (deleted user) in DG-DEN-15336-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-15336-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 15 May 2023 08:17:10 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15336-1/#c17525 https://devapps.diality.us/cru/DG-DEN-15336-1/#c17525 Sean Nash replied to wbracken  (deleted user) in DG-DEN-15336-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-15336-1: comment by wbracken "Removed" Sun, 14 May 2023 19:46:50 -0700 wbracken https://devapps.diality.us/cru/DG-DEN-15336-1/#c17524 https://devapps.diality.us/cru/DG-DEN-15336-1/#c17524 wbracken  (deleted user) replied to Sean Nash in DG-DEN-15336-1

Removed

]]> DG-DEN-15336-1: comment by wbracken "Removed" Sun, 14 May 2023 19:46:39 -0700 wbracken https://devapps.diality.us/cru/DG-DEN-15336-1/#c17523 https://devapps.diality.us/cru/DG-DEN-15336-1/#c17523 wbracken  (deleted user) replied to Sean Nash in DG-DEN-15336-1

Removed

]]> DG-DEN-15336-1: comment by Sean Nash "Remove blank line." Sun, 14 May 2023 17:24:08 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15336-1/#c17504 https://devapps.diality.us/cru/DG-DEN-15336-1/#c17504 Sean Nash commented on DG-DEN-15336-1

Remove blank line.

]]> DG-DEN-15336-1: comment by Sean Nash "Remove blank line." Sun, 14 May 2023 17:23:48 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15336-1/#c17503 https://devapps.diality.us/cru/DG-DEN-15336-1/#c17503 Sean Nash commented on DG-DEN-15336-1

Remove blank line.

]]> DG-DEN-15336-1: started by Dara Navaei Sat, 13 May 2023 22:01:52 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-15336-1 https://devapps.diality.us/cru/DG-DEN-15336-1 Dara Navaei started review DG-DEN-15336-1 ]]> DG-DEN-14902-1: started by Dara Navaei Wed, 03 May 2023 14:01:54 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14902-1 https://devapps.diality.us/cru/DG-DEN-14902-1 Dara Navaei started review DG-DEN-14902-1 ]]> DG-DEN-9480-1: reviewers finished Thu, 11 Nov 2021 10:54:56 -0800 https://devapps.diality.us/cru/DG-DEN-9480-1 https://devapps.diality.us/cru/DG-DEN-9480-1 hnguyen  (deleted user) and Sean Nash finished reviewing DG-DEN-9480-1 DG-DEN-9480_DG_DEV Dialysate Temperature Control ]]> DG-DEN-9480-1: comment by hnguyen "RESOLVED IN CODE WALKTHROUGH" Thu, 11 Nov 2021 10:37:03 -0800 hnguyen https://devapps.diality.us/cru/DG-DEN-9480-1/#c11371 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11371 hnguyen  (deleted user) replied to Dara Navaei in DG-DEN-9480-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-9480-1: comment by hnguyen "RESOLVED IN CODE WALKTHROUGH" Thu, 11 Nov 2021 10:36:51 -0800 hnguyen https://devapps.diality.us/cru/DG-DEN-9480-1/#c11370 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11370 hnguyen  (deleted user) replied to Dara Navaei in DG-DEN-9480-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-9480-1: comment by hnguyen "RESOLVED IN CODE WALKTHROUGH" Thu, 11 Nov 2021 10:36:28 -0800 hnguyen https://devapps.diality.us/cru/DG-DEN-9480-1/#c11369 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11369 hnguyen  (deleted user) replied to Dara Navaei in DG-DEN-9480-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-9480-1: comment by hnguyen "RESOLVED IN CODE WALKTHROUGH" Thu, 11 Nov 2021 10:35:03 -0800 hnguyen https://devapps.diality.us/cru/DG-DEN-9480-1/#c11368 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11368 hnguyen  (deleted user) replied to Dara Navaei in DG-DEN-9480-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-9480-1: comment by Dara Navaei "Done." Wed, 10 Nov 2021 21:08:03 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-9480-1/#c11329 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11329 Dara Navaei replied to hnguyen  (deleted user) in DG-DEN-9480-1

Done.

]]> DG-DEN-9480-1: comment by Dara Navaei "The const is an optional step in our code. Plus..." Wed, 10 Nov 2021 21:06:19 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-9480-1/#c11328 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11328 Dara Navaei replied to hnguyen  (deleted user) in DG-DEN-9480-1

The const is an optional step in our code. Plus these are the local variables and their values are not changed inside the function.

]]> DG-DEN-9480-1: comment by Dara Navaei "Done." Wed, 10 Nov 2021 21:05:23 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-9480-1/#c11327 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11327 Dara Navaei replied to hnguyen  (deleted user) in DG-DEN-9480-1

Done.

]]> DG-DEN-9480-1: comment by Dara Navaei "Done." Wed, 10 Nov 2021 21:04:10 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-9480-1/#c11326 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11326 Dara Navaei replied to hnguyen  (deleted user) in DG-DEN-9480-1

Done.

]]> DG-DEN-9480-1: comment by hnguyen "Variable reservoirDataPublicationTimerCounter i..." Wed, 10 Nov 2021 17:36:50 -0800 hnguyen https://devapps.diality.us/cru/DG-DEN-9480-1/#c11303 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11303 hnguyen  (deleted user) commented on DG-DEN-9480-1

Variable reservoirDataPublicationTimerCounter is missing in the @detail Inputs and Output

]]> DG-DEN-9480-1: comment by hnguyen "I am not sure why you removed the "const" from ..." Wed, 10 Nov 2021 15:29:19 -0800 hnguyen https://devapps.diality.us/cru/DG-DEN-9480-1/#c11302 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11302 hnguyen  (deleted user) commented on DG-DEN-9480-1

I am not sure why you removed the "const" from dialysateTemp and targetTemp?

]]> DG-DEN-9480-1: comment by hnguyen "Added "pressuresDataPublicationTimerCounter" va..." Wed, 10 Nov 2021 14:35:08 -0800 hnguyen https://devapps.diality.us/cru/DG-DEN-9480-1/#c11301 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11301 hnguyen  (deleted user) commented on DG-DEN-9480-1

Added "pressuresDataPublicationTimerCounter" variable to @details Outputs

]]> DG-DEN-9480-1: comment by hnguyen "The state variable valvesStatesPublicationTimer..." Wed, 10 Nov 2021 14:27:48 -0800 hnguyen https://devapps.diality.us/cru/DG-DEN-9480-1/#c11300 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11300 hnguyen  (deleted user) commented on DG-DEN-9480-1

The state variable valvesStatesPublicationTimerCounter was read, increment, then write. Therefore, it needs to be added to the @details Outputs.

]]> DG-DEN-9480-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 10 Nov 2021 11:17:18 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-9480-1/#c11299 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11299 Sean Nash replied to Dara Navaei in DG-DEN-9480-1

RESOLVED in CODE WALKTHROUGH.

]]>