Fisheye on application/sources/abstract https://devapps.diality.us/changelog/~br%3Dmodel_unit_test_fix/application/sources/abstract Recent activity in "application" under directory /sources/abstract UI-UCOMMITS-3: closed by Sean Nash Thu, 03 Aug 2023 14:23:52 -0700 Sean Nash https://devapps.diality.us/cru/UI-UCOMMITS-3 https://devapps.diality.us/cru/UI-UCOMMITS-3 Sean Nash Closed UI-UCOMMITS-3 ]]> UI-UCOMMITS-3: reviewers finished Thu, 03 Aug 2023 14:05:13 -0700 https://devapps.diality.us/cru/UI-UCOMMITS-3 https://devapps.diality.us/cru/UI-UCOMMITS-3 Dara Navaei finished reviewing UI-UCOMMITS-3 UI Staging Unreviewed Commits ]]> UI-UCOMMITS-3: reviewers finished Wed, 02 Aug 2023 09:33:38 -0700 https://devapps.diality.us/cru/UI-UCOMMITS-3 https://devapps.diality.us/cru/UI-UCOMMITS-3 Sean Nash finished reviewing UI-UCOMMITS-3 UI Staging Unreviewed Commits ]]> UI-UCOMMITS-3: started by Dara Navaei Mon, 08 May 2023 08:49:03 -0700 Dara Navaei https://devapps.diality.us/cru/UI-UCOMMITS-3 https://devapps.diality.us/cru/UI-UCOMMITS-3 Dara Navaei started review UI-UCOMMITS-3 ]]> UI-DEN-4690-2-1: closed by Behrouz NematiPour Thu, 15 Oct 2020 10:16:37 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-4690-2-1 https://devapps.diality.us/cru/UI-DEN-4690-2-1 Behrouz NematiPour Closed UI-DEN-4690-2-1 ]]> UI-DEN-4690-1: closed by Behrouz NematiPour Thu, 15 Oct 2020 10:16:16 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-4690-1 https://devapps.diality.us/cru/UI-DEN-4690-1 Behrouz NematiPour Closed UI-DEN-4690-1 ]]> UI-DEN-4690-1: reviewers finished Wed, 14 Oct 2020 23:09:42 -0700 https://devapps.diality.us/cru/UI-DEN-4690-1 https://devapps.diality.us/cru/UI-DEN-4690-1 pmontazemi  (deleted user) and plucia  (deleted user) finished reviewing UI-DEN-4690-1 UI-DEN-4690_ Doxygenization ]]> UI-DEN-4690-2-1: reviewers finished Wed, 14 Oct 2020 23:07:22 -0700 https://devapps.diality.us/cru/UI-DEN-4690-2-1 https://devapps.diality.us/cru/UI-DEN-4690-2-1 pmontazemi  (deleted user) and plucia  (deleted user) finished reviewing UI-DEN-4690-2-1 UI-DEN-4690-2_Doxygenization ]]> UI-DEN-4690-2-1: comment by plucia "RESOLVED" Wed, 14 Oct 2020 10:44:55 -0700 plucia https://devapps.diality.us/cru/UI-DEN-4690-2-1/#c5512 https://devapps.diality.us/cru/UI-DEN-4690-2-1/#c5512 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-4690-2-1

RESOLVED

]]> UI-DEN-4690-2-1: comment by plucia "RESOLVED. Fair, not related to story" Wed, 14 Oct 2020 10:44:25 -0700 plucia https://devapps.diality.us/cru/UI-DEN-4690-2-1/#c5511 https://devapps.diality.us/cru/UI-DEN-4690-2-1/#c5511 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-4690-2-1

RESOLVED.

Fair, not related to story

]]> UI-DEN-4690-2-1: comment by plucia "RESOLVED" Wed, 14 Oct 2020 10:43:58 -0700 plucia https://devapps.diality.us/cru/UI-DEN-4690-2-1/#c5510 https://devapps.diality.us/cru/UI-DEN-4690-2-1/#c5510 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-4690-2-1

RESOLVED

]]> UI-DEN-4690-2-1: comment by plucia "RESOLVED." Wed, 14 Oct 2020 10:43:14 -0700 plucia https://devapps.diality.us/cru/UI-DEN-4690-2-1/#c5509 https://devapps.diality.us/cru/UI-DEN-4690-2-1/#c5509 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-4690-2-1

RESOLVED.

]]> UI-DEN-4690-2-1: comment by plucia "Fair, not related to story. RESOLVED." Wed, 14 Oct 2020 10:42:18 -0700 plucia https://devapps.diality.us/cru/UI-DEN-4690-2-1/#c5508 https://devapps.diality.us/cru/UI-DEN-4690-2-1/#c5508 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-4690-2-1

Fair, not related to story.

RESOLVED.

]]> UI-DEN-4690-1: comment by plucia "RESOLVED." Wed, 14 Oct 2020 10:40:32 -0700 plucia https://devapps.diality.us/cru/UI-DEN-4690-1/#c5507 https://devapps.diality.us/cru/UI-DEN-4690-1/#c5507 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-4690-1

RESOLVED.

]]> UI-DEN-4690-1: comment by plucia "Fair, not related to story. RESOLVED." Wed, 14 Oct 2020 10:40:14 -0700 plucia https://devapps.diality.us/cru/UI-DEN-4690-1/#c5506 https://devapps.diality.us/cru/UI-DEN-4690-1/#c5506 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-4690-1

Fair, not related to story.

RESOLVED.

]]> UI-DEN-4690-1: comment by plucia "RESOLVED." Wed, 14 Oct 2020 10:39:21 -0700 plucia https://devapps.diality.us/cru/UI-DEN-4690-1/#c5505 https://devapps.diality.us/cru/UI-DEN-4690-1/#c5505 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-4690-1

RESOLVED.

]]> UI-DEN-4690-1: comment by plucia "RESOLVED." Wed, 14 Oct 2020 10:38:45 -0700 plucia https://devapps.diality.us/cru/UI-DEN-4690-1/#c5504 https://devapps.diality.us/cru/UI-DEN-4690-1/#c5504 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-4690-1

RESOLVED.

]]> UI-DEN-4690-1: comment by plucia "RESOLVED." Wed, 14 Oct 2020 10:35:54 -0700 plucia https://devapps.diality.us/cru/UI-DEN-4690-1/#c5503 https://devapps.diality.us/cru/UI-DEN-4690-1/#c5503 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-4690-1

RESOLVED.

]]> UI-DEN-4690-1: comment by plucia "RESOLVED." Wed, 14 Oct 2020 10:34:45 -0700 plucia https://devapps.diality.us/cru/UI-DEN-4690-1/#c5502 https://devapps.diality.us/cru/UI-DEN-4690-1/#c5502 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-4690-1

RESOLVED.

]]> UI-DEN-4690-1: comment by plucia "RESOLVED." Wed, 14 Oct 2020 10:34:18 -0700 plucia https://devapps.diality.us/cru/UI-DEN-4690-1/#c5501 https://devapps.diality.us/cru/UI-DEN-4690-1/#c5501 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-4690-1

RESOLVED.

]]> UI-DEN-4690-1: comment by plucia "RESOLVED." Wed, 14 Oct 2020 10:33:52 -0700 plucia https://devapps.diality.us/cru/UI-DEN-4690-1/#c5500 https://devapps.diality.us/cru/UI-DEN-4690-1/#c5500 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-4690-1

RESOLVED.

]]> UI-DEN-4690-1: comment by plucia "RESOLVED." Wed, 14 Oct 2020 10:32:18 -0700 plucia https://devapps.diality.us/cru/UI-DEN-4690-1/#c5498 https://devapps.diality.us/cru/UI-DEN-4690-1/#c5498 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-4690-1

RESOLVED.

]]> UI-DEN-4690-1: comment by plucia "RESOLVED." Wed, 14 Oct 2020 10:31:03 -0700 plucia https://devapps.diality.us/cru/UI-DEN-4690-1/#c5497 https://devapps.diality.us/cru/UI-DEN-4690-1/#c5497 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-4690-1

RESOLVED.

]]> UI-DEN-4690-1: comment by plucia "RESOLVED" Wed, 14 Oct 2020 10:29:53 -0700 plucia https://devapps.diality.us/cru/UI-DEN-4690-1/#c5496 https://devapps.diality.us/cru/UI-DEN-4690-1/#c5496 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-4690-1

RESOLVED

]]> UI-DEN-4690-2-1: comment by Behrouz NematiPour "did" Tue, 13 Oct 2020 18:07:09 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-4690-2-1/#c5455 https://devapps.diality.us/cru/UI-DEN-4690-2-1/#c5455 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-4690-2-1

did

]]> UI-DEN-4690-2-1: comment by Behrouz NematiPour "It is all documentations and Doxygenization. I..." Wed, 07 Oct 2020 22:15:34 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-4690-2-1/#c5420 https://devapps.diality.us/cru/UI-DEN-4690-2-1/#c5420 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-4690-2-1

It is all documentations and Doxygenization.
If you see otherwise is because of the some file name change and the code review take it as a new file and mark all the file content as to be reviewed.
Let me know if otherwise.

]]> UI-DEN-4690-1: comment by Behrouz NematiPour "Please refer to the newer code review after the..." Wed, 16 Sep 2020 01:30:13 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-4690-1/#c4710 https://devapps.diality.us/cru/UI-DEN-4690-1/#c4710 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-4690-1

Please refer to the newer code review after the max revision has been changed which has all the latest commits.
http://192.168.10.132:8060/cru/UI-DEN-4690-2-1
Seems like it has appeared here as well.

]]> UI-DEN-4690-1: comment by Behrouz NematiPour ""*** Off the subject ***" This is not related ..." Wed, 16 Sep 2020 01:32:27 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-4690-1/#c4711 https://devapps.diality.us/cru/UI-DEN-4690-1/#c4711 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-4690-1

"*** Off the subject ***"
This is not related to the story and is a code coverage of another story.
Regardless it was decided to manually test the CANBus at that moment since it could be better tested with more accurate results which all of those test couldn't be achieved manually and took a long time to test because 10 or 100 of thousands of frames tested and wasn't reasonable to do it each time automatically on server with virtual CANBus and had to be tested on a real physical CANBus.
I hope this is enough information!

]]> UI-DEN-4690-1: comment by Behrouz NematiPour "DISABLE_CRC is only for development debugging p..." Wed, 07 Oct 2020 21:46:35 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-4690-1/#c5415 https://devapps.diality.us/cru/UI-DEN-4690-1/#c5415 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-4690-1

DISABLE_CRC is only for development debugging purposes.
and is not part of this function definition.
Will be defined/enabled in case for debugging.

]]> UI-DEN-4690-1: comment by Behrouz NematiPour "I think if it's not false (false if the vData o..." Wed, 07 Oct 2020 21:47:35 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-4690-1/#c5416 https://devapps.diality.us/cru/UI-DEN-4690-1/#c5416 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-4690-1

I think if it's not false (false if the vData of type QByteArray is not sufficient regarding vAction) then it would be true, right ?!

]]>