1. UI-DEN-4690

UI-DEN-4690-1

Tools
closed on 15 Oct 20
Author
Moderator
Reviewers

UI-DEN-4690_ Doxygenization

Activity

UI-DEN-4690-1 237

Keyboard shortcuts  
    • Summarize the review outcomes (optional)
    Preview wiki syntax help
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Behrouz NematiPour
    		Author & Moderator 4h 25m 83 Please refer to the newer code review after the max revis...
    plucia  (deleted user)
    Reviewer completed
    		Reviewer - Complete 2h 39m 53 RESOLVED.
    pmontazemi  (deleted user)
    Reviewer completed
    		Reviewer - Complete 2h 1m 101 RESOLVED.
    Total   9h 6m 237  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    plucia  (deleted user)

    This review has so many files and is quite monumental. It would be much easie...

    This review has so many files and is quite monumental.
    It would be much easier to review if there were fewer changes.
    What are the list of features that are covered in this review? It seems like it's not just doxygenization

      plucia  (deleted user) marked as Resolved 14 Oct 20

    Behrouz NematiPour

    It is all documentations and Doxygenization. If you see otherwise is because ...

    It is all documentations and Doxygenization.
    If you see otherwise is because the file names changed and the code review takes it as a new file and marks all the file content as to be reviewed.
    Let me know if otherwise.

    plucia  (deleted user)

    RESOLVED.

    RESOLVED.

    /scripts/autostart Changed
    /scripts/copy.sh Changed
    Open in IDE #permalink
    /scripts/run.sh Changed
    /scripts/setup.sh Changed
    /sources/abstract/singleton.h Changed 8
    Open in IDE #permalink
    /sources/abstract/singleton.h._ Deleted 5
    Open in IDE #permalink
    /sources/canbus/CanInterface.cpp Added 5
    /sources/canbus/CanInterface.h Added 3
    /sources/canbus/FrameInterface.cpp Added
    Open in IDE #permalink
    /sources/canbus/FrameInterface.h Added
    /sources/canbus/MessageAcknowModel.cpp Added
    Open in IDE #permalink
    /sources/canbus/MessageAcknowModel.h Added 3
    /sources/canbus/MessageBuilder.cpp Added 6
    /sources/canbus/MessageBuilder.h Added
    /sources/canbus/MessageDispatcher.cpp Added
    /sources/canbus/MessageDispatcher.h Added 3
    /sources/canbus/MessageGlobals.h Added 6
    /sources/canbus/MessageInterpreter.cpp Added
    /sources/canbus/MessageInterpreter.h Added 3
    /sources/canbus/caninterface.cpp Changed 9
    Open in IDE #permalink
    /sources/canbus/caninterface.h Changed
    Open in IDE #permalink
    /sources/canbus/frameinterface.cpp Changed 3
    Open in IDE #permalink
    /sources/canbus/frameinterface.h Changed
    Open in IDE #permalink
    /sources/canbus/messageacknowmodel.cpp Changed 3
    Open in IDE #permalink
    /sources/canbus/messageacknowmodel.h Changed 6
    Open in IDE #permalink
    /sources/canbus/messagebuilder.cpp Changed 12
    Open in IDE #permalink
    /sources/canbus/messagebuilder.h Changed 3
    Open in IDE #permalink
    /sources/canbus/messagedispatcher.cpp Changed
    Open in IDE #permalink
    /sources/canbus/messagedispatcher.h Changed 6
    Open in IDE #permalink
    /sources/canbus/messageglobals.h Changed 6
    Open in IDE #permalink
    /sources/canbus/messageinterpreter.cpp Changed 3
    Open in IDE #permalink
    /sources/canbus/messageinterpreter.h Changed 6
    Open in IDE #permalink
    /sources/configuration/display.cpp Changed
    Open in IDE #permalink
    /sources/configuration/display.cpp._ Deleted 5
    Open in IDE #permalink
    /sources/configuration/display.h Changed 3
    Open in IDE #permalink
    /sources/configuration/display.h._ Deleted 5
    Open in IDE #permalink
    /sources/configuration/sound.cpp Changed 3
    Open in IDE #permalink
    /sources/configuration/sound.cpp._ Deleted 5
    Open in IDE #permalink
    /sources/configuration/sound.h Changed 3
    Open in IDE #permalink
    /sources/configuration/sound.h._ Deleted 5
    Open in IDE #permalink
    /sources/gui/qml/components/BackButton.qml Changed
    /sources/gui/qml/components/Background.qml Changed
    /sources/gui/qml/components/Circle.qml Changed
    /sources/gui/.../components/CloseButton.qml Changed
    /sources/gui/.../components/ConfirmButton.qml Changed
    /sources/.../components/DebugDataColumn.qml Changed
    /sources/gui/.../components/ExportButton.qml Changed
    /sources/gui/qml/components/ImageClock.qml Changed
    /sources/gui/qml/components/ImageLogoD.qml Changed
    /sources/.../components/ImageLogoDDarkTransparent.qml Changed
    /sources/gui/qml/components/ImageWave.qml Changed
    /sources/gui/qml/components/Line.qml Changed
    /sources/gui/qml/components/MainMenu.qml Changed
    /sources/gui/.../components/ModalDialog.qml Changed
    /sources/.../components/NotificationBar.qml Changed
    Open in IDE #permalink
    /sources/.../components/NotificationBarSmall.qml Changed
    /sources/.../components/PlaceHolderText.qml Changed
    /sources/gui/.../components/ProgressBar.qml Changed
    /sources/gui/.../components/ProgressBarEx.qml Changed
    /sources/gui/.../components/ProgressCircle.qml Changed
    Open in IDE #permalink
    /sources/gui/.../components/ProgressRect.qml Changed
    /sources/gui/qml/components/RangeBar.qml Changed
    /sources/gui/.../components/RangeMarker.qml Changed
    /sources/gui/qml/components/RangeRect.qml Changed
    /sources/gui/qml/components/ScreenItem.qml Changed
    /sources/gui/.../components/SettingsItem.qml Changed
    /sources/gui/qml/components/Slider.qml Changed
    Open in IDE #permalink
    /sources/gui/qml/components/StackItem.qml Changed
    Open in IDE #permalink
    /sources/gui/qml/components/TextRect.qml Changed
    /sources/gui/qml/components/TickMarks.qml Changed
    /sources/gui/qml/components/TimeText.qml Changed
    /sources/gui/qml/components/TitleText.qml Changed
    /sources/gui/qml/components/TouchArea.qml Changed
    /sources/gui/qml/components/TouchRect.qml Changed
    Open in IDE #permalink
    /sources/gui/qml/components/USBButton.qml Changed
    /sources/.../components/UltrafiltrationButton.qml Changed
    /sources/gui/qml/dialogs/AutoHideInfo.qml Changed
    /sources/.../dialogs/NotificationDialog.qml Changed
    Open in IDE #permalink
    /sources/gui/qml/dialogs/PowerOff.qml Changed
    /sources/gui/qml/globals/Colors.qml Changed 5
    /sources/gui/qml/globals/Fonts.qml Changed 6
    /sources/gui/qml/globals/Variables.qml Changed
    /sources/.../adjustments/TreatmentAdjustmentBase.qml Changed
    /sources/.../adjustments/TreatmentAdjustmentDuration.qml Changed
    /sources/.../adjustments/TreatmentAdjustmentFlow.qml Changed
    /sources/.../adjustments/TreatmentAdjustmentUltrafiltrationConfirm.qml Changed
    /sources/.../adjustments/TreatmentAdjustmentUltrafiltrationEdit.qml Changed
    /sources/.../adjustments/TreatmentAdjustmentUltrafiltrationPaused.qml Changed
    /sources/.../adjustments/TreatmentAdjustmentUltrafiltrationStart.qml Changed
    /sources/gui/.../sections/TreatmentFlows.qml Changed
    /sources/gui/.../sections/TreatmentFluid.qml Changed
    /sources/.../sections/TreatmentPressure.qml Changed
    /sources/gui/.../sections/TreatmentSaline.qml Changed
    /sources/gui/.../sections/TreatmentTime.qml Changed
    /sources/.../sections/TreatmentUltrafiltration.qml Changed
    /sources/gui/.../sections/TreatmentVitals.qml Changed
    /sources/gui/.../treatment/TreatmentCreate.qml Changed
    Open in IDE #permalink
    /sources/gui/.../treatment/TreatmentHome.qml Changed
    /sources/gui/.../treatment/TreatmentStack.qml Changed
    /sources/gui/.../treatment/TreatmentStart.qml Changed
    /sources/gui/qml/pages/Diagnostics.qml Changed
    /sources/gui/qml/pages/ManagerHome.qml Changed
    /sources/gui/qml/pages/ManagerStack.qml Changed
    /sources/gui/qml/pages/SettingsHome.qml Changed
    /sources/gui/qml/pages/SettingsStack.qml Changed
    /sources/gui/qml/main.qml Changed
    /sources/gui/GuiController.cpp Added
    /sources/gui/GuiController.h Added
    /sources/gui/GuiGlobals.cpp Added
    /sources/gui/GuiGlobals.h Added
    /sources/gui/GuiView.cpp Added
    /sources/gui/GuiView.h Added
    /sources/gui/guicontroller.cpp Changed 3
    Open in IDE #permalink
    /sources/gui/guicontroller.h Changed
    Open in IDE #permalink
    /sources/gui/guiglobals.cpp Changed
    Open in IDE #permalink
    /sources/gui/guiglobals.h Changed
    Open in IDE #permalink
    /sources/gui/guiview.cpp Changed
    Open in IDE #permalink
    /sources/gui/guiview.h Changed
    Open in IDE #permalink
    /sources/model/.../data/MDGDrainPumpData.cpp Changed
    /sources/model/dg/data/MDGDrainPumpData.h Changed
    /sources/model/dg/data/MDGHeatersData.cpp Changed
    /sources/model/dg/data/MDGHeatersData.h Changed
    /sources/.../data/MDGLoadCellReadingsData.cpp Changed
    /sources/.../data/MDGLoadCellReadingsData.h Changed
    /sources/.../data/MDGOperationModeData.cpp Changed
    /sources/model/.../data/MDGOperationModeData.h Changed
    /sources/model/.../data/MDGPressuresData.cpp Changed
    /sources/model/dg/data/MDGPressuresData.h Changed
    /sources/model/dg/data/MDGROPumpData.cpp Changed
    /sources/model/dg/data/MDGROPumpData.h Changed
    /sources/model/.../data/MDGReservoirData.cpp Changed
    /sources/model/dg/data/MDGReservoirData.h Changed
    /sources/.../data/MDGTemperaturesData.cpp Changed
    /sources/model/.../data/MDGTemperaturesData.h Changed
    /sources/.../data/MDGValvesStatesData.cpp Changed
    /sources/model/.../data/MDGValvesStatesData.h Changed
    /sources/.../adjustment/MTreatmentAdjustBloodDialysateResponse.cpp Changed
    /sources/.../adjustment/MTreatmentAdjustBloodDialysateResponse.h Changed
    /sources/.../adjustment/MTreatmentAdjustDurationResponse.cpp Changed
    /sources/.../adjustment/MTreatmentAdjustDurationResponse.h Changed
    /sources/.../adjustment/MTreatmentAdjustRequests.h Changed
    /sources/.../adjustment/MTreatmentAdjustSalineResponse.cpp Changed
    /sources/.../adjustment/MTreatmentAdjustSalineResponse.h Changed
    /sources/.../adjustment/MTreatmentAdjustUltrafiltrationConfirmResponse.cpp Changed
    /sources/.../adjustment/MTreatmentAdjustUltrafiltrationConfirmResponse.h Changed
    /sources/.../adjustment/MTreatmentAdjustUltrafiltrationEditResponse.cpp Changed
    /sources/.../adjustment/MTreatmentAdjustUltrafiltrationEditResponse.h Changed
    /sources/.../adjustment/MTreatmentAdjustUltrafiltrationStateResponse.cpp Changed
    /sources/.../adjustment/MTreatmentAdjustUltrafiltrationStateResponse.h Changed
    /sources/model/hd/alarm/MAlarmCleared.cpp Changed
    /sources/model/hd/alarm/MAlarmCleared.h Changed
    /sources/model/.../alarm/MAlarmStatusData.cpp Changed
    /sources/model/hd/alarm/MAlarmStatusData.h Changed
    /sources/model/.../alarm/MAlarmTriggered.cpp Changed
    /sources/model/hd/alarm/MAlarmTriggered.h Changed
    /sources/.../data/MHDOperationModeData.cpp Changed
    /sources/model/.../data/MHDOperationModeData.h Changed
    /sources/.../data/MTreatmentFlowsData.cpp Changed
    /sources/model/.../data/MTreatmentFlowsData.h Changed
    /sources/.../data/MTreatmentOutletFlowData.cpp Changed
    /sources/.../data/MTreatmentOutletFlowData.h Changed
    /sources/.../data/MTreatmentPressureOcclusionData.cpp Changed
    /sources/.../data/MTreatmentPressureOcclusionData.h Changed
    /sources/.../data/MTreatmentRangesData.cpp Changed
    /sources/model/.../data/MTreatmentRangesData.h Changed
    /sources/.../data/MTreatmentSalineData.cpp Changed
    /sources/model/.../data/MTreatmentSalineData.h Changed
    /sources/.../data/MTreatmentStatesData.cpp Changed
    /sources/model/.../data/MTreatmentStatesData.h Changed
    /sources/model/.../data/MTreatmentTimeData.cpp Changed
    /sources/model/.../data/MTreatmentTimeData.h Changed
    /sources/model/MAbstract.cpp Changed 3
    /sources/model/MAbstract.h Changed
    /sources/model/MDGDebugText.cpp Changed
    /sources/model/MDGDebugText.h Changed
    /sources/model/MHDDebugText.cpp Changed
    /sources/model/MHDDebugText.h Changed
    /sources/model/MModel.h Changed
    /sources/model/MPowerOff.cpp Changed
    /sources/model/MPowerOff.h Changed
    /sources/storage/DriveWatcher.cpp Changed
    /sources/storage/DriveWatcher.h Changed
    /sources/storage/FileHandler.cpp Added
    /sources/storage/FileHandler.h Added
    /sources/storage/Logger.cpp Added
    /sources/storage/Logger.h Added
    /sources/storage/StorageGlobals.cpp Added
    /sources/storage/StorageGlobals.h Added 3
    /sources/storage/filehandler.cpp Changed 3
    Open in IDE #permalink
    /sources/storage/filehandler.h Changed
    Open in IDE #permalink
    /sources/storage/logger.cpp Changed
    Open in IDE #permalink
    /sources/storage/logger.h Changed 3
    Open in IDE #permalink
    /sources/storage/settings.cpp Changed
    Open in IDE #permalink
    /sources/storage/settings.cpp._ Deleted 4
    Open in IDE #permalink
    /sources/storage/settings.h Changed
    Open in IDE #permalink
    /sources/storage/settings.h._ Deleted 7
    Open in IDE #permalink
    /sources/storage/storageglobals.cpp Changed 3
    Open in IDE #permalink
    /sources/storage/storageglobals.h Changed 3
    Open in IDE #permalink
    /sources/utility/crc.cpp Changed
    Open in IDE #permalink
    /sources/utility/crc.h Changed
    /sources/utility/format.cpp Changed
    /sources/utility/format.h Changed
    /sources/utility/types.cpp Changed 6
    Open in IDE #permalink
    /sources/utility/types.h Changed
    /sources/view/dg/data/VDGDrainPumpData.cpp Changed
    /sources/view/dg/data/VDGDrainPumpData.h Changed
    /sources/view/dg/data/VDGHeatersData.cpp Changed
    /sources/view/dg/data/VDGHeatersData.h Changed
    /sources/.../data/VDGLoadCellReadingsData.cpp Changed
    /sources/.../data/VDGLoadCellReadingsData.h Changed
    /sources/.../data/VDGOperationModeData.cpp Changed
    /sources/view/.../data/VDGOperationModeData.h Changed
    /sources/view/dg/data/VDGPressuresData.cpp Changed
    /sources/view/dg/data/VDGPressuresData.h Changed
    /sources/view/dg/data/VDGROPumpData.cpp Changed
    /sources/view/dg/data/VDGROPumpData.h Changed
    /sources/view/dg/data/VDGReservoirData.cpp Changed
    /sources/view/dg/data/VDGReservoirData.h Changed
    /sources/view/.../data/VDGTemperaturesData.cpp Changed
    /sources/view/.../data/VDGTemperaturesData.h Changed
    /sources/view/.../data/VDGValvesStatesData.cpp Changed
    /sources/view/.../data/VDGValvesStatesData.h Changed
    /sources/.../adjustment/VTreatmentAdjustmentDuration.cpp Added
    /sources/.../adjustment/VTreatmentAdjustmentDuration.h Added
    /sources/.../adjustment/VTreatmentAdjustmentFlows.cpp Added
    /sources/.../adjustment/VTreatmentAdjustmentFlows.h Added
    /sources/.../adjustment/VTreatmentAdjustmentResponseBase.cpp Added
    /sources/.../adjustment/VTreatmentAdjustmentResponseBase.h Added
    /sources/.../adjustment/VTreatmentAdjustmentSaline.cpp Changed
    /sources/.../adjustment/VTreatmentAdjustmentSaline.h Changed
    /sources/.../adjustment/VTreatmentAdjustmentUltrafiltrationConfirm.cpp Added
    /sources/.../adjustment/VTreatmentAdjustmentUltrafiltrationConfirm.h Added
    /sources/.../adjustment/VTreatmentAdjustmentUltrafiltrationEdit.cpp Added
    /sources/.../adjustment/VTreatmentAdjustmentUltrafiltrationEdit.h Added 3
    /sources/.../adjustment/VTreatmentAdjustmentUltrafiltrationState.cpp Added
    /sources/.../adjustment/VTreatmentAdjustmentUltrafiltrationState.h Added
    /sources/view/hd/alarm/VAlarmStatus.cpp Added
    /sources/view/hd/alarm/VAlarmStatus.h Added
    /sources/.../data/VHDOperationModeData.cpp Changed
    /sources/view/.../data/VHDOperationModeData.h Changed
    /sources/.../data/VHDTreatmentStatesData.cpp Changed
    /sources/.../data/VHDTreatmentStatesData.h Changed
    /sources/view/.../data/VTreatmentBloodFlow.cpp Added
    /sources/view/.../data/VTreatmentBloodFlow.h Added
    /sources/.../data/VTreatmentDialysateFlow.cpp Added
    /sources/.../data/VTreatmentDialysateFlow.h Added
    /sources/.../data/VTreatmentPressureOcclusion.cpp Added
    /sources/.../data/VTreatmentPressureOcclusion.h Added
    /sources/view/hd/data/VTreatmentRanges.cpp Added
    /sources/view/hd/data/VTreatmentRanges.h Added
    /sources/.../data/VTreatmentSalineData.cpp Changed
    Open in IDE #permalink
    /sources/view/.../data/VTreatmentSalineData.h Changed
    Open in IDE #permalink
    /sources/view/hd/data/VTreatmentTime.cpp Added
    /sources/view/hd/data/VTreatmentTime.h Added
    /sources/.../data/VTreatmentUltrafiltration.cpp Added
    /sources/.../data/VTreatmentUltrafiltration.h Added
    /sources/view/VEventSpy.cpp Changed
    /sources/view/VEventSpy.h Changed
    /sources/view/VPowerOff.cpp Added
    /sources/view/VPowerOff.h Added
    /sources/view/VView.h Added
    /sources/view/valarmstatus.cpp Changed 3
    /sources/view/valarmstatus.h Changed 3
    /sources/view/vpoweroff.cpp Changed
    Open in IDE #permalink
    /sources/view/vpoweroff.h Changed 6
    Open in IDE #permalink
    /sources/view/vtreatmentadjustmentduration.cpp Changed
    Open in IDE #permalink
    /sources/view/vtreatmentadjustmentduration.h Changed 3
    Open in IDE #permalink
    /sources/view/vtreatmentadjustmentflows.cpp Changed
    Open in IDE #permalink
    /sources/view/vtreatmentadjustmentflows.h Changed 6
    Open in IDE #permalink
    /sources/view/vtreatmentadjustmentresponsebase.cpp Changed
    Open in IDE #permalink
    /sources/view/vtreatmentadjustmentresponsebase.h Changed
    Open in IDE #permalink
    /sources/view/vtreatmentadjustmentultrafiltrationconfirm.cpp Changed
    Open in IDE #permalink
    /sources/view/vtreatmentadjustmentultrafiltrationconfirm.h Changed
    Open in IDE #permalink
    /sources/view/vtreatmentadjustmentultrafiltrationedit.cpp Changed
    Open in IDE #permalink
    /sources/view/vtreatmentadjustmentultrafiltrationedit.h Changed 3
    Open in IDE #permalink
    /sources/view/vtreatmentadjustmentultrafiltrationstate.cpp Changed
    Open in IDE #permalink
    /sources/view/vtreatmentadjustmentultrafiltrationstate.h Changed 3
    Open in IDE #permalink
    /sources/view/vtreatmentbloodflow.cpp Changed
    Open in IDE #permalink
    /sources/view/vtreatmentbloodflow.h Changed 6
    Open in IDE #permalink
    /sources/view/vtreatmentdialysateflow.cpp Changed
    Open in IDE #permalink
    /sources/view/vtreatmentdialysateflow.h Changed 6
    Open in IDE #permalink
    /sources/view/vtreatmentpressureocclusion.cpp Changed
    Open in IDE #permalink
    /sources/view/vtreatmentpressureocclusion.h Changed 3
    Open in IDE #permalink
    /sources/view/vtreatmentranges.cpp Changed
    Open in IDE #permalink
    /sources/view/vtreatmentranges.h Changed 3
    Open in IDE #permalink
    /sources/view/vtreatmenttime.cpp Changed
    Open in IDE #permalink
    /sources/view/vtreatmenttime.h Changed 3
    Open in IDE #permalink
    /sources/view/vtreatmentultrafiltration.cpp Changed
    Open in IDE #permalink
    /sources/view/vtreatmentultrafiltration.h Changed 3
    Open in IDE #permalink
    /sources/view/vview.h Changed
    Open in IDE #permalink
    /sources/ApplicationController.cpp Added
    /sources/ApplicationController.h Added
    /sources/ApplicationPost.cpp Added
    /sources/ApplicationPost.h Added
    Open in IDE #permalink
    /sources/MainTimer.cpp Added
    /sources/MainTimer.h Added
    /sources/Threads.cpp Added
    /sources/Threads.h Added
    /sources/applicationcontroller.cpp Changed
    Open in IDE #permalink
    /sources/applicationcontroller.h Changed
    Open in IDE #permalink
    /sources/applicationpost.cpp Changed
    Open in IDE #permalink
    /sources/applicationpost.h Changed
    Open in IDE #permalink
    /sources/main.h Changed
    /sources/maintimer.cpp Changed 3
    Open in IDE #permalink
    /sources/maintimer.h Changed
    Open in IDE #permalink
    /sources/threads.cpp Changed
    Open in IDE #permalink
    /sources/threads.h Changed
    Open in IDE #permalink
    /unittests/tst_acknow.cpp Changed
    /unittests/tst_acknow.h Changed
    /unittests/tst_canbus.cpp Changed
    /unittests/tst_canbus.h Changed
    /unittests/tst_initializations.cpp Changed
    /unittests/tst_initializations.h Changed
    /unittests/tst_logging.cpp Changed
    /unittests/tst_logging.h Changed
    /unittests/tst_messaging.cpp Changed
    /unittests/tst_messaging.h Changed
    Open in IDE #permalink
    /unittests/tst_models.cpp Changed
    /unittests/tst_models.h Changed
    Open in IDE #permalink
    /unittests/tst_threads.cpp Changed
    /unittests/tst_threads.h Changed
    /unittests/tst_utilities.cpp Changed
    /unittests/tst_utilities.h Changed
    /unittests/tst_views.cpp Changed
    /unittests/tst_views.h Changed
    Open in IDE #permalink
    /denali.pro Changed
    /denali.pro.user Changed
    /main.cpp Changed
    /simulator/run.py Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time