Fisheye on dgfirmware/firmware/App/Services/PIControllers.h

dgfirmware (DENBUG-236-alarm-97-when-running-treatment-45-seconds-p1-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 06 Feb 2024 13:43:32 -0800

Dara Navaei committed 54d18d8 on branch DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml-p1 and 13 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeStandby.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff

DG-DEN-16499-2: closed by Dara Navaei

Dara Navaei — Tue, 06 Feb 2024 13:25:36 -0800

Dara Navaei Closed DG-DEN-16499-2

DG-DEN-16499-2: reviewers finished

Tue, 06 Feb 2024 13:08:45 -0800

Vinayakam Mani and Sean Nash finished reviewing DG-DEN-16499-2

DG-DEN-16499_FW Message List Testing Issues 2

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16499 added doxygen comments to the structures. Updated the messages for the messages list script

Dara Navaei — Tue, 06 Feb 2024 10:49:41 -0800

Dara Navaei committed 81bfada on branch DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging, DEN-16499-fw-message-list-testing-issues-2 and 14 more in dgfirmware

DEN-16499 added doxygen comments to the structures. Updated the messages for the messages list script

· /firmware/App/Modes/ModeStandby.c	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-110, +109)	\| History	\| Source	\| Diff

DG-DEN-16499-2: started by Dara Navaei

Dara Navaei — Tue, 06 Feb 2024 10:16:16 -0800

Dara Navaei started review DG-DEN-16499-2

DG-DEN-16499-1: closed by Dara Navaei

Dara Navaei — Fri, 02 Feb 2024 14:18:57 -0800

Dara Navaei Closed DG-DEN-16499-1

DG-DEN-16499-1: reviewers finished

Fri, 02 Feb 2024 13:46:27 -0800

Vinayakam Mani and Sean Nash finished reviewing DG-DEN-16499-1

DG-DEN-16499_FW Message List Testing Issues

DG-DEN-16499-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Wed, 31 Jan 2024 12:17:15 -0800

Sean Nash replied to Dara Navaei in DG-DEN-16499-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-16499-1: comment by Dara Navaei "Fixed the code."

Dara Navaei — Tue, 30 Jan 2024 09:11:56 -0800

Dara Navaei replied to Sean Nash in DG-DEN-16499-1

Fixed the code.

DG-DEN-16499-1: comment by Sean Nash "This looks wrong."

Sean Nash — Thu, 25 Jan 2024 08:54:32 -0800

Sean Nash commented on DG-DEN-16499-1

This looks wrong.

DG-DEN-16499-1: started by Dara Navaei

Dara Navaei — Tue, 23 Jan 2024 15:13:35 -0800

Dara Navaei started review DG-DEN-16499-1

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 08 Jan 2024 14:41:57 -0800

Dara Navaei committed 4bd3bf3 on branch DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging, DEN-16499-fw-message-list-testing-issues-2 and 14 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-1, +1)

| History

| Source

| Diff

… 86 more files in changeset.

DG-DEN-2650-1: closed by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:42:37 -0700

Dara Navaei Closed DG-DEN-2650-1

DG-DEN-2650-1: reviewers finished

Thu, 19 Oct 2023 08:42:03 -0700

Dara Navaei finished reviewing DG-DEN-2650-1

DG-DEN-2650_DG Firmware Infrastructure

DG-DEN-2650-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 08:41:49 -0700

Dara Navaei replied to Sean Nash in DG-DEN-2650-1

RESOLVED in CODE WALKTHROUGH

DG-DEN-2650-1: started by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:41:19 -0700

Dara Navaei started review DG-DEN-2650-1

DG-DEN-2379-1: closed by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:38:49 -0700

Dara Navaei Closed DG-DEN-2379-1

DG-DEN-2379-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 08:38:39 -0700

Dara Navaei replied to Dara Navaei in DG-DEN-2379-1

RESOLVED in CODE WALKTHROUGH

DG-DEN-2379-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 08:38:04 -0700

Dara Navaei replied to Dara Navaei in DG-DEN-2379-1

RESOLVED in CODE WALKTHROUGH

DG-DEN-2379-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 08:36:42 -0700

Dara Navaei replied to Dara Navaei in DG-DEN-2379-1

RESOLVED in CODE WALKTHROUGH

DG-DEN-2379-1: reviewers resumed

Thu, 19 Oct 2023 08:35:24 -0700

pmontazemi (deleted user) and Sean Nash resumed reviewing DG-DEN-2379-1

DG-DEN-2379_DG Dialysate Temperature 1 of 2

DG-DEN-2379-1: started by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:35:23 -0700

Dara Navaei started review DG-DEN-2379-1

DG-DEN-3421-1: closed by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:34:58 -0700

Dara Navaei Closed DG-DEN-3421-1

DG-DEN-3421-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 08:34:41 -0700

Dara Navaei replied to qnguyen (deleted user) in DG-DEN-3421-1

RESOLVED in CODE WALKTHROUGH

DG-DEN-3421-1: reviewers resumed

Thu, 19 Oct 2023 08:29:12 -0700

pmontazemi (deleted user) , qnguyen (deleted user) and Sean Nash resumed reviewing DG-DEN-3421-1

DG-DEN-3421_DG Heat Disinfection

DG-DEN-3421-1: started by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:29:07 -0700

Dara Navaei started review DG-DEN-3421-1

DG-DEN-7568-1: closed by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:06:55 -0700

Dara Navaei Closed DG-DEN-7568-1

DG-DEN-7568-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 08:06:41 -0700

Dara Navaei replied to Sean Nash in DG-DEN-7568-1

RESOLVED in CODE WALKTHROUGH

DG-DEN-7568-1: reviewers resumed

Thu, 19 Oct 2023 08:05:53 -0700

Sean Nash , qnguyen (deleted user) and pmontazemi (deleted user) resumed reviewing DG-DEN-7568-1

DG-DEN-7568_DG Mode Flush

DG-DEN-7568-1: started by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:05:49 -0700

Dara Navaei started review DG-DEN-7568-1