· /firmware/App/Controllers/BloodFlow.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/PresOccl.c	(-11, +244)	| History	| Source	| Diff
· /firmware/App/Controllers/PresOccl.h	(-1, +9)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-19, +21)	| History	| Source	| Diff
· /firmware/App/Modes/ModeTreatment.c	(-0, +16)	| History	| Source	| Diff
· /firmware/App/Modes/SelfTests.c	(-0, +1)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmt.c	(-1, +6)	| History	| Source	| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/SystemComm.c	(-0, +12)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommMessages.c	(-6, +106)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +10)	| History	| Source	| Diff
· /firmware/HD.dil	(-11, +11)	| History	| Source	| Diff
· /firmware/include/sys_core.h	(-3, +3)	| History	| Source	| Diff
· /firmware/source/sys_core.asm	(-5, +5)	| History	| Source	| Diff
· /firmware/source/sys_link.cmd	(-4, +4)	| History	| Source	| Diff

]]> Sun, 12 May 2024 14:38:57 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DENBUG-249-1 https://devapps.diality.us/cru/HD-DENBUG-249-1 Dara Navaei started review HD-DENBUG-249-1 ]]> Fri, 10 May 2024 11:59:08 -0700 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16851-1 https://devapps.diality.us/cru/HD-DEN-16851-1 Vinayakam Mani Closed HD-DEN-16851-1 ]]> Fri, 10 May 2024 11:35:14 -0700 https://devapps.diality.us/cru/HD-DEN-16851-1 https://devapps.diality.us/cru/HD-DEN-16851-1 Dara Navaei finished reviewing HD-DEN-16851-1 HD-DEN-16851_New Alarm For Increased Occlus ]]> Thu, 09 May 2024 12:43:35 -0700 https://devapps.diality.us/cru/HD-DEN-16851-1 https://devapps.diality.us/cru/HD-DEN-16851-1 Sean Nash finished reviewing HD-DEN-16851-1 HD-DEN-16851_New Alarm For Increased Occlus ]]> Thu, 02 May 2024 12:54:21 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16851-1/#c19752 https://devapps.diality.us/cru/HD-DEN-16851-1/#c19752 Sean Nash replied to Vinayakam Mani in HD-DEN-16851-1

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done

Done

Done

Yes, when we are not in treatment mode, the state machine sets the state to "pressure_limits_state_off" at start of this function ( line : 673). hence mode check is not necessary.

Done.

Done.

I think we just want to publish the baseline here (not +1000).

Yes, if you cast either value in division as a F32, the result will be F32. This is all we need as F32 (the .data). The samples and total can stay U32.
You might want to cast the total as F32 as well for consistency.

F32 not needed here.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Casting not necessary.

RESOLVED in CODE WALKTHROUGH.

Are we guaranteed to be in Treatment mode here? If not, check mode too.

RESOLVED in CODE WALKTHROUGH.