Fisheye on dgfirmware/firmware/App/Modes/ModeHeatDisinfectActiveCool.c https://devapps.diality.us/changelog/~br%3Drelease%25402fp1_develop/dgfirmware/firmware/App/Modes/ModeHeatDisinfectActiveCool.c Recent activity in "dgfirmware" under directory /firmware/App/Modes/ModeHeatDisinfectActiveCool.c DG-DEN-17047-1: closed by Dara Navaei Sat, 08 Nov 2025 14:06:26 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17047-1 https://devapps.diality.us/cru/DG-DEN-17047-1 Dara Navaei Closed DG-DEN-17047-1 ]]> DG-DENBUG-298-1: closed by Dara Navaei Thu, 10 Apr 2025 15:09:27 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-298-1 https://devapps.diality.us/cru/DG-DENBUG-298-1 Dara Navaei Closed DG-DENBUG-298-1 ]]> DG-DENBUG-298-1: reviewers finished Wed, 09 Apr 2025 16:43:33 -0700 https://devapps.diality.us/cru/DG-DENBUG-298-1 https://devapps.diality.us/cru/DG-DENBUG-298-1 Michael Garthwaite and Sean Nash finished reviewing DG-DENBUG-298-1 DG-DENBUG-298_User Unable TO Deliver Saline P1B Staging ]]> DG-DENBUG-298-1: started by Dara Navaei Tue, 08 Apr 2025 14:25:08 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-298-1 https://devapps.diality.us/cru/DG-DENBUG-298-1 Dara Navaei started review DG-DENBUG-298-1 ]]> DG-DENBUG-307-1: closed by Dara Navaei Fri, 04 Apr 2025 15:04:50 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-307-1 https://devapps.diality.us/cru/DG-DENBUG-307-1 Dara Navaei Closed DG-DENBUG-307-1 ]]> DG-DENBUG-307-1: reviewers finished Fri, 04 Apr 2025 11:00:43 -0700 https://devapps.diality.us/cru/DG-DENBUG-307-1 https://devapps.diality.us/cru/DG-DENBUG-307-1 Michael Garthwaite finished reviewing DG-DENBUG-307-1 DG-DENBUG-307_Concentrate Pump Tube Ruptures During Heat Disinfection Staging ]]> DG-DENBUG-307-1: reviewers finished Wed, 02 Apr 2025 11:14:02 -0700 https://devapps.diality.us/cru/DG-DENBUG-307-1 https://devapps.diality.us/cru/DG-DENBUG-307-1 Sean Nash finished reviewing DG-DENBUG-307-1 DG-DENBUG-307_Concentrate Pump Tube Ruptures During Heat Disinfection Staging ]]> DG-DENBUG-307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 02 Apr 2025 11:13:55 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21867 https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21867 Sean Nash replied to Dara Navaei in DG-DENBUG-307-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DENBUG-307-1: comment by Sean Nash "Not needed, but benign. RESOLVED in CODE WALKT..." Wed, 02 Apr 2025 11:13:43 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21866 https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21866 Sean Nash replied to Dara Navaei in DG-DENBUG-307-1

Not needed, but benign. RESOLVED in CODE WALKTHROUGH.

]]> DG-DENBUG-307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 02 Apr 2025 11:13:11 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21865 https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21865 Sean Nash replied to Dara Navaei in DG-DENBUG-307-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DENBUG-307-1: comment by Dara Navaei "Done" Wed, 02 Apr 2025 10:28:52 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21864 https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21864 Dara Navaei replied to Sean Nash in DG-DENBUG-307-1

Done

]]> DG-DENBUG-307-1: comment by Dara Navaei "Done" Wed, 02 Apr 2025 10:27:50 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21863 https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21863 Dara Navaei replied to Sean Nash in DG-DENBUG-307-1

Done

]]> DG-DENBUG-307-1: comment by Dara Navaei "I used fabs so all are positive when monitoring..." Wed, 02 Apr 2025 10:26:21 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21862 https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21862 Dara Navaei replied to Sean Nash in DG-DENBUG-307-1

I used fabs so all are positive when monitoring is started.

]]> DG-DENBUG-307-1: comment by Sean Nash "This check doesn't make sense to me. Measured ..." Tue, 01 Apr 2025 09:03:02 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21861 https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21861 Sean Nash commented on DG-DENBUG-307-1

This check doesn't make sense to me. Measured speed will only be negative if set direction is reverse. So how could directions ever not match?

]]> DG-DENBUG-307-1: comment by Sean Nash "Aren't speeds (commanded and measured) always p..." Tue, 01 Apr 2025 09:01:22 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21860 https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21860 Sean Nash commented on DG-DENBUG-307-1

Aren't speeds (commanded and measured) always positive? Do we need the fabs?

]]> DG-DENBUG-307-1: comment by Sean Nash "Measured speed (whether real or override) shoul..." Tue, 01 Apr 2025 08:59:42 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21859 https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21859 Sean Nash commented on DG-DENBUG-307-1

Measured speed (whether real or override) should always be positive. And if that's true, we shouldn't need this exception.

]]> DG-DENBUG-307-1: started by Dara Navaei Fri, 07 Mar 2025 11:32:56 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-307-1 https://devapps.diality.us/cru/DG-DENBUG-307-1 Dara Navaei started review DG-DENBUG-307-1 ]]> DG-DEN-17220-1: closed by Dara Navaei Fri, 07 Feb 2025 16:12:39 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17220-1 https://devapps.diality.us/cru/DG-DEN-17220-1 Dara Navaei Closed DG-DEN-17220-1 ]]> DG-DEN-17220-1: reviewers finished Fri, 07 Feb 2025 10:03:27 -0800 https://devapps.diality.us/cru/DG-DEN-17220-1 https://devapps.diality.us/cru/DG-DEN-17220-1 jpaguio  (deleted user) and Sean Nash finished reviewing DG-DEN-17220-1 DG-DEN-17220_Release 20 P1B Staging ]]> DG-DEN-17220-1: started by Dara Navaei Thu, 06 Feb 2025 14:19:30 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17220-1 https://devapps.diality.us/cru/DG-DEN-17220-1 Dara Navaei started review DG-DEN-17220-1 ]]> DG-DEN-17135-1: closed by Dara Navaei Fri, 31 Jan 2025 16:57:30 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17135-1 https://devapps.diality.us/cru/DG-DEN-17135-1 Dara Navaei Closed DG-DEN-17135-1 ]]> DG-DEN-17135-1: reviewers finished Thu, 30 Jan 2025 10:39:28 -0800 https://devapps.diality.us/cru/DG-DEN-17135-1 https://devapps.diality.us/cru/DG-DEN-17135-1 Sean Nash finished reviewing DG-DEN-17135-1 DG-DEN-17135_Concentrate Pump Calibration Staging ]]> DG-DEN-17135-1: reviewers finished Wed, 29 Jan 2025 17:32:19 -0800 https://devapps.diality.us/cru/DG-DEN-17135-1 https://devapps.diality.us/cru/DG-DEN-17135-1 Vinayakam Mani finished reviewing DG-DEN-17135-1 DG-DEN-17135_Concentrate Pump Calibration Staging ]]> DG-DEN-17135-1: comment by Vinayakam Mani "RESOLVED IN CODE WALKTHROUGH" Wed, 29 Jan 2025 17:32:01 -0800 Vinayakam Mani https://devapps.diality.us/cru/DG-DEN-17135-1/#c21294 https://devapps.diality.us/cru/DG-DEN-17135-1/#c21294 Vinayakam Mani replied to Dara Navaei in DG-DEN-17135-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-17135-1: comment by Dara Navaei "Updated the trigger condition. This is a calibr..." Wed, 29 Jan 2025 17:22:53 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17135-1/#c21292 https://devapps.diality.us/cru/DG-DEN-17135-1/#c21292 Dara Navaei replied to Vinayakam Mani in DG-DEN-17135-1

Updated the trigger condition. This is a calibration and is checked in POST. The titles are POST.

]]> DG-DEN-17135-1: comment by Vinayakam Mani "The Trigger condition is little confusing. coul..." Wed, 29 Jan 2025 17:12:35 -0800 Vinayakam Mani https://devapps.diality.us/cru/DG-DEN-17135-1/#c21289 https://devapps.diality.us/cru/DG-DEN-17135-1/#c21289 Vinayakam Mani commented on DG-DEN-17135-1

The Trigger condition is little confusing. could you please reword it? Also In title, do you want to add " fault", if it is DG fault property?

]]> DG-DEN-17135-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 29 Jan 2025 17:14:25 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-17135-1/#c21291 https://devapps.diality.us/cru/DG-DEN-17135-1/#c21291 Sean Nash replied to Dara Navaei in DG-DEN-17135-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-17135-1: comment by Dara Navaei "Removed the typecast." Wed, 29 Jan 2025 16:28:49 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17135-1/#c21277 https://devapps.diality.us/cru/DG-DEN-17135-1/#c21277 Dara Navaei replied to Sean Nash in DG-DEN-17135-1

Removed the typecast.

]]> DG-DEN-17135-1: comment by Sean Nash "Are these castings of (POLYNOMIAL_CAL_PAYLOAD_T..." Wed, 29 Jan 2025 16:26:37 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-17135-1/#c21276 https://devapps.diality.us/cru/DG-DEN-17135-1/#c21276 Sean Nash commented on DG-DEN-17135-1

Are these castings of (POLYNOMIAL_CAL_PAYLOAD_T*) necessary? Seems like &concPump->concentratePumps[ i ] is already that type.

]]> DG-DEN-17135-1: started by Dara Navaei Wed, 20 Nov 2024 09:54:26 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17135-1 https://devapps.diality.us/cru/DG-DEN-17135-1 Dara Navaei started review DG-DEN-17135-1 ]]>